Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108889/ --- (Updated Feb. 12, 2013, 4 a.m.) Review request for kdelibs, Plasma and Dav

Re: Review Request 106771: Make sure KPropertiesDialog inherits all the propertied from the original desktop file when creating a local copy

2013-02-11 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106771/ --- (Updated Feb. 12, 2013, 12:43 a.m.) Review request for kdelibs and David F

Re: Review Request 106771: Make sure KPropertiesDialog inherits the 'Categories' property when creating a new desktop file from an existing one

2013-02-11 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106771/ --- (Updated Feb. 12, 2013, 12:41 a.m.) Review request for kdelibs and David F

Re: Is this a kdelibs regression?

2013-02-11 Thread Thiago Macieira
On terça-feira, 12 de fevereiro de 2013 00.56.05, Albert Astals Cid wrote: > Someone pointed me to > http://quickgit.kde.org/?p=kate.git&a=commitdiff&h:df3cc5473c533f382ae8a48 > 1e452289a56bab3&hpZddc104e5c181c25a3f16d596602d2755db2128 > > I have not had time to look at it but " fix plugin loading

Is this a kdelibs regression?

2013-02-11 Thread Albert Astals Cid
Someone pointed me to http://quickgit.kde.org/?p=kate.git&a=commitdiff&h=3adf3cc5473c533f382ae8a481e452289a56bab3&hp=5addc104e5c181c25a3f16d596602d2755db2128 I have not had time to look at it but " fix plugin loading in KDE SC 4.10.0 " as commit message looks a bit scary, anyone has time to see

Re: Review Request 108434: [High-dpi issues] Fix icon in KPageDialog that shows up in every KCM being hardcoded to 22px

2013-02-11 Thread Thomas Lübking
> On Jan. 16, 2013, 10:01 a.m., Thomas Lübking wrote: > > instead of maintoolbar (which could be 128px on even a netbook) maybe > > relate it to the font height? (what seems to be the idea behind 22px) > > Kai Uwe Broulik wrote: > Main toolbar icon size is only settable from 16 to 48 pixels

Re: Review Request 108434: [High-dpi issues] Fix icon in KPageDialog that shows up in every KCM being hardcoded to 22px

2013-02-11 Thread Thomas Lübking
> On Jan. 16, 2013, 10:01 a.m., Thomas Lübking wrote: > > instead of maintoolbar (which could be 128px on even a netbook) maybe > > relate it to the font height? (what seems to be the idea behind 22px) > > Kai Uwe Broulik wrote: > Main toolbar icon size is only settable from 16 to 48 pixels

Re: Review Request 107791: move Sonnet out of KDEUI, port away from KDE classes.

2013-02-11 Thread Martin Tobias Holmedahl Sandsmark
On Mon, Feb 11, 2013 at 12:57:46PM -, Aleix Pol Gonzalez wrote: > Why are there so many removed files? Shouldn't they be renamed? > Maybe you forgot some git mv? No, I used git mv, and the new files show up, it's just reviewboard that doesn't show the moves properly. -- Martin Sandsmark

Re: Review Request 107409: [KMenuEdit] Ability to sort elements

2013-02-11 Thread Julien Borderie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107409/ --- (Updated Feb. 11, 2013, 7:28 p.m.) Review request for kde-workspace and Al

Re: Review Request 107409: [KMenuEdit] Ability to sort elements

2013-02-11 Thread Julien Borderie
> On Feb. 10, 2013, 10:54 p.m., Albert Astals Cid wrote: > > kmenuedit/treeview.cpp, line 1562 > > > > > > Do we need all this new function for the "Use name if description is > > empty" thing? Wouldn't it be ea

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Thiago Macieira
On segunda-feira, 11 de fevereiro de 2013 16.13.16, David Faure wrote: > Well, this isn't Qt. We can install our stuff where-ever we want, as long as > the right env var points to it (I forgot the name, but I was told there's > such an env var for qtquick2 stuff). But yeah, same defaults can make t

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread David Faure
On Monday 11 February 2013 18:02:39 Sebastian Kügler wrote: > Do we have any canonical place where I set a sensible the QML2_IMPORT_PATH > env var, so we don't have to tell everybody to add this to their setup? The current solution is to document it in http://community.kde.org/Frameworks/Buildin

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Alexander Neundorf
On Sunday 10 February 2013, Sebastian Kügler wrote: > > On Feb. 10, 2013, 3:40 p.m., David Faure wrote: > > > kde-modules/KDEInstallDirs.cmake, line 136 > > > > > line136> > > > > > > For an install prefix in /usr, this

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Sebastian Kügler
On Monday, February 11, 2013 17:43:01 Stephen Kelly wrote: > Sebastian Kügler wrote: > >> What do you need it for, exactly? > > > > To find out where Qt will look for QtQuick2 imports (that's > > $ARCHDATADIR/qml, defaulting to $PREFIX/qml, which leads to /usr/qml). > > > > I'd like to be able to

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Stephen Kelly
Sebastian Kügler wrote: >> What do you need it for, exactly? > > To find out where Qt will look for QtQuick2 imports (that's > $ARCHDATADIR/qml, defaulting to $PREFIX/qml, which leads to /usr/qml). > > I'd like to be able to install Plasma QtQuick2 imports into a path where > they'll actually be

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread David Faure
> On Feb. 10, 2013, 3:40 p.m., David Faure wrote: > > kde-modules/KDEInstallDirs.cmake, line 136 > > > > > > For an install prefix in /usr, this would make it /usr/qml ... is this > > really wanted? > > > >

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Sebastian Kügler
On Monday, February 11, 2013 17:03:55 Stephen Kelly wrote: > Sebastian Kügler wrote: > > On Sunday, February 10, 2013 14:33:49 Thiago Macieira wrote: > >> On domingo, 10 de fevereiro de 2013 21.22.05, Sebastian Kügler wrote: > >> > Apparently not. I've looked at where the example imports from the Q

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Stephen Kelly
Sebastian Kügler wrote: > On Sunday, February 10, 2013 14:33:49 Thiago Macieira wrote: >> On domingo, 10 de fevereiro de 2013 21.22.05, Sebastian Kügler wrote: >> > Apparently not. I've looked at where the example imports from the Qt >> > codebase install these things, and that is indeed $PREFIX/q

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Thiago Macieira
On segunda-feira, 11 de fevereiro de 2013 12.21.48, Sebastian Kügler wrote: > On Monday, February 11, 2013 10:49:08 Sebastian Kügler wrote: > > On Sunday, February 10, 2013 14:33:49 Thiago Macieira wrote: > > > On domingo, 10 de fevereiro de 2013 21.22.05, Sebastian Kügler wrote: > > > > Apparently

Re: Review Request 107791: move Sonnet out of KDEUI, port away from KDE classes.

2013-02-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107791/#review27196 --- Why are there so many removed files? Shouldn't they be renamed?

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Sebastian Kügler
[adding frameworks list, slipped out] On Monday, February 11, 2013 10:49:08 Sebastian Kügler wrote: > On Sunday, February 10, 2013 14:33:49 Thiago Macieira wrote: > > On domingo, 10 de fevereiro de 2013 21.22.05, Sebastian Kügler wrote: > > > Apparently not. I've looked at where the example import

Re: Review Request 108685: Make it possible to overwrite content-lenght using metaData

2013-02-11 Thread Àlex Fiestas
> On Feb. 10, 2013, 8:43 p.m., Dawit Alemayehu wrote: > > Why not simply use the KIO::http_post function that accepts a pointer to > > QIODevice ? All you have to do is set the pointer to NULL, pass the total > > total size to the ioslave and it should work for the scenario you outlined. > > >

Re: Review Request 107678: Keep clickmessage text visible when empty and focused

2013-02-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107678/#review27190 --- This review has been submitted with commit a55ec54f0849e510d59

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Sebastian Kügler
On Sunday, February 10, 2013 14:33:49 Thiago Macieira wrote: > On domingo, 10 de fevereiro de 2013 21.22.05, Sebastian Kügler wrote: > > Apparently not. I've looked at where the example imports from the Qt > > codebase install these things, and that is indeed $PREFIX/qml, not inside > > the plugin

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

2013-02-11 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108802/#review27187 --- Thanks Dawit for working on this! Concerning your question: th