Re: Review Request 108770: Fix double-free in ~KCompositeJobPrivate

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108770/#review26820 --- This review has been submitted with commit 6dc74176dab5d4a34d0

Re: Review Request 107716: Fix generating kconfig skeletons with UrlList fields that have a default value

> On Dec. 18, 2012, 10:59 a.m., David Faure wrote: > > Looks good (I'll try a full kde recompile with it, to see if it breaks > > anything). > > > > An addition to the kconfig_compiler unittests is missing, though, could you > > add that? > > > > Aleix Pol Gonzalez wrote: > Sure makes sen

Re: Review Request 108637: Fix KColorButton change color + cancel behaviour

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108637/#review26798 --- This review has been submitted with commit f3f6b9c7d533c3c03ce

Re: Review Request 108057: Add some new User Agent files for spoofing browser identities in konqueror, rekonq

> On Jan. 7, 2013, 12:33 p.m., Frank Reininghaus wrote: > > Please run git pull --rebase before pushing any non-merge commits to > > prevent polluting the logs with commits like > > > > http://quickgit.kde.org/?p=kde-baseapps.git&a=commit&h=94b3817429b470eed5687922661832b260bcc06c > > > > Than

Re: Review Request 108711: kcmdatetimehelper: Hardcode PATH because $PATH is empty here.

> On Feb. 6, 2013, 10:26 p.m., Commit Hook wrote: > > This review has been submitted with commit > > c517bbc175a3fbb09f13a8468a6987fdbc547d23 by Kevin Kofler to branch KDE/4.10. … and merged to master with merge commit e99a0e5b1223b7a673b0bc29c280d962c6e8dfb6. - Kevin -

Re: Login for bug reporting

On Wednesday 06 February 2013 23:00:53 Martin Graesslin wrote: > On Wednesday 06 February 2013 22:41:25 Myriam Schweingruber wrote: > > Hi all, > > > > On Wed, Feb 6, 2013 at 10:20 PM, Frank Reininghaus > > > > wrote: > > > Am 06.02.2013 18:57 schrieb "Kevin Krammer": > > >> Hi folks, > > >> >

Review Request 108822: Define KAuth::ActionReply::setType

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108822/ --- Review request for kdelibs. Description --- void KAuth::ActionReply::

Re: Review Request 108711: kcmdatetimehelper: Hardcode PATH because $PATH is empty here.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108711/#review26785 --- This review has been submitted with commit c517bbc175a3fbb09f1

Re: kwalletmanager ui refactor

On Wednesday 06 February 2013 14:28:17 Aurélien Gâteau wrote: > On 05.02.2013 21:34, Valentin Rusu wrote: > >> > >> I assumed the "Disconnect" button listed applications authorized to > >> access > >> the wallet. The "Authorized applications" tab was thus another way > >> to show > >> its content.

Re: Login for bug reporting

On Wednesday 06 February 2013 22:41:25 Myriam Schweingruber wrote: > Hi all, > > On Wed, Feb 6, 2013 at 10:20 PM, Frank Reininghaus > > wrote: > > Am 06.02.2013 18:57 schrieb "Kevin Krammer": > >> Hi folks, > >> > >> at FOSDEM I was approached by a person who asked me to relay his > >> dissatis

Re: Login for bug reporting

Kevin Krammer wrote: > Hi folks, > > at FOSDEM I was approached by a person who asked me to relay his > dissatisfaction with the requirement of having a KDE Bugzilla account to > report crashes via the KDE crash handler dialog. > > The issue in his case was kind of made worse by having this obsta

Re: Login for bug reporting

Hi all, On Wed, Feb 6, 2013 at 10:20 PM, Frank Reininghaus wrote: > > Am 06.02.2013 18:57 schrieb "Kevin Krammer": >> >> Hi folks, >> >> at FOSDEM I was approached by a person who asked me to relay his >> dissatisfaction with the requirement of having a KDE Bugzilla account to >> report crashes v

Re: Login for bug reporting

Am 06.02.2013 18:57 schrieb "Kevin Krammer": > > Hi folks, > > at FOSDEM I was approached by a person who asked me to relay his > dissatisfaction with the requirement of having a KDE Bugzilla account to > report crashes via the KDE crash handler dialog. > > The issue in his case was kind of made wo

Re: Login for bug reporting

2013/2/6, Kevin Krammer : > Hi folks, > > at FOSDEM I was approached by a person who asked me to relay his > dissatisfaction with the requirement of having a KDE Bugzilla account to > report crashes via the KDE crash handler dialog. > > The issue in his case was kind of made worse by having this ob

Re: Login for bug reporting

Onsdag den 6. februar 2013 21:52:53 skrev Alex Fiestas: > On Wednesday 06 February 2013 20:36:33 Christoph Cullmann wrote: > > Hi, > > > > actually, if he has taken the obstacles of installing tens of megabytes of > > stuff, what was the problem with creating an account? > > Haven't it ever happe

Re: Login for bug reporting

On Wednesday 06 February 2013 20:36:33 Christoph Cullmann wrote: > Hi, > > actually, if he has taken the obstacles of installing tens of megabytes of > stuff, what was the problem with creating an account? Haven't it ever happened to you that you are buying something on the interwebs or checking

Re: Review Request 108770: Fix double-free in ~KCompositeJobPrivate

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108770/#review26776 --- Ship it! Ship It! - Kevin Ottens On Feb. 6, 2013, 1:15 p.m.

Re: Login for bug reporting

Hi, actually, if he has taken the obstacles of installing tens of megabytes of stuff, what was the problem with creating an account? Was it some problem with privacy, that he doesn't want his mail to register there (than he won't give his mail address as feedback point, anyway) or was the proc

Re: Review Request 108808: Do not reset opacity if call for GetWindowProperty fails

> On Feb. 6, 2013, 4:29 p.m., Thomas Lübking wrote: > > If the property does not exist or is of wrong type or contains junk, the > > reasonable return value would be 1.0, not 0.0 - agreed? > > I mean, if the client withdraws the property and it would get read agin, > > the client would expect t

Login for bug reporting

Hi folks, at FOSDEM I was approached by a person who asked me to relay his dissatisfaction with the requirement of having a KDE Bugzilla account to report crashes via the KDE crash handler dialog. The issue in his case was kind of made worse by having this obstacle appear too late, i.e. after

Re: Review Request 108727: ktimezoned: Watch /etc/localtime if it doesn't exist yet.

> On Feb. 5, 2013, 8:27 p.m., David Faure wrote: > > Looks ok to me, although I don't really know this code. So, should I wait for David Jarvie or some other person who feels familiar with this code to give it a go, or do you think I can commit this right now? - Kevin --

Re: Review Request 108808: Do not reset opacity if call for GetWindowProperty fails

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108808/#review26760 --- If the property does not exist or is of wrong type or contains

Re: Review Request 107678: Keep clickmessage text visible when empty and focused

> On Dec. 12, 2012, 7:43 p.m., Laszlo Papp wrote: > > It did not get a ship it back then for the plasma components, but I would > > not like to block the rediscussion, just saying what happened earlier. :-) > > > > https://git.reviewboard.kde.org/r/104895/ > > David Edmundson wrote: > One

Re: Review Request 108770: Fix double-free in ~KCompositeJobPrivate

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108770/ --- (Updated Feb. 6, 2013, 1:15 p.m.) Review request for kdelibs and Kevin Ott

Re: Review Request 108770: Fix double-free in ~KCompositeJobPrivate

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108770/ --- (Updated Feb. 6, 2013, 11:33 a.m.) Review request for kdelibs and Kevin Ot

Re: Review Request 108808: Do not reset opacity if call for GetWindowProperty fails

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108808/#review26756 --- Works fine here. - Aurélien Gâteau On Feb. 6, 2013, 3:38 p.m

Review Request 108808: Do not reset opacity if call for GetWindowProperty fails

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108808/ --- Review request for kdelibs and kwin. Description --- Do not reset opa

Re: kwalletmanager ui refactor

On 05.02.2013 21:34, Valentin Rusu wrote: On Tuesday 05 February 2013 10:49:55 Aurélien Gâteau wrote: > 2. The disconnect button should be kept, in my opinnion. Here is a screen > capture with the disconnect menu for my main wallet: > http://imgur.com/JG6rr8b > > And here is another one showi

Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108802/ --- Review request for KDE Base Apps, David Faure and Frank Reininghaus. Descr

Re: Review Request 108770: Fix double-free in ~KCompositeJobPrivate

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108770/#review26748 --- kdecore/tests/kcompositejobtest.cpp

Re: Review Request 108770: Fix double-free in ~KCompositeJobPrivate

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108770/#review26717 --- I'd add the setParent(0), document it, and then this looks ok t