kwalletmanager ui refactor

2013-02-04 Thread Thomas Lübking
Am Dienstag, 5. Februar 2013 schrieb Matthew Dawson : > I think you missed my point. I wasn't trying to imply kwalletmanager would > remain open unless it was called for. It behaves perfectly in that sense. I > was talking only about the systray icon, and whether it was the best way to > achieve

Re: kwalletmanager ui refactor

2013-02-04 Thread Matthew Dawson
On February 4, 2013 09:06:01 PM Valentin Rusu wrote: > On Monday 04 February 2013 03:03:13 Matthew Dawson wrote: > > On February 3, 2013 04:51:49 PM Thomas Lübking wrote: > > > Btw: does anybody actually use the systray thing? > > > I need to see that window ~ once a week and then just launch the >

Re: kwalletmanager ui refactor

2013-02-04 Thread Valentin Rusu
On Monday 04 February 2013 22:08:49 Aurélien Gâteau wrote: > Le Monday 04 February 2013 20:55:12 Albert Astals Cid a écrit : > > El Dilluns, 4 de febrer de 2013, a les 19:28:42, Aurélien Gâteau va > > escriure: > > > Le Sunday 03 February 2013 14:50:33 Valentin Rusu a écrit : > > Having said so,

Re: Review Request 108776: apidoc: Make inherited sections collapsable and expandable

2013-02-04 Thread Allen Winter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108776/#review26651 --- Ship it! I believe doxygen itself copies the jquery.js and dyn

Re: kwalletmanager ui refactor

2013-02-04 Thread Valentin Rusu
On Monday 04 February 2013 19:28:42 Aurélien Gâteau wrote: > Le Sunday 03 February 2013 14:50:33 Valentin Rusu a écrit : > > A screen capture is far better than a hundred words so here it is: > > http://imgur.com/MD3GDxO > > Hey, > > Nice work! Thanks! > I put together a mockup which reorganiz

Re: kwalletmanager ui refactor

2013-02-04 Thread Aurélien Gâteau
Le Monday 04 February 2013 20:55:12 Albert Astals Cid a écrit : > El Dilluns, 4 de febrer de 2013, a les 19:28:42, Aurélien Gâteau va escriure: > > Le Sunday 03 February 2013 14:50:33 Valentin Rusu a écrit : > > > Hello, > > > > > > Lots of us are frequently using kwalletmanager to get/store the

Re: Review Request 108711: kcmdatetimehelper: Hardcode PATH because $PATH is empty here.

2013-02-04 Thread Konstantinos Smanis
> On Feb. 4, 2013, 3:53 p.m., Konstantinos Smanis wrote: > > We can do better than hardcoding a reasonable default. We can launch a > > login shell (1) and 'echo $PATH' the user's PATH. This has many advantages: > > > > 1. We don't miss paths (e.g. /usr/local/bin, /usr/local/sbin etc.). > > 2.

Re: kwalletmanager ui refactor

2013-02-04 Thread Valentin Rusu
On Monday 04 February 2013 03:03:13 Matthew Dawson wrote: > On February 3, 2013 04:51:49 PM Thomas Lübking wrote: > > Btw: does anybody actually use the systray thing? > > I need to see that window ~ once a week and then just launch the > > walletmanager (so the systray icon is disabled, but that's

Re: kwalletmanager ui refactor

2013-02-04 Thread Albert Astals Cid
El Dilluns, 4 de febrer de 2013, a les 19:28:42, Aurélien Gâteau va escriure: > Le Sunday 03 February 2013 14:50:33 Valentin Rusu a écrit : > > Hello, > > > > Lots of us are frequently using kwalletmanager to get/store the secrets > > for > > the ever extending sensitive information. We click it's

Re: Review Request 108711: kcmdatetimehelper: Hardcode PATH because $PATH is empty here.

2013-02-04 Thread Kevin Kofler
> On Feb. 4, 2013, 3:53 p.m., Konstantinos Smanis wrote: > > We can do better than hardcoding a reasonable default. We can launch a > > login shell (1) and 'echo $PATH' the user's PATH. This has many advantages: > > > > 1. We don't miss paths (e.g. /usr/local/bin, /usr/local/sbin etc.). > > 2.

Re: kwalletmanager ui refactor

2013-02-04 Thread Valentin Rusu
On Sunday 03 February 2013 13:34:24 Michael Pyne wrote: > On Sunday, February 03, 2013 14:50:33 Valentin Rusu wrote: > > > > During last days I finally sat down and did a ui-refactor and now > > kwalletmanager handles all the wallets inside a single, KPageWidget based > > design. A screen capture

Re: Review Request 108711: kcmdatetimehelper: Hardcode PATH because $PATH is empty here.

2013-02-04 Thread Kevin Kofler
> On Feb. 4, 2013, 3:53 p.m., Konstantinos Smanis wrote: > > We can do better than hardcoding a reasonable default. We can launch a > > login shell (1) and 'echo $PATH' the user's PATH. This has many advantages: > > > > 1. We don't miss paths (e.g. /usr/local/bin, /usr/local/sbin etc.). > > 2.

Re: Review Request 108711: kcmdatetimehelper: Hardcode PATH because $PATH is empty here.

2013-02-04 Thread Thomas Lübking
> On Feb. 4, 2013, 3:53 p.m., Konstantinos Smanis wrote: > > We can do better than hardcoding a reasonable default. We can launch a > > login shell (1) and 'echo $PATH' the user's PATH. This has many advantages: > > > > 1. We don't miss paths (e.g. /usr/local/bin, /usr/local/sbin etc.). > > 2.

Re: Review Request 108711: kcmdatetimehelper: Hardcode PATH because $PATH is empty here.

2013-02-04 Thread Konstantinos Smanis
> On Feb. 4, 2013, 3:53 p.m., Konstantinos Smanis wrote: > > We can do better than hardcoding a reasonable default. We can launch a > > login shell (1) and 'echo $PATH' the user's PATH. This has many advantages: > > > > 1. We don't miss paths (e.g. /usr/local/bin, /usr/local/sbin etc.). > > 2.

Re: kwalletmanager ui refactor

2013-02-04 Thread Aurélien Gâteau
Le Sunday 03 February 2013 14:50:33 Valentin Rusu a écrit : > Hello, > > Lots of us are frequently using kwalletmanager to get/store the secrets for > the ever extending sensitive information. We click it's icon to pop the main > window, then double click the main wallet icon to pop another window

Review Request 108776: apidoc: Make inherited sections collapsable and expandable

2013-02-04 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108776/ --- Review request for kdelibs, Adriaan de Groot and Allen Winter. Description

Re: Review Request 108711: kcmdatetimehelper: Hardcode PATH because $PATH is empty here.

2013-02-04 Thread Konstantinos Smanis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108711/#review26617 --- We can do better than hardcoding a reasonable default. We can l

Re: KDE Review: Kor - a minimalistic desktop shell

2013-02-04 Thread Lubos Lunak
Hello, On Monday 04 of February 2013, Martin Sandsmark wrote: > Dear esteemed ladies and gentlemen (and everyone in between), > > Kor is a simple and minimalistic desktop shell with support for plasmoids, > plasma wallpapers, etc., but also its own minimalistic plugins/widgets. > > It is an opti

Review Request 108770: Fix double-free in ~KCompositeJobPrivate

2013-02-04 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108770/ --- Review request for kdelibs. Description --- Fix double-free in ~KComp

KDE Review: Kor - a minimalistic desktop shell

2013-02-04 Thread Martin Sandsmark
Dear esteemed ladies and gentlemen (and everyone in between), Kor is a simple and minimalistic desktop shell with support for plasmoids, plasma wallpapers, etc., but also its own minimalistic plugins/widgets. It is an option for those with low-end hardware or who don't need a full Plasma desktop.

Re: kwalletmanager ui refactor

2013-02-04 Thread Matthew Dawson
On February 3, 2013 04:51:49 PM Thomas Lübking wrote: > > Btw: does anybody actually use the systray thing? > I need to see that window ~ once a week and then just launch the > walletmanager (so the systray icon is disabled, but that's afaik not the > default, is it?) Is it really necessary to ha