Re: Input method integration for KDE 4.11

2013-01-31 Thread Andriy Rysin
If we're just adding, not replacing, I'm totally for adding IM module. If that works well enough we can consider tighter integration to benefit from IM advantages Andriy On Jan 26, 2013 10:14 AM, "Weng Xuetian" wrote: > On Saturday 26 January 2013 13:03:29，Todd : > > On Sat, Jan 26, 2013 at 3:41

Re: Review Request 108367: Complete keyboard preview rework for KControl

2013-01-31 Thread Andriy Rysin
> On Jan. 26, 2013, 3:13 a.m., Andriy Rysin wrote: > > Manuel, I like how it looks in general with rounded corners and space > > between keys, but I must say that the font size is quite small. E.g. small > > letters are not easy to read even with good eyes, I wander if there's a way > > to rea

Re: Review Request 108675: kjs: Implement Function.prototype.bind

2013-01-31 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108675/ --- (Updated Feb. 1, 2013, 12:58 a.m.) Review request for kdelibs. Changes -

Re: Review Request 108675: kjs: Implement Function.prototype.bind

2013-01-31 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108675/ --- (Updated Feb. 1, 2013, 12:29 a.m.) Review request for kdelibs. Changes -

Re: Review Request 108570: This patch add support for bulk operations in systemtray applet settings.

2013-01-31 Thread Chao Feng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108570/#review26453 --- File Attachment: Bulk operations (2nd layout) - 2

Re: Review Request 106861: Add pkgconfig hints to FindSamba.cmake

2013-01-31 Thread Rex Dieter
> On Jan. 31, 2013, 5:47 p.m., Alexander Neundorf wrote: > > Is setting CMAKE_PREFIX_PATH not enough to make it work ? > > Where is the non-standard location which needs to be searched in your case ? Without this, headers in /usr/include/samba-4.0 are not found (and I figured it better long-ter

Re: Review Request 106861: Add pkgconfig hints to FindSamba.cmake

2013-01-31 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106861/#review26461 --- Is setting CMAKE_PREFIX_PATH not enough to make it work ? Where

Re: Review Request 106861: Add pkgconfig hints to FindSamba.cmake

2013-01-31 Thread Rex Dieter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106861/ --- (Updated Jan. 31, 2013, 4:58 p.m.) Review request for kdelibs. Changes -

Review Request 108685: Make it possible to overwrite content-lenght using metaData

2013-01-31 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108685/ --- Review request for kdelibs, Dawit Alemayehu and Andreas Hartmetz. Descript

Re: Review Request 108570: This patch add support for bulk operations in systemtray applet settings.

2013-01-31 Thread Sandro Andrade
> On Jan. 31, 2013, 10:16 a.m., Chao Feng wrote: > > File Attachment: Bulk operations (2nd layout) - 2 > > > > > > I think lots of people will be confused by this check list. Why I need > > to select it? The action button is too far away.

Re: Review Request 107409: [KMenuEdit] Ability to sort elements

2013-01-31 Thread Julien Borderie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107409/ --- (Updated Jan. 30, 2013, 10:40 p.m.) Review request for kde-workspace and A

Re: Review Request 107409: [KMenuEdit] Ability to sort elements

2013-01-31 Thread Julien Borderie
> On Jan. 26, 2013, 4:54 p.m., Albert Astals Cid wrote: > > kmenuedit/kmenuedit.cpp, line 96 > > > > > > - Julien --- This is an automatically generated e-mai