Re: Review Request 107409: [KMenuEdit] Ability to sort elements

2013-01-19 Thread Julien Borderie
> On Jan. 19, 2013, 5 p.m., Albert Astals Cid wrote: > > Quick question, this sorting does affect only the view of kmenuedit or > > affects also the K-menu? Yes, it affects the KMenu. I updated description and test cases. > On Jan. 19, 2013, 5 p.m., Albert Astals Cid wrote: > > kmenuedit/tree

Re: Review Request 107409: [KMenuEdit] Ability to sort elements

2013-01-19 Thread Julien Borderie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107409/ --- (Updated Jan. 19, 2013, 10:09 p.m.) Review request for kde-workspace and A

Re: Review Request 108471: return icon for helper type protocol

2013-01-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108471/#review25809 --- Makes sense. However I don't like the logic duplication, for fu

Re: Review Request 108471: return icon for helper type protocol

2013-01-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108471/#review25808 --- Makes sense. However I don't like the logic duplication, for fu

Re: Review Request 107409: [KMenuEdit] Ability to sort elements

2013-01-19 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107409/#review25800 --- Quick question, this sorting does affect only the view of kmenu

Re: Review Request 107409: [KMenuEdit] Ability to sort elements

2013-01-19 Thread Julien Borderie
> On Jan. 17, 2013, 8:12 p.m., Christoph Feck wrote: > > Thanks Julien for the patch. Please ask for help in in #kde-devel irc > > channel, or on an KDE developers mailing list. The diff needs to be > > uploaded differently. Thank you for your reply, it should be correctly uploaded now. - Ju