Re: Review Request 108427: [High-dpi issues] Fix System Settings tooltips being hardcoded

2013-01-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108427/#review25616 --- This review has been submitted with commit c2a0f9f09060472db1d

Review Request 108430: Fix i18n context handling in kconfig_compiler

2013-01-15 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108430/ --- Review request for kdelibs. Description --- Just one context variable

Re: Small API change exception for KActivities::Info

2013-01-15 Thread Ivan Čukić
> If it's going to make things faster and it's just exposing an existing > method i'd say go for it, after all people are committing patches that are Aaron's stance on this is to leave it as it is since it is only used by SLC which is not released on the desktop, and he doesn't want to introduce

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2013-01-15 Thread André Wöbbeking
On Monday 14 January 2013 20:51:57 Albert Astals Cid wrote: > El Dilluns, 14 de gener de 2013, a les 20:36:03, André Wöbbeking va escriure: > > On Monday 14 January 2013 20:25:21 Albert Astals Cid wrote: > > > If you think that packagers should be informed about this change what > > > are you wai

Re: Review Request 108427: [High-dpi issues] Fix System Settings tooltips being hardcoded

2013-01-15 Thread Ben Cooksley
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108427/#review25613 --- Ship it! I would suggest separating the white space changes ou

Review Request 108427: [High-dpi issues] Fix System Settings tooltips being hardcoded

2013-01-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108427/ --- Review request for kde-workspace. Description --- Icons in tooltips o

Re: Small API change exception for KActivities::Info

2013-01-15 Thread Albert Astals Cid
El Dimarts, 15 de gener de 2013, a les 12:51:38, Ivan Čukić va escriure: > Hi all, Hi > I'm requesting an api freeze exception for the KActivities::Info class to > introduce a simple const method: > bool isResourceLinked(const KUrl & url); > > The implementation for the method already exists

Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal

2013-01-15 Thread Thomas Lübking
> On Jan. 12, 2013, 5:25 p.m., Xuetian Weng wrote: > > After several days test, so far no problem here. Ok, everyone. Thu 17. Jan 00:59:00 CET 2013 : KDE SC 4.10 Tagging Freeze for Release Candidate 3 If we want such workaround in 4.10 I suggest to push it before that date, i'll not pus

Re: Review Request 108308: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

2013-01-15 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108308/#review25583 --- i'm fine with this going in for 4.11 where we can get reasonabl

Re: Review Request 108197: Make KRunner "Enter" work again in 4.10

2013-01-15 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108197/#review25580 --- the reason for the change was that hitting "enter" too quickly

Re: Review Request 108197: Make KRunner "Enter" work again in 4.10

2013-01-15 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108197/#review25579 --- the reason for the change was that hitting "enter" too quickly

Small API change exception for KActivities::Info

2013-01-15 Thread Ivan Čukić
Hi all, I'm requesting an api freeze exception for the KActivities::Info class to introduce a simple const method: bool isResourceLinked(const KUrl & url); The implementation for the method already exists, it is just not published in the API. The reason for this is that because the former

Review Request 108418: use system to suspend and hibernate in powerdevil

2013-01-15 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108418/ --- Review request for kde-workspace, Solid, Dario Freddi, and Lukáš Tinkl. De