Re: Review Request 108367: Complete keyboard preview rework for KControl

2013-01-13 Thread Xuetian Weng
> On Jan. 13, 2013, 12:27 p.m., Xuetian Weng wrote: > > You may want to look this: > > https://github.com/fcitx/kcm-fcitx/blob/master/layout/keyboardlayoutwidget.cpp > > > > It's a more featured widget in fcitx (but the code I mentioned is only > > depends on qt/xkb). > > > > Your implementati

Re: Review Request 108367: Complete keyboard preview rework for KControl

2013-01-13 Thread Manuel Tortosa
> On Jan. 13, 2013, 12:27 p.m., Xuetian Weng wrote: > > You may want to look this: > > https://github.com/fcitx/kcm-fcitx/blob/master/layout/keyboardlayoutwidget.cpp > > > > It's a more featured widget in fcitx (but the code I mentioned is only > > depends on qt/xkb). > > > > Your implementati

Re: Review Request 108367: Complete keyboard preview rework for KControl

2013-01-13 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108367/#review25363 --- You may want to look this: https://github.com/fcitx/kcm-fcitx/b

Re: Review Request 108380: Fix race condition in KTcpSocketTest

2013-01-13 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108380/ --- (Updated Jan. 13, 2013, 11:54 a.m.) Review request for KDE Frameworks and

Re: Review Request 108380: Fix race condition in KTcpSocketTest

2013-01-13 Thread Jon Severinsson
> On Jan. 13, 2013, 10:58 a.m., David Faure wrote: > > kdecore/tests/ktcpsockettest.cpp, line 237 > > > > > > The relies on the current content of the page being fetched? :-) > > > > If hardcoding th

Review Request 108380: Fix race condition in KTcpSocketTest

2013-01-13 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108380/ --- Review request for KDE Frameworks and kdelibs. Description --- In som

Re: Review Request 108380: Fix race condition in KTcpSocketTest

2013-01-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108380/#review25360 --- kdecore/tests/ktcpsockettest.cpp

Re: Plans for SVN infrastructure shutdown

2013-01-13 Thread Urs Wolfer
On 2013-01-12 23:24, Ben Cooksley wrote: On Mon, Jan 7, 2013 at 3:26 AM, Urs Wolfer wrote: On 2013-01-02 22:52, Nicolás Alvarez wrote: Hello KDE developers! As you know, a few years ago KDE decided to move to Git, and a lot of our applications were migrated. However, we're not done yet. SV

Re: Review Request 108380: Fix race condition in KTcpSocketTest

2013-01-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108380/#review25346 --- Woohoo, it's Christmas again :) This flaky test was bothering m

Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal

2013-01-13 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/#review25307 --- After several days test, so far no problem here. - Xuetian Wen

Re: Review Request 108367: Complete keyboard preview rework for KControl

2013-01-13 Thread Manuel Tortosa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108367/ --- (Updated Jan. 12, 2013, 5:13 p.m.) Review request for kde-workspace. Des

Re: Review Request 108367: Complete keyboard preview rework for KControl

2013-01-13 Thread Manuel Tortosa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108367/ --- (Updated Jan. 12, 2013, 5:11 p.m.) Review request for kde-workspace. Des

Re: Review Request 108367: Complete keyboard preview rework for KControl

2013-01-13 Thread Manuel Tortosa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108367/ --- (Updated Jan. 12, 2013, 5:11 p.m.) Review request for kde-workspace. Des