Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-08 Thread Thomas Lübking
> On Jan. 9, 2013, 1:38 a.m., Xuetian Weng wrote: > > kdeui/windowmanagement/kwindowsystem_x11.cpp, line 168 > > > > > > I don't quite get why this part is required. Since KWindowSystem > > already calls SelectSe

Re: KDEREVIEW: Mangonel

2013-01-08 Thread Allen Winter
On Tuesday 08 January 2013 09:08:11 PM Martin Sandsmark wrote: > Dear Sirs and Madams, > > Mangonel has just been moved to KDE Review. > No docbook manual Do you want apidox generated? if so you also need a Mainpage.dox Bart's email address is missing from the Copyright statements in many files

Re: KDEREVIEW: Mangonel

2013-01-08 Thread Martin Sandsmark
Hi, thanks for the review! On Tuesday 08 January 2013 23:12:01 Albert Astals Cid wrote: > Which is its intended destination extragear-something? Yes, sorry, I forgot to mention, it is destined for extragear/base. > Any reason not to use bugs.kde.org? Fixed. > The i18n is quite broken, a simpl

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-08 Thread Thomas Lübking
> On Jan. 8, 2013, 11:15 p.m., Xuetian Weng wrote: > > after I apply the patch, I notice that in some random unknnow case > > KWindowSystem will emit the signal, while KSelectionOwner is not. (And I > > think KSelectionOwner is correct since I didn't do anything to kwin), and I > > notice some

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-08 Thread Thomas Lübking
> On Jan. 8, 2013, 11:15 p.m., Xuetian Weng wrote: > > after I apply the patch, I notice that in some random unknnow case > > KWindowSystem will emit the signal, while KSelectionOwner is not. (And I > > think KSelectionOwner is correct since I didn't do anything to kwin), and I > > notice some

Re: KDEREVIEW: Mangonel

2013-01-08 Thread Albert Astals Cid
El Dimarts, 8 de gener de 2013, a les 21:08:11, Martin Sandsmark va escriure: > Dear Sirs and Madams, > > Mangonel has just been moved to KDE Review. > > Mangonel is a simple and lightweight application launcher in the vein of > Katapult from ye olde KDE 3 days, kind of reminiscent of the "task o

Review Request: Rework fix for bug 279675 so that the new mimetype is used by KRun too.

2013-01-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108277/ --- Review request for kdelibs and Dawit Alemayehu. Description --- Rewor

KDEREVIEW: Mangonel

2013-01-08 Thread Martin Sandsmark
Dear Sirs and Madams, Mangonel has just been moved to KDE Review. Mangonel is a simple and lightweight application launcher in the vein of Katapult from ye olde KDE 3 days, kind of reminiscent of the "task oriented" UI for krunner, but dropping the slow krunner architecture in favour of a simp

Re: Review Request: Correction of bug 235710 : Plasma Wallpaper Slideshow to periodially recheck contents of image folder

2013-01-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107821/#review24996 --- This review has been submitted with commit baebc4e203da5d0457f

Re: Review Request: KHTML, imload: Fix wrong version of last line of scaled tile

2013-01-08 Thread Albert Astals Cid
> On Jan. 7, 2013, 6:30 p.m., Albert Astals Cid wrote: > > Evil: do you think you could provide a test? Seems like if you already have > > an image that files, maybe it wouldn't be that hard? > > Aurélien Gâteau wrote: > Can be done, but I don't know where to put such tests: there is > kht

Re: plasma and new shadow mess

2013-01-08 Thread Thomas Lübking
On Dienstag, 8. Januar 2013 18:40:58 CEST, Alexander Neundorf wrote: What is TFP ? gl_texture_from_pixmap() ;-)

Re: plasma and new shadow mess

2013-01-08 Thread Alexander Neundorf
On Monday 07 January 2013, Martin Gräßlin wrote: ... > What I have measured is the rendering of window decorations which is > basically the pain point of our complete rendering stack and follows a > similar approach to rendering (each side rendered to a pixmap, TFP done What is TFP ? Alex

Re: Finalized proposal for changes to i18n in KF5

2013-01-08 Thread Chusslove Illich
>> [: Chusslove Illich :] >> I'm not opposed to some additional bureaucracy in order to make the >> framework more accessible to potential users. [...] > > [: Oswald Buddenhagen :] > [...] i'd hate it to see my thoroughly engineered code being displaced by > a (possibly even slightly inferior) comp

Re: Review Request: KHTML, imload: Fix wrong version of last line of scaled tile

2013-01-08 Thread Aurélien Gâteau
> On Jan. 7, 2013, 6:30 p.m., Albert Astals Cid wrote: > > Evil: do you think you could provide a test? Seems like if you already have > > an image that files, maybe it wouldn't be that hard? Can be done, but I don't know where to put such tests: there is khtml/test/ but this contains only a f

Re: Review Request: KHTML, imload: Fix wrong version of last line of scaled tile

2013-01-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108246/#review24968 --- This review has been submitted with commit 3a970387fd369c9409f

Re: Review Request: Correction of bug 235710 : Plasma Wallpaper Slideshow to periodially recheck contents of image folder

2013-01-08 Thread Erwan MATHIEU
> On Jan. 7, 2013, 6:38 p.m., Jeremy Paul Whiting wrote: > > Looks good to me, I wonder why you changed the suffix bits the way you did, > > why not just make it initialized in the BackgroundFinder constructor and > > use m_suffixes directly instead of calling suffixes() itself? > > Jeremy Pau

Re: Review Request: qml based kwin shadow

2013-01-08 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/ --- (Updated Jan. 8, 2013, 12:21 a.m.) Review request for kde-workspace, kwin,