Re: Finalized proposal for changes to i18n in KF5

On Sat, Jan 05, 2013 at 06:38:58PM +0100, Chusslove Illich wrote: > > [: Oswald Buddenhagen :] > > of course, it would be even better if you strived for submission to qt- > > project, if at all realistic (for now probably an add-on, but definitely > > under cla). otherwise you'll see the same effec

Re: Review Request: Correction of bug 235710 : Plasma Wallpaper Slideshow to periodially recheck contents of image folder

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107821/#review24952 --- Ship it! Ship It! - Jeremy Paul Whiting On Dec. 21, 2012, 5

Re: Review Request: Correction of bug 235710 : Plasma Wallpaper Slideshow to periodially recheck contents of image folder

> On Jan. 7, 2013, 6:38 p.m., Jeremy Paul Whiting wrote: > > Looks good to me, I wonder why you changed the suffix bits the way you did, > > why not just make it initialized in the BackgroundFinder constructor and > > use m_suffixes directly instead of calling suffixes() itself? Ah nevermind I

Re: Review Request: qml based kwin shadow

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/ --- (Updated Jan. 7, 2013, 7:01 p.m.) Review request for kde-workspace, kwin,

Re: Review Request: qml based kwin shadow

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/ --- (Updated Jan. 7, 2013, 5:49 p.m.) Review request for kde-workspace, kwin,

Re: Review Request: qml based kwin shadow

> On Jan. 7, 2013, 4:39 p.m., Martin Gräßlin wrote: > > kwin/tabbox/qml/qmldir, line 2 > > > > > > please don't include the IconTabBox in the qmldir. I consider it > > private API :-) I saw IconTabBox is used twic

Re: Review Request: qml based kwin shadow

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/ --- (Updated Jan. 7, 2013, 4:07 p.m.) Review request for kde-workspace, kwin,

Review Request: qml based kwin shadow

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/ --- Review request for kde-workspace, kwin, Plasma, Thomas Lübking, Aaron J. Sei

Re: Re: plasma and new shadow mess

On Mon, Jan 7, 2013 at 5:14 AM, Martin Gräßlin wrote: On Monday 07 January 2013 10:51:11 Aaron J. Seigo wrote: > On Sunday, January 6, 2013 17:40:42 Thomas Lübking wrote: > > 1. it will make kwin link generic-shell what is sematically the > > gnome/unity > > shell approach. In the case of TabBox

Re: plasma and new shadow mess

On Monday, January 7, 2013 15:15:21 Thomas Lübking wrote: > On Montag, 7. Januar 2013 10:51:11 CEST, Aaron J. Seigo wrote: > > it is a library. that does not rely on the desktop (or other) shell. it > > provides shared functionality for applications in kde-workspace, but > > without a guaranteed AP

Re: Review Request: KHTML, imload: Fix wrong version of last line of scaled tile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108246/#review24938 --- Ship it! hmm, I wonder why valgrind didn't pick this up for me

Re: Review Request: Correction of bug 235710 : Plasma Wallpaper Slideshow to periodially recheck contents of image folder

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107821/#review24937 --- Looks good to me, I wonder why you changed the suffix bits the

Re: Review Request: KHTML, imload: Fix wrong version of last line of scaled tile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108246/#review24936 --- Evil: do you think you could provide a test? Seems like if you

Review Request: KHTML, imload: Fix wrong version of last line of scaled tile

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108246/ --- Review request for kdelibs, Martin Tobias Holmedahl Sandsmark and Maks Orlov

Re: Review Request: qml based kwin shadow

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/#review24933 --- kwin/tabbox/qml/ShadowedSvgItem.qml

Re: Review Request: qml based kwin shadow

> On Jan. 7, 2013, 4:39 p.m., Martin Gräßlin wrote: > > kwin/tabbox/qml/qmldir, line 2 > > > > > > please don't include the IconTabBox in the qmldir. I consider it > > private API :-) > > Xuetian Weng wrote: >

Re: Review Request: qml based kwin shadow

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/#review24924 --- I need to think about whether I want to have it in org.kde.kwin

Re: Review Request: qml based kwin shadow

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/#review24920 --- Approach seems fine to me (though I haven't tested it yet). I'm

Re: plasma and new shadow mess

Am 07.01.2013 14:18, schrieb Aaron J. Seigo: On Monday, January 7, 2013 11:14:49 Martin Gräßlin wrote: The shadow system has been designed to work around the problem which occurs if we try to have the shadow in the panel. That is for any window where the shadow should not be part of the window

Re: plasma and new shadow mess

On Monday 07 January 2013, Martin Gräßlin wrote: > > handing over the pixmap id intenrally to the shadow system is exactly what > > we do in plasma. granted, it is outside of kwin and we're doing this with > > an xatom ... but this is precisely how plasma is doing it now: we rely on > > kwin (or an

Re: plasma and new shadow mess

On Montag, 7. Januar 2013 10:51:11 CEST, Aaron J. Seigo wrote: > it is a library. that does not rely on the desktop (or other) shell. it > provides shared functionality for applications in kde-workspace, but without > a guaranteed API for others (ergo no headers). = $ for name in /usr/b

Re: Review Request: use Plasma::Dialog for brightness osd

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108222/#review24913 --- This review has been submitted with commit d2cd9b46c506063fbd1

Re: plasma and new shadow mess

On Montag, 7. Januar 2013 14:18:04 CEST, Aaron J. Seigo wrote: > the shadow+windowframe is not cached somewhere? It's not "shadow+windowframe" but "shadow+window" - doubling memory usage for that window (once more) since the window texture/picture is provided as pixmap by the redirection, you ca

Re: Review Request: set brightness to zero in profile doesn't work

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108230/#review24908 --- Ship it! Ship It! - Lukáš Tinkl On Jan. 6, 2013, 6 p.m., Xu

Re: plasma and new shadow mess

On Monday, January 7, 2013 11:14:49 Martin Gräßlin wrote: > The shadow system has been designed to work around the problem which occurs > if we try to have the shadow in the panel. That is for any window where the > shadow should not be part of the window geometry. It makes sense for the > panel, f

Re: Review Request: Add some new User Agent files for spoofing browser identities in konqueror, rekonq

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108057/#review24898 --- Please run git pull --rebase before pushing any non-merge commi

Re: KDEREVIEW: share like connect and plasmate

On Monday, January 7, 2013 22:58:12 Ben Cooksley wrote: > On Sun, Jan 6, 2013 at 2:10 PM, Aaron J. Seigo wrote: > > On Thursday, January 3, 2013 09:56:47 Ben Cooksley wrote: > >> What about Share-Like-Connect? > > > > i was waiting until i was back in the office with time to work on it again > >

Re: Re: plasma and new shadow mess

On Monday 07 January 2013 11:03:24 Aaron J. Seigo wrote: > a reversion is not going to happen at this point. it is the proper way to do > the shadows (one that relies on window manager functionality which kwin has > thankfully provided for quite some time now; i'm a bit surprised that of > all appl

Re: Re: plasma and new shadow mess

On Monday 07 January 2013 10:51:11 Aaron J. Seigo wrote: > On Sunday, January 6, 2013 17:40:42 Thomas Lübking wrote: > > 1. it will make kwin link generic-shell what is sematically the > > gnome/unity > > shell approach. > > it is a library. that does not rely on the desktop (or other) shell. it >

Re: plasma and new shadow mess

On Sunday, January 6, 2013 20:47:55 Weng Xuetian wrote: > On Sun, Jan 6, 2013 at 10:37 AM, Aaron J. Seigo wrote: > > On Sunday, January 6, 2013 13:35:16 Martin Graesslin wrote: > > > > btw, these changes were made in mid-November of 2012. i'm a little > > surprised > > people are only noticing no

Re: Review Request: use Plasma::Dialog for brightness osd

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108222/#review24870 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 6, 2013, 11:53 p

Re: plasma and new shadow mess

On Sunday, January 6, 2013 17:01:06 Martin Gräßlin wrote: > On Sunday 06 January 2013 16:37:47 Aaron J. Seigo wrote: > > btw, these changes were made in mid-November of 2012. i'm a little > > surprised people are only noticing now. > > maybe because the hard feature freeze was on November 8th and n

Re: plasma and new shadow mess

On Sun, Jan 6, 2013 at 10:37 AM, Aaron J. Seigo wrote: > On Sunday, January 6, 2013 13:35:16 Martin Graesslin wrote: > > btw, these changes were made in mid-November of 2012. i'm a little > surprised > people are only noticing now. > I'm sure this change is not included the first beta, people mi

Re: Review Request: use Plasma::Dialog for brightness osd

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108222/ --- (Updated Jan. 6, 2013, 11:53 p.m.) Review request for kde-workspace, Plasm

Re: Review Request: use Plasma::Dialog for brightness osd

> On Jan. 6, 2013, 3:45 p.m., Kai Uwe Broulik wrote: > > Just applied the patch from Review 107983 and your patch resolves the > > issue. Would you mind if I use that code to fix KMix OSD? > > Xuetian Weng wrote: > Well.. actually I have a review for kmix :P > https://git.reviewboard.kd

Re: Review Request: Add some new User Agent files for spoofing browser identities in konqueror, rekonq

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108057/ --- (Updated Jan. 6, 2013, 10:44 p.m.) Review request for KDE Base Apps. Cha

Re: Review Request: Add some new User Agent files for spoofing browser identities in konqueror, rekonq

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108057/ --- (Updated Jan. 6, 2013, 10:33 p.m.) Review request for KDE Base Apps. Cha

Re: Review Request: use Plasma::Dialog for brightness osd

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108222/ --- (Updated Jan. 6, 2013, 10:25 p.m.) Review request for kde-workspace, Plasm

Re: KDEREVIEW: share like connect and plasmate

On Sun, Jan 6, 2013 at 2:10 PM, Aaron J. Seigo wrote: > On Thursday, January 3, 2013 09:56:47 Ben Cooksley wrote: >> What about Share-Like-Connect? > > i was waiting until i was back in the office with time to work on it again > before requesting the move. :) > > so ... yes, SLC is ready to be mov

Re: plasma and new shadow mess

On Sunday, January 6, 2013 17:40:42 Thomas Lübking wrote: > 1. it will make kwin link generic-shell what is sematically the gnome/unity > shell approach. it is a library. that does not rely on the desktop (or other) shell. it provides shared functionality for applications in kde-workspace, but wit

Re: Moving libkfacebook to extragear

On Thu, Jan 3, 2013 at 11:12 PM, Martin Klapetek wrote: > > Anyways, anything else that should be fixed in the library? > If there are no more comments, I'm going to ask sysadmins to move it tonight (it's been in review since October). Thanks everyone for your reviews and comments! Cheers -- M