> On Jan. 6, 2013, 3:45 p.m., Kai Uwe Broulik wrote:
> > Just applied the patch from Review 107983 and your patch resolves the
> > issue. Would you mind if I use that code to fix KMix OSD?
Well.. actually I have a review for kmix :P
https://git.reviewboard.kde.org/r/108223/
- Xuetian
--
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108230/
---
(Updated Jan. 6, 2013, 6 p.m.)
Review request for kde-workspace and Kai Uw
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108230/
---
Review request for kde-workspace and Kai Uwe Broulik.
Description
---
> On Jan. 4, 2013, 8:13 p.m., John Tapsell wrote:
> > Ship It!
Well, I will push this patch with the assumption that you are busy and Arnav
doesn't have commit access yet.
- Jekyll
---
This is an automatically generated e-mail. To rep
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108222/#review24840
---
Just applied the patch from Review 107983 and your patch resolv
> On Jan. 6, 2013, 3:25 p.m., Kai Uwe Broulik wrote:
> > The code basically is fine, except that you could make the OSD a bit wider
> > (increase width) like the old one.
> >
> > There is a problem on the Plasma side, however. I adapted your code for
> > KMix which also suffers the same proble
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108222/#review24834
---
The code basically is fine, except that you could make the OSD
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108222/
---
(Updated Jan. 6, 2013, 1:36 p.m.)
Review request for kde-workspace, Plasma
> On Jan. 6, 2013, 9:48 a.m., Commit Hook wrote:
> > This review has been submitted with commit
> > e29b9a028ded7c7c8b72c0a3e742644ff986f2e1 by David Faure to branch KDE/4.10.
@Aurélien: Should I remove the workaround from gwenview (gvcore.cpp, line 197)?
- Benni
---
On Sonntag, 6. Januar 2013 16:37:47 CEST, Aaron J. Seigo wrote:
> it is not a break of API since it isn't API at all. hyperbole
> helps nothing, so let's not go down that road.
Unilateral change broke things, so technically it's "I" - whether "API" is a
different matter.
> the change was not d
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107970/#review24847
---
This review has been submitted with commit
d21088dbd106940b515
On Sunday 06 January 2013 16:37:47 Aaron J. Seigo wrote:
> btw, these changes were made in mid-November of 2012. i'm a little surprised
> people are only noticing now.
maybe because the hard feature freeze was on November 8th and nobody expects
that they need to adjust their applications after the
On Sunday, January 6, 2013 13:35:16 Martin Graesslin wrote:
> On Monday 24 December 2012 17:12:22 Weng Xuetian wrote:
> > I think some action need to be taken before the release, some possible
> > solutions.
> > 1. Revert the changes of new plasma air theme, so old shadow can be used.
> > and try t
On Sunday, January 6, 2013 12:22:47 Milian Wolff wrote:
> On Sunday 06 January 2013 01:44:18 Aaron J. Seigo wrote:
> > On Monday, December 24, 2012 17:12:22 Weng Xuetian wrote:
>
>
> > they simply need to be fixed to have the window manager handle that
> > shadows. one way to do this easily is to
On 2013-01-02 22:52, Nicolás Alvarez wrote:
Hello KDE developers!
As you know, a few years ago KDE decided to move to Git, and a lot of
our applications were migrated. However, we're not done yet. SVN is
still alive and kicking, hosting kdeadmin, kdeartwork, kdenetwork,
kdesdk, several websites,
On Monday 24 December 2012 17:12:22 Weng Xuetian wrote:
> I think some action need to be taken before the release, some possible
> solutions.
> 1. Revert the changes of new plasma air theme, so old shadow can be used.
> and try to fix all the things in KDE 4.11
Personal opinion: the change should b
On Sunday 06 January 2013 01:44:18 Aaron J. Seigo wrote:
> On Monday, December 24, 2012 17:12:22 Weng Xuetian wrote:
> they simply need to be fixed to have the window manager handle that shadows.
> one way to do this easily is to use Plasma::Dialog. the OSD in kmix (and
> elsewhere) really shouldn
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108215/#review24796
---
This review has been submitted with commit
e29b9a028ded7c7c8b7
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108222/
---
Review request for kde-workspace, Plasma and Aaron J. Seigo.
Description
-
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108215/
---
Review request for kdelibs, Aurélien Gâteau and David Faure.
Description
-
> On Jan. 5, 2013, 7:49 a.m., Erwan MATHIEU wrote:
> > Well, what am I supposed to do now ? I don't have a write access to the
> > git, so do I have to wait for someone to include the patch ?
You need to first get a "Ship It!" approval of the patch from some maintainer.
Only then should you wo
21 matches
Mail list logo
