Re: KDEREVIEW: share like connect and plasmate

2013-01-05 Thread Aaron J. Seigo
On Thursday, January 3, 2013 09:56:47 Ben Cooksley wrote: > What about Share-Like-Connect? i was waiting until i was back in the office with time to work on it again before requesting the move. :) so ... yes, SLC is ready to be moved out of kdereview. we have it working properly on desktop as

Re: KDEREVIEW: share like connect and plasmate

2013-01-05 Thread Aaron J. Seigo
hi .. feedback was taken into consideration; fixes were made; some issues have been punted to the next release so we can practice "release early, release often, make it better each release" rather than "release when it is perfect, namely never". please move plasmate out of kdereview so we can get

Re: plasma and new shadow mess

2013-01-05 Thread Aaron J. Seigo
On Monday, December 24, 2012 17:12:22 Weng Xuetian wrote: > Hi Plasma world, > As new shadow lands in KDE 4.10 RC1, some unintentional mess is introduced. > > https://bugs.kde.org/show_bug.cgi?id=311502 > https://bugs.kde.org/show_bug.cgi?id=311995 as pointed out by others, these bug reports are

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-05 Thread Thomas Lübking
> On Jan. 5, 2013, 3:13 p.m., Fredrik Höglund wrote: > > Because the XFixesSelectSelectionInput() call specifies that the event > > should be delivered to winId(). KSelectionOwner does not send XFixes > > events; they are generated by the X server. > > > > Thomas Lübking wrote: > Ok, probl

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-05 Thread Thomas Lübking
> On Jan. 5, 2013, 3:13 p.m., Fredrik Höglund wrote: > > Because the XFixesSelectSelectionInput() call specifies that the event > > should be delivered to winId(). KSelectionOwner does not send XFixes > > events; they are generated by the X server. > > > > Thomas Lübking wrote: > Ok, probl

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-05 Thread Fredrik Höglund
> On Jan. 5, 2013, 3:13 p.m., Fredrik Höglund wrote: > > Because the XFixesSelectSelectionInput() call specifies that the event > > should be delivered to winId(). KSelectionOwner does not send XFixes > > events; they are generated by the X server. > > > > Thomas Lübking wrote: > Ok, probl

Re: Finalized proposal for changes to i18n in KF5

2013-01-05 Thread Chusslove Illich
> [: Oswald Buddenhagen :] > of course, it would be even better if you strived for submission to qt- > project, if at all realistic (for now probably an add-on, but definitely > under cla). otherwise you'll see the same effect every other useful lgpl'd > qt framework sees sonner or later: it gets r

Re: Finalized proposal for changes to i18n in KF5

2013-01-05 Thread Kevin Krammer
On Friday, 2013-01-04, Oswald Buddenhagen wrote: > random ramblings: > > i don't like the recommendation for extracted vs. disambiguating > comments (and closed-source authors will typically do the exact opposite > anyway). The opposite thing as in only having comments and not caring at all abou

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-05 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/ --- (Updated Jan. 5, 2013, 5:08 p.m.) Review request for kdelibs, kwin, Plasma

Re: Review Request: Fix KSelectionWatcher / KWindowSystem::compositingChanged signal

2013-01-05 Thread Thomas Lübking
> On Jan. 5, 2013, 3:13 p.m., Fredrik Höglund wrote: > > Because the XFixesSelectSelectionInput() call specifies that the event > > should be delivered to winId(). KSelectionOwner does not send XFixes > > events; they are generated by the X server. > > Ok, problem is: whether by compiz, e17, k

Re: Review Request: Correctly trigger executed signal of KListWidget for both single click and double click.

2013-01-05 Thread Albert Astals Cid
> On Jan. 4, 2013, 1:03 p.m., David Faure wrote: > > This patch looks correct to me. Question for release team: shall I commit > > it to KDE/4.10, or wait until 4.10.0 is out (but that would mean Feb 6), > > given that it's not a release showstopper and we're in RC2 already. > > Allen Winter w

Re: Review Request: Fix KSelectionWatcher / KWindowSystem::compositingChanged signal

2013-01-05 Thread Fredrik Höglund
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/#review24751 --- Because the XFixesSelectSelectionInput() call specifies that th

Re: Review Request: Fix KSelectionWatcher / KWindowSystem::compositingChanged signal

2013-01-05 Thread Thomas Lübking
> On Jan. 4, 2013, 10:20 p.m., Marco Martin wrote: > > +1 for me if it fixes it, but it's not something i'm really confident in to > > say ship it or not :p Right now i'm actually more curious whether i'm currently the only one still encountering bug #179042. - Thomas -

Re: Review Request: Fix KSelectionWatcher / KWindowSystem::compositingChanged signal

2013-01-05 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/ --- (Updated Jan. 5, 2013, 2:38 p.m.) Review request for kdelibs, kwin, Plasma

Review Request: Make KRunner "Enter" work again in 4.10

2013-01-05 Thread Anne-Marie Mahfouf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108197/ --- Review request for kde-workspace and Aaron J. Seigo. Description ---

Re: Review Request: Correction of bug 235710 : Plasma Wallpaper Slideshow to periodially recheck contents of image folder

2013-01-05 Thread Erwan MATHIEU
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107821/#review24723 --- Well, what am I supposed to do now ? I don't have a write acces

Re: Review Request: ksysguard - Add rowspan/colspan support for displays

2013-01-05 Thread John Tapsell
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107970/#review24696 --- Ship it! Ship It! - John Tapsell On Dec. 28, 2012, 3:50 a.m