Re: Review Request: Fix KSelectionWatcher / KWindowSystem::compositingChanged signal

2013-01-04 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/ --- (Updated Jan. 4, 2013, 10:21 p.m.) Review request for kdelibs, kwin, Plasm

Re: Review Request: Fix KSelectionWatcher / KWindowSystem::compositingChanged signal

2013-01-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/#review24713 --- +1 for me if it fixes it, but it's not something i'm really con

Re: Review Request: Fix KSelectionWatcher / KWindowSystem::compositingChanged signal

2013-01-04 Thread Thomas Lübking
> On Jan. 4, 2013, 8:42 a.m., David Faure wrote: > > Oh! A man who understands KSelectionWatcher! I need your help. Could you > > look into KSelectionWatcher in the kdelibs-frameworks branch (with Qt5 > > installed), and port the kselectionwatcher unittest to the new > > kselectionwatcher API

Re: Review Request: Fix KSelectionWatcher / KWindowSystem::compositingChanged signal

2013-01-04 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/ --- (Updated Jan. 4, 2013, 10:12 p.m.) Review request for kdelibs, kwin, Aaron

Re: Review Request: Fix KSelectionWatcher / KWindowSystem::compositingChanged signal

2013-01-04 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/ --- (Updated Jan. 4, 2013, 9:57 p.m.) Review request for kdelibs, kwin, Aaron

Re: Plans for SVN infrastructure shutdown

2013-01-04 Thread Oswald Buddenhagen
On Wed, Jan 02, 2013 at 06:52:32PM -0300, Nicolás Alvarez wrote: > http://community.kde.org/Sysadmin/SVNInfrastructureShutdown > this whole thing ignores that svn is still simply the better option for certain types of content - multimedia data in particular. of course git could be hacked to Not Su

Re: Review Request: Correctly trigger executed signal of KListWidget for both single click and double click.

2013-01-04 Thread Allen Winter
> On Jan. 4, 2013, 1:03 p.m., David Faure wrote: > > This patch looks correct to me. Question for release team: shall I commit > > it to KDE/4.10, or wait until 4.10.0 is out (but that would mean Feb 6), > > given that it's not a release showstopper and we're in RC2 already. David, Technically

Re: Finalized proposal for changes to i18n in KF5

2013-01-04 Thread Oswald Buddenhagen
On Sat, Dec 22, 2012 at 10:44:22AM +0100, Chusslove Illich wrote: > I have written up the headers and Doxygen pages for the Ki18n framework as > it should finally look like, available here: > excellent work. though i was too lazy to make a real api review. ^^ of course, it would be even better if

Re: Review Request: ksysguard - Add rowspan/colspan support for displays

2013-01-04 Thread John Tapsell
Hi, I'm the maintainer. The review gets my approval, but I'm a bit busy. Can someone else apply this please? Thank you very much, John On 4 January 2013 19:44, Arnavion wrote: > Hi, > I don't see this review request e-mail on the mailman archives, so I'm not > sure it ever made it to the

Re: Review Request: ksysguard - Add rowspan/colspan support for displays

2013-01-04 Thread Arnavion
Hi, I don't see this review request e-mail on the mailman archives, so I'm not sure it ever made it to the mailing list. Apologies if it did. I did get an e-mail that the message "is being held until the list moderator can review it for approval", but I didn't receive any follow-up e-mails about th

Re: Kded and DBus

2013-01-04 Thread Cedric Bellegarde
Le jeudi 3 janvier 2013 23:30:28 Weng Xuetian a écrit : > Why appmenu-qt doesn't use static dbus interface (generate from XML)? From > Qt code that can avoid synchronous introspection. You are right, it fixes the issue, will try to get my patch in appmenu-qt for KDE 4.10 release ;) regards, --

Re: Review Request: Correctly trigger executed signal of KListWidget for both single click and double click.

2013-01-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107829/#review24657 --- Ship it! This patch looks correct to me. Question for release

Re: Kded and DBus

2013-01-04 Thread Thiago Macieira
On sexta-feira, 4 de janeiro de 2013 12.30.42, Aurélien Gâteau wrote: > Le Friday 04 January 2013 10:50:02 Cedric Bellegarde a écrit : > > Le jeudi 3 janvier 2013 23:30:28 Weng Xuetian a écrit : > > > Why appmenu-qt doesn't use static dbus interface (generate from XML)? > > > From > > > Qt code th

Re: Kded and DBus

2013-01-04 Thread Aurélien Gâteau
Le Friday 04 January 2013 10:50:02 Cedric Bellegarde a écrit : > Le jeudi 3 janvier 2013 23:30:28 Weng Xuetian a écrit : > > Why appmenu-qt doesn't use static dbus interface (generate from XML)? From > > Qt code that can avoid synchronous introspection. > > No idea, Aurélien ? No strong reason.

Re: Plans for SVN infrastructure shutdown

2013-01-04 Thread David Faure
On Wednesday 02 January 2013 18:52:32 Nicolás Alvarez wrote: > So it's time to plan the shutdown of our SVN infrastructure. We have > written a timeline for the SVN decomissioning, for tasks such as > removing SVN support from secondary services, stop giving SVN access > to new developers, disablin

Re: Kded and DBus

2013-01-04 Thread Weng Xuetian
On Thursday 03 January 2013 19:32:27，Cédric Bellegarde : > Le jeudi 3 janvier 2013 18:09:25 David Edmundson a écrit : > > Always use async calls for everything > > On kded-appmenu part, the blocking code isn't in kded-module but in > appmenu-qt plugin used to export the menu over dbus: > > http://b

Re: Review Request: Fix KSelectionWatcher / KWindowSystem::compositingChanged signal

2013-01-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/#review24639 --- Oh! A man who understands KSelectionWatcher! I need your help.