Re: Review Request: Prevent activation of tabs opened in the background

2013-01-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107048/#review24543 --- This review has been submitted with commit 506874cee8dff84fd13

Re: Review Request: Prevent activation of tabs opened in the background in konqueror

2013-01-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108017/#review24542 --- This review has been submitted with commit 94177c6268898177aed

Re: Any chance to fix Bug 312320 in KDE 4.10?

2013-01-02 Thread Michael Pyne
On Tuesday, January 01, 2013 11:32:38 Peter Klotz wrote: > Hello > > Recently I stumbled over Bug #312320 > (https://bugs.kde.org/show_bug.cgi?id=312320) and created a patch that > according to my tests fixes the problem. > > Is there a chance that this one-line fix can be incorporated into KDE 4

Re: KDEREVIEW: share like connect and plasmate

2013-01-02 Thread Pino Toscano
Alle giovedì 3 gennaio 2013, Giorgos Tsiapaliokas ha scritto: > On 2 January 2013 23:38, Pino Toscano wrote: > > > - BranchDialog sounds like could be replaced with > > > KInputDialog::getText with a custom validator > > > > Still there. > > > > > - CommitDialog, other than being a KDialog, shou

Re: KDEREVIEW: share like connect and plasmate

2013-01-02 Thread Giorgos Tsiapaliokas
On 2 January 2013 23:38, Pino Toscano wrote: > > > - BranchDialog sounds like could be replaced with > > KInputDialog::getText with a custom validator > > Still there. > > > - CommitDialog, other than being a KDialog, should better be use > > layouts instead of placing widgets manually > > Still t

Re: Plans for SVN infrastructure shutdown

2013-01-02 Thread Nicolás Alvarez
2013/1/2, Nicolás Alvarez : > So it's time to plan the shutdown of our SVN infrastructure. We have > written a timeline for the SVN decomissioning, for tasks such as > removing SVN support from secondary services, stop giving SVN access > to new developers, disabling our anonsvn mirrors, and the fi

Plans for SVN infrastructure shutdown

2013-01-02 Thread Nicolás Alvarez
Hello KDE developers! As you know, a few years ago KDE decided to move to Git, and a lot of our applications were migrated. However, we're not done yet. SVN is still alive and kicking, hosting kdeadmin, kdeartwork, kdenetwork, kdesdk, several websites, many extragear and playground applications, a

Re: KDEREVIEW: share like connect and plasmate

2013-01-02 Thread Ben Cooksley
On Thu, Jan 3, 2013 at 10:38 AM, Pino Toscano wrote: > Hi, > > apparently some people consider that all the issues of this review have > been fixed, but really they were not. > > Alle sabato 3 novembre 2012, Pino Toscano ha scritto: >> - PasswordAsker sounds like could be implemented on top of >>

Re: KDEREVIEW: share like connect and plasmate

2013-01-02 Thread Pino Toscano
Hi, apparently some people consider that all the issues of this review have been fixed, but really they were not. Alle sabato 3 novembre 2012, Pino Toscano ha scritto: > - PasswordAsker sounds like could be implemented on top of > KPasswordDialog Still there. > - BranchDialog sounds like could

Re: kdereview: bodega

2013-01-02 Thread Ben Cooksley
On Sun, Nov 4, 2012 at 1:49 AM, Albert Astals Cid wrote: > El Dimecres, 24 d'octubre de 2012, a les 22:07:10, Aaron J. Seigo va escriure: >> hi :) >> >> (x-posting between core-devel and -devel as this is (hopefully) of general >> interest and because we also are supposed to announce new kdereview

Re: Review Request: Make Dr.Konqi remember and show&use the time when the crash happend

2013-01-02 Thread George Kiagiadakis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107775/#review24505 --- Ship it! drkonqi/drkonqidialog.cpp

Re: KDEREVIEW: share like connect and plasmate

2013-01-02 Thread Ben Cooksley
On Thu, Jan 3, 2013 at 7:56 AM, Sebastian Kügler wrote: > On Tuesday, January 01, 2013 15:39:27 Ben Cooksley wrote: >> On Tue, Jan 1, 2013 at 3:31 AM, Antonis Tsiapaliokas > wrote: >> > Hello, >> > >> > We would like to inform you that all the above issues of the plasmate has >> > been fixed. >>

Re: Any chance to fix Bug 312320 in KDE 4.10?

2013-01-02 Thread Mark
On Tue, Jan 1, 2013 at 11:32 AM, Peter Klotz wrote: > Hello > > Recently I stumbled over Bug #312320 > (https://bugs.kde.org/show_bug.cgi?id=312320) and created a patch that > according to my tests fixes the problem. > > Is there a chance that this one-line fix can be incorporated into KDE 4.10? >

Re: KDEREVIEW: share like connect and plasmate

2013-01-02 Thread Sebastian Kügler
On Tuesday, January 01, 2013 15:39:27 Ben Cooksley wrote: > On Tue, Jan 1, 2013 at 3:31 AM, Antonis Tsiapaliokas wrote: > > Hello, > > > > We would like to inform you that all the above issues of the plasmate has > > been fixed. > > Can someone move it to extragear? > > Which project(s) does th

Re: Review Request: Don't add qml elements twice to the scene, reduce warnings

2013-01-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108079/#review24450 --- This review has been submitted with commit 550faf2304a915a2b9b

Re: Review Request: Fix for stale permissions information in properties dialog

2013-01-02 Thread David Faure
> On Dec. 28, 2011, 7:37 a.m., David Faure wrote: > > kio/kio/kdirlister.cpp, line 1078 > > > > > > Yes, but changing permissions is only one case for ending up here. The > > most common case is that KDirWatch (in

Re: Review Request: Fix for stale permissions information in properties dialog

2013-01-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103555/#review24439 --- kio/kio/kdirlister.cpp

Re: Review Request: Don't add qml elements twice to the scene, reduce warnings

2013-01-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108079/#review24434 --- Ship it! Ship It! - Marco Martin On Jan. 2, 2013, 2:20 p.m.

Review Request: Don't add qml elements twice to the scene, reduce warnings

2013-01-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108079/ --- Review request for kdelibs, Plasma and Marco Martin. Description ---

Re: Moving libkfacebook to extragear

2013-01-02 Thread Martin Klapetek
On Sat, Dec 29, 2012 at 12:35 PM, Raymond Wooninck wrote: > Hi Martin, > > On Saturday 29 December 2012 01:25:43 Martin Klapetek wrote: > > > > I finally got around finishing d-pointerizing the whole library, it's all > > in master now. Please review. > > > I made a small adjustment in the CMakeLi

Re: Moving libkfacebook to extragear

2013-01-02 Thread Martin Klapetek
On Sun, Dec 30, 2012 at 6:34 PM, Albert Astals Cid wrote: > > AttendeeInfo misses a d_ptr? Are you deleting the d_ptr? Maybe i'm missing something but for example you > don't seem to delete the d_ptr of PagedListJob, no? > I reworked the dpointers a bit, classes deriving directly from Facebook*

Re: Review Request: Add some new User Agent files for spoofing browser identities in konqueror, rekonq

2013-01-02 Thread Guillaume de Bure
> On Jan. 1, 2013, 5:14 a.m., Dawit Alemayehu wrote: > > Why 3 separate descriptions for Chrome ? Wouldn't the last 2 just like the > > other ones suffice ? Anyways, it would be nice if we could simply remove > > all the old and unsupported user-agent strings. Perhaps we should do that > > for

Any chance to fix Bug 312320 in KDE 4.10?

2013-01-02 Thread Peter Klotz
Hello Recently I stumbled over Bug #312320 (https://bugs.kde.org/show_bug.cgi?id=312320) and created a patch that according to my tests fixes the problem. Is there a chance that this one-line fix can be incorporated into KDE 4.10? Since it is a data corruption issue I would really appreciate

Re: Review Request: Prevent activation of tabs opened in the background

2013-01-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107048/#review24415 --- Ship it! Ship It! - David Faure On Dec. 30, 2012, 1:37 a.m.