Re: Review Request: port Sonnet to QSettings

2012-12-27 Thread Martin Tobias Holmedahl Sandsmark
On Thu, Dec 27, 2012 at 03:13:52PM +0100, Kevin Krammer wrote: > Indeed, it should be doing any form of config IO. It can't know whether any > of > its options need to be persisted, or are supplied hardcoded by the using code > or offered to the user but volatile or offered the users and stored

Re: Finalized proposal for changes to i18n in KF5

2012-12-27 Thread Dominik Haumann
On Saturday, December 22, 2012 10:44:22 AM Chusslove Illich wrote: > I have written up the headers and Doxygen pages for the Ki18n framework as > it should finally look like, available here: > > http://nedohodnik.net/misc/ki18n-kf5-01/html/index.html > http://nedohodnik.net/misc/ki18n-kf5-01/k

Re: Review Request: port Sonnet to QSettings

2012-12-27 Thread Kevin Krammer
On Thursday, 2012-12-27, Martin Tobias Holmedahl Sandsmark wrote: > On Thu, Dec 27, 2012 at 12:18:21PM -, Kevin Krammer wrote: > > Two levels are most likley the most common case because most systems do > > not have any system administrator. Once you have admin customization you > > have at lea

Re: Review Request: port Sonnet to QSettings

2012-12-27 Thread Martin Tobias Holmedahl Sandsmark
On Thu, Dec 27, 2012 at 12:18:21PM -, Kevin Krammer wrote: > Two levels are most likley the most common case because most systems do not > have any system administrator. Once you have admin customization you have > at least three (package, admin, user). I don't have any evidence for nor > again

Re: Review Request: port Sonnet to QSettings

2012-12-27 Thread Kevin Krammer
> On Dec. 27, 2012, 10:33 a.m., Kevin Krammer wrote: > > I am a bit puzzled by the usage of QSettings for file I/O. > > > > My, rather limited, understanding of QSettings in Qt5 context is that is > > mostly the same as in Qt4 and Qt4's version is AFAIK neither capable of > > doing hierachical

Re: Finalized proposal for changes to i18n in KF5

2012-12-27 Thread Chusslove Illich
> Nice writeup, very complete! On IRC Albert noted that I didn't quite cover tr2i18n use for .ui files, which also holds for .kcfg and .rc. For these I should document how to set the catalog and markup-awareness. For .ui this can be non-invasive (optional arguments to CMake *_ADD_UI_FILES macro) b

Re: Review Request: port Sonnet to QSettings

2012-12-27 Thread David Faure
> On Dec. 27, 2012, 10:33 a.m., Kevin Krammer wrote: > > I am a bit puzzled by the usage of QSettings for file I/O. > > > > My, rather limited, understanding of QSettings in Qt5 context is that is > > mostly the same as in Qt4 and Qt4's version is AFAIK neither capable of > > doing hierachical

Re: Review Request: port Sonnet to QSettings

2012-12-27 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107791/#review24025 --- I am a bit puzzled by the usage of QSettings for file I/O. My,

Re: Review Request: port Sonnet to QSettings

2012-12-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107791/#review24022 --- kdeui/sonnet/configdialog.h

Re: Review Request: port sonnet away from i18nc

2012-12-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107412/#review24021 --- Ship it! Ship It! - David Faure On Dec. 26, 2012, 11:02 p.m