Re: Review Request: port sonnet away from i18nc

2012-12-24 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107412/ --- (Updated Dec. 24, 2012, 10:03 p.m.) Review request for kdelibs and David F

Re: Finalized proposal for changes to i18n in KF5

2012-12-24 Thread Chusslove Illich
> [: Allen Winter :] > Plus, you documentation is really nice and easy to follow. Thank you. Given the general motivation behind Frameworks, my main intention was for documentation to be reasonably self-contained: without assuming that additional articles on Techbase must be read, that the code wi

Re: Finalized proposal for changes to i18n in KF5

2012-12-24 Thread Allen Winter
On Saturday 22 December 2012 10:44:22 AM Chusslove Illich wrote: > I have written up the headers and Doxygen pages for the Ki18n framework as > it should finally look like, available here: > > http://nedohodnik.net/misc/ki18n-kf5-01/html/index.html > http://nedohodnik.net/misc/ki18n-kf5-01/klo

Re: Review Request: Make sure ksmserver ignores excluded apps when saving session

2012-12-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107276/#review23955 --- This review has been submitted with commit c7fc5ed96143d91e167

Re: Review Request: Make sure ksmserver ignores excluded apps when saving session

2012-12-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107276/#review23954 --- This review has been submitted with commit 7a99d5708f9ba2bedbc

Re: Review Request: Do not wait for remaining Dr.Konqi instances without timeout when ending the KDE session

2012-12-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107657/#review23951 --- This review has been submitted with commit 23b5b55c04b3b8a5d75

Re: Review Request: Do not wait for remaining Dr.Konqi instances without timeout when ending the KDE session

2012-12-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107657/#review23950 --- This review has been submitted with commit feac020d92bdb199341

Re: Review Request: Do not wait for remaining Dr.Konqi instances without timeout when ending the KDE session

2012-12-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107657/#review23949 --- This review has been submitted with commit 011e5acd647cc5a30d2

Re: Review Request: Prevent activation of tabs opened in the background

2012-12-24 Thread David Faure
> On Nov. 22, 2012, 11:04 a.m., David Faure wrote: > > Well, if setFocus() shouldn't trigger the PartManager, then the fix would > > be in PartManager itself. Otherwise the part manager and konqueror will > > have a different vision of the currently active part. > > > > In order to avoid break

Re: Review Request: port sonnet away from i18nc

2012-12-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107412/#review23940 --- I think you posted the patch r2 again, in fact, I see no differ

Re: Review Request: port sonnet away from i18nc

2012-12-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107412/#review23939 --- staging/sonnet/src/core/loader.cpp