Re: Review Request: Correction of bug 235710 : Plasma Wallpaper Slideshow to periodially recheck contents of image folder

2012-12-21 Thread Erwan MATHIEU
> On Dec. 21, 2012, 12:28 a.m., Kai Uwe Broulik wrote: > > plasma/generic/wallpapers/image/image.cpp, lines 752-756 > > > > > > Did I overlook something or where is the non-randomized wallpaper > > change now hap

Re: Review Request: Correction of bug 235710 : Plasma Wallpaper Slideshow to periodially recheck contents of image folder

2012-12-21 Thread Kai Uwe Broulik
> On Dec. 21, 2012, 12:28 a.m., Kai Uwe Broulik wrote: > > plasma/generic/wallpapers/image/image.cpp, lines 752-756 > > > > > > Did I overlook something or where is the non-randomized wallpaper > > change now hap

Re: Review Request: Correction of bug 235710 : Plasma Wallpaper Slideshow to periodially recheck contents of image folder

2012-12-21 Thread Erwan MATHIEU
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107821/ --- (Updated Dec. 21, 2012, 5:11 p.m.) Review request for kde-workspace. Cha

Re: Review Request: Correction of bug 235710 : Plasma Wallpaper Slideshow to periodially recheck contents of image folder

2012-12-21 Thread Erwan MATHIEU
> On Dec. 21, 2012, 12:28 a.m., Kai Uwe Broulik wrote: > > plasma/generic/wallpapers/image/image.cpp, line 589 > > > > > > I give you an “i” ;) > > Erwan MATHIEU wrote: > What do you mean ? > > Jeremy Paul W

Re: Review Request: Correctly trigger executed signal of KListWidget for both single click and double click.

2012-12-21 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107829/ --- (Updated Dec. 21, 2012, 4:35 p.m.) Review request for kdelibs. Changes -

Re: Review Request: Correctly trigger executed signal of KListWidget for both single click and double click.

2012-12-21 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107829/ --- (Updated Dec. 21, 2012, 4:19 p.m.) Review request for kdelibs. Changes -

Re: Review of kdev-python for move to extragear

2012-12-21 Thread Sven Brauch
Hello, the two-week review period for this project (kdev-python) has passed. The only complaint raised was related to the python fork in the repository. Was the necessarity of this sufficiently explained by my follow-up email, or does anyone think this issue needs further discussion? Best regards

Review Request: KMessageWidget: Fix infinite recursion triggered from resizeEvent()

2012-12-21 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107835/ --- Review request for kdelibs. Description --- When KMessageWidget width

Re: Review Request: Fix icon generation and installation on OS X

2012-12-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107752/#review23806 --- This review has been submitted with commit 0695c3fc8eb9e288ede

Re: Review Request: Fix icon generation and installation on OS X

2012-12-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107752/#review23805 --- This review has been submitted with commit 52ee764212613012f1f

Re: Review Request: Correction of bug 235710 : Plasma Wallpaper Slideshow to periodially recheck contents of image folder

2012-12-21 Thread Jeremy Paul Whiting
> On Dec. 21, 2012, 12:28 a.m., Kai Uwe Broulik wrote: > > plasma/generic/wallpapers/image/image.cpp, line 589 > > > > > > I give you an “i” ;) > > Erwan MATHIEU wrote: > What do you mean ? He means you prob

Re: Review Request: Remove usage of KIO::SlaveConfig from Dolphin

2012-12-21 Thread Dawit Alemayehu
> On Nov. 22, 2012, 7:45 p.m., David Faure wrote: > > This probably needs a #ifdef on the kdelibs version number, then, since > > apparently kde-baseapps master only requires kdelibs-4.8... > > > > It says find_package(KDE4 4.8.0 REQUIRED). Not sure why not 4.9 at least, > > but that wouldn't

Re: Review Request: Fix icon generation and installation on OS X

2012-12-21 Thread Laszlo Papp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107752/#review23795 --- Ship it! If it does not break on other systems, like Linux, Wi

Review Request: Correctly trigger executed signal of KListWidget for both single click and double click.

2012-12-21 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107829/ --- Review request for kdelibs. Description --- When clicking on a item i

Re: Review Request: Correction of bug 235710 : Plasma Wallpaper Slideshow to periodially recheck contents of image folder

2012-12-21 Thread Erwan MATHIEU
> On Dec. 21, 2012, 12:28 a.m., Kai Uwe Broulik wrote: > > plasma/generic/wallpapers/image/image.cpp, line 589 > > > > > > I give you an “i” ;) What do you mean ? > On Dec. 21, 2012, 12:28 a.m., Kai Uwe Broulik

Review Request: Fix pager window dragging and icon

2012-12-21 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107828/ --- Review request for kde-workspace, Plasma and Aaron J. Seigo. Description -

Re: Review Request: Fix icon generation and installation on OS X

2012-12-21 Thread Yue Liu
> On Dec. 20, 2012, 6:58 p.m., Laszlo Papp wrote: > > Great, thank you for your care! One suggestion to this, and I think then it > > is fine from that point of view: you could write a foreach on top of the > > "copy_icons" macro, and avoid the same function name in each line. > > Yue Liu wrot

Re: Review Request: Correction of bug 235710 : Plasma Wallpaper Slideshow to periodially recheck contents of image folder

2012-12-21 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107821/#review23787 --- plasma/generic/wallpapers/image/image.cpp

Re: Review Request: Fix icon generation and installation on OS X

2012-12-21 Thread Yue Liu
> On Dec. 20, 2012, 6:58 p.m., Laszlo Papp wrote: > > Great, thank you for your care! One suggestion to this, and I think then it > > is fine from that point of view: you could write a foreach on top of the > > "copy_icons" macro, and avoid the same function name in each line. > > Yue Liu wrot

Review Request: Correction of bug 235710 : Plasma Wallpaper Slideshow to periodially recheck contents of image folder

2012-12-21 Thread Erwan MATHIEU
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107821/ --- Review request for kde-workspace. Description --- Patch which correct

Re: Review Request: Fix icon generation and installation on OS X

2012-12-21 Thread Yue Liu
> On Dec. 20, 2012, 6:58 p.m., Laszlo Papp wrote: > > Great, thank you for your care! One suggestion to this, and I think then it > > is fine from that point of view: you could write a foreach on top of the > > "copy_icons" macro, and avoid the same function name in each line. that doesn't sav

Re: Review Request: Fix icon generation and installation on OS X

2012-12-21 Thread Yue Liu
> On Dec. 16, 2012, 1:47 p.m., Laszlo Papp wrote: > > cmake/modules/KDE4Macros.cmake, line 1293 > > > > > > Wouldn't it be nicer to write a loop for this with the icon resolutions? > > Yue Liu wrote: > osx ico

Re: Review Request: Fix icon generation and installation on OS X

2012-12-21 Thread Laszlo Papp
> On Dec. 20, 2012, 6:58 p.m., Laszlo Papp wrote: > > Great, thank you for your care! One suggestion to this, and I think then it > > is fine from that point of view: you could write a foreach on top of the > > "copy_icons" macro, and avoid the same function name in each line. > > Yue Liu wrot