Re: Review Request: Fix icon generation and installation on OS X

2012-12-20 Thread Laszlo Papp
> On Dec. 20, 2012, 6:58 p.m., Laszlo Papp wrote: > > Great, thank you for your care! One suggestion to this, and I think then it > > is fine from that point of view: you could write a foreach on top of the > > "copy_icons" macro, and avoid the same function name in each line. > > Yue Liu wrot

Re: Review Request: Fix icon generation and installation on OS X

2012-12-20 Thread Laszlo Papp
> On Dec. 20, 2012, 6:58 p.m., Laszlo Papp wrote: > > Great, thank you for your care! One suggestion to this, and I think then it > > is fine from that point of view: you could write a foreach on top of the > > "copy_icons" macro, and avoid the same function name in each line. > > Yue Liu wrot

Re: Review Request: Fix icon generation and installation on OS X

2012-12-20 Thread Laszlo Papp
> On Dec. 20, 2012, 6:58 p.m., Laszlo Papp wrote: > > Great, thank you for your care! One suggestion to this, and I think then it > > is fine from that point of view: you could write a foreach on top of the > > "copy_icons" macro, and avoid the same function name in each line. > > Yue Liu wrot

Re: Review Request: Fix icon generation and installation on OS X

2012-12-20 Thread Laszlo Papp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107752/#review23767 --- Great, thank you for your care! One suggestion to this, and I t

Re: Review Request: Fix icon generation and installation on OS X

2012-12-20 Thread Yue Liu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107752/ --- (Updated Dec. 20, 2012, 6:10 p.m.) Review request for kdelibs. Changes -