Re: rekonq 2 merged in rekonq main repository

2012-12-19 Thread Dawit A
Well if we simply ignore the "private session" cookies in the cookie management dialog, then the problem becomes much easier. One will only have to add the concept of "private" cookies to the cookiejar and make sure cookies marked as such are always treated as session cookies and only available to

Re: Review Request: Plasma QML Components: fix internal anchoring in ToolButton

2012-12-19 Thread Sebastian Gottfried
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107813/ --- (Updated Dec. 19, 2012, 2:35 p.m.) Review request for KDE Runtime and Marc

Re: Review Request: Plasma QML Components: fix internal anchoring in ToolButton

2012-12-19 Thread Sebastian Gottfried
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107813/ --- (Updated Dec. 19, 2012, 1:46 p.m.) Review request for KDE Runtime and Marc

Re: rekonq 2 merged in rekonq main repository

2012-12-19 Thread andrea diamantini
I though that way, too. My problem was just that implementing my ideas about did not lead to a "working" solution. And I really cannot release another time with a private "non-really-private" incognito mode. About your difficulties, I can just say that, IMHO, "private session" cookies have to be co

Re: rekonq 2 merged in rekonq main repository

2012-12-19 Thread andrea diamantini
The issue looks very similar, yes. 2012/12/19 Sebastian Kügler > On Tuesday, December 18, 2012 23:14:01 Dawit A wrote: > > Well that is not entirely correct. We can definitely implement support > for > > private mode in the cookiejar itself easily. There are a couple of > > approaches we can ta

Re: Review Request: Fix icon generation and installation on OS X

2012-12-19 Thread Kurt Hindenburg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107752/#review23730 --- Thanks for this - I was just trying to figure out why the konso

Re: Review Request: Plasma QML Components: fix internal anchoring in ToolButton

2012-12-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107813/#review23729 --- This review has been submitted with commit 1180e4ae4492a9ec155

Re: Review Request: Plasma QML Components: fix internal anchoring in ToolButton

2012-12-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107813/#review23728 --- This review has been submitted with commit e7c32d888a4cc62bfc0

Re: Review Request: Plasma QML Components: fix internal anchoring in ToolButton

2012-12-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107813/#review23727 --- This review has been submitted with commit 8b9b7abf16d8f0a3a08

Re: Review Request: Plasma QML Components: fix internal anchoring in ToolButton

2012-12-19 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107813/#review23723 --- Ship it! I like this, it cleans up some "why is this that way

Review Request: Plasma QML Components: fix internal anchoring in ToolButton

2012-12-19 Thread Sebastian Gottfried
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107813/ --- Review request for KDE Runtime and Marco Martin. Description --- Ther

Re: rekonq 2 merged in rekonq main repository

2012-12-19 Thread Sebastian Kügler
On Tuesday, December 18, 2012 23:14:01 Dawit A wrote: > Well that is not entirely correct. We can definitely implement support for > private mode in the cookiejar itself easily. There are a couple of > approaches we can take. The difficult part has always been how to handle > the "private session"