Re: Review Request: Fix mixed sentences in sftp error message

2012-12-13 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107700/#review23446 --- Ship it! Looks good to me. - Dawit Alemayehu On Dec. 13, 20

Re: Moving Trojitá to extragear

2012-12-13 Thread Chusslove Illich
>> [: David Faure :] >> If it handles this correctly (so that tr() works at runtime), this is >> good news then, it sounds like we can drop the weird >> QCoreApp::translate("", "text") in KF5. > > [: Jan Kundrát :] > I can confirm that lconvert from Qt 4.8.3 is enough [...] I'm just wondering if w

Review Request: Fix opening links in translation tab of KAboutApplicationDialog

2012-12-13 Thread Lasse Liehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107706/ --- Review request for kdelibs. Description --- See the summary. Diffs

Re: Moving Trojitá to extragear

2012-12-13 Thread Jan Kundrát
On Thursday, 13 December 2012 18:52:51 CEST, David Faure wrote: If it handles this correctly (so that tr() works at runtime), this is good news then, it sounds like we can drop the weird QCoreApp::translate("", "text") in KF5. I can confirm that lconvert from Qt 4.8.3 is enough to preserve the

Re: Moving Trojitá to extragear

2012-12-13 Thread David Faure
On Monday 10 December 2012 11:16:40 Chusslove Illich wrote: > For semantic differences between Qt and Gettext, it is upon lconvert to > define an unambiguous two-way mapping. Do you know how it handles contexts (usually class names)? If it handles this correctly (so that tr() works at runtime), t

Re: Review Request: Keep clickmessage text visible when empty and focused

2012-12-13 Thread Aurélien Gâteau
> On Dec. 12, 2012, 6:43 p.m., Laszlo Papp wrote: > > It did not get a ship it back then for the plasma components, but I would > > not like to block the rediscussion, just saying what happened earlier. :-) > > > > https://git.reviewboard.kde.org/r/104895/ > > David Edmundson wrote: > One

Re: Review Request: Fix mixed sentences in sftp error message

2012-12-13 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107700/ --- (Updated Dec. 13, 2012, 1:57 p.m.) Review request for KDE Runtime and Dawi

Re: Review Request: Fix mixed sentences in sftp error message

2012-12-13 Thread Daniel Nicoletti
2012/12/13 Aurélien Gâteau > Tested with Gwenview, which failed to log on sftp://localhost (now I need > to figure out why :) ) have you done ssh on the cmd line prior to using the sftp slave? if so there is a key bug on some lib that doesn't read the new keys... I don't recall the bug number on

Re: Review Request: Show removable media in Dolphin's "Copy To" and "Move To" context menus

2012-12-13 Thread Rajeesh K Nambiar
> On Dec. 5, 2012, 11:38 a.m., David Faure wrote: > > I like the idea, but I don't understand the screenshot. Is that "before" or > > "after"? Why does it say "without devices"? It shows Home and Root twice, > > could that be fixed? I used kFilePlacesModel as suggested by Christoph Feck, but i

Review Request: Fix mixed sentences in sftp error message

2012-12-13 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107700/ --- Review request for KDE Runtime and Dawit Alemayehu. Description --- W