Re: Review Request: Prevent crash when showing Konqueror config dialog on systems with corrupt system config cache

2012-12-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107642/#review23251 --- This review has been submitted with commit 3ddc66ab8d76afcb2a9

Re: Review Request: Copy files instead of moving if parent dir is not writable

2012-12-09 Thread Thomas Lübking
> On March 30, 2012, 8:18 p.m., Thomas Lübking wrote: > > service/jobs/nepomuk/Move.cpp, line 352 > > > > > > "!QUrl::isLocalFile()"? > > Lamarque Vieira Souza wrote: > isLocalFile() was introduced in Qt 4.8.0

Re: Nepomuk Metadata Extractor moved to KDE Review

2012-12-09 Thread Jörg Ehrichs
Hi, > On Tuesday, December 04, 2012 14:17:33 Jörg Ehrichs wrote: >> > This sounds a bit like you're ignoring most of the feedback you got. >> >> No didn't ignore any reviews. I've changed/implemented each and every >> suggestion/review I've got. > > Sorry, I think I came over a bit disrespectful f

Re: Review Request: [PATCH] Additional address formats for KDE locales

2012-12-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105564/#review23244 --- This review has been submitted with commit e93543d8bd6bab89f04

Re: Review Request: Copy files instead of moving if parent dir is not writable

2012-12-09 Thread Albert Astals Cid
> On March 30, 2012, 8:18 p.m., Thomas Lübking wrote: > > service/jobs/nepomuk/Move.cpp, line 352 > > > > > > "!QUrl::isLocalFile()"? > > Lamarque Vieira Souza wrote: > isLocalFile() was introduced in Qt 4.8.0

Re: Review Request: [PATCH] Make kio_info produce valid HTML

2012-12-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105590/#review23228 --- This review has been submitted with commit 0817c385be22fc99091

Re: Review Request: [PATCH] Make kio_info produce valid HTML

2012-12-09 Thread Albert Astals Cid
> On July 26, 2012, 12:53 p.m., Paul Walger wrote: > > Ship It! > > Albert Astals Cid wrote: > Was this ever commited? > > Paul Walger wrote: > I am quite unfamiliar with whole process how to send in a patch. > How can i commit this? Once you get the "Ship it!" you are supposed to

Re: Review Request: [PATCH] Make kio_info produce valid HTML

2012-12-09 Thread Paul Walger
> On July 26, 2012, 12:53 p.m., Paul Walger wrote: > > Ship It! > > Albert Astals Cid wrote: > Was this ever commited? I am quite unfamiliar with whole process how to send in a patch. How can i commit this? - Paul --- This is an au

Re: Review Request: [PATCH] Make kio_info produce valid HTML

2012-12-09 Thread Albert Astals Cid
> On July 26, 2012, 12:53 p.m., Paul Walger wrote: > > Ship It! Was this ever commited? - Albert --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105590/#review16482 --

Re: Review Request: Prevent crash when showing Konqueror config dialog on systems with corrupt system config cache

2012-12-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107642/#review23210 --- Ship it! Ship It! - David Faure On Dec. 9, 2012, 4:44 p.m.,

Review Request: Prevent crash when showing Konqueror config dialog on systems with corrupt system config cache

2012-12-09 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107642/ --- Review request for KDE Base Apps and David Faure. Description --- Jus

Re: Review Request: QML Plasma Components - fix for bug in ScrollBar anchoring

2012-12-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107622/#review23192 --- Ship it! good catch, sorry for the late reply - Marco Martin

Re: Nepomuk Metadata Extractor moved to KDE Review

2012-12-09 Thread Sebastian Kügler
Hi Jörg, On Tuesday, December 04, 2012 14:17:33 Jörg Ehrichs wrote: > > This sounds a bit like you're ignoring most of the feedback you got. > > No didn't ignore any reviews. I've changed/implemented each and every > suggestion/review I've got. Sorry, I think I came over a bit disrespectful for

Re: Review Request: Make sure ksmserver ignores excluded apps when saving session

2012-12-09 Thread Jekyll Wu
> On Nov. 11, 2012, 11:13 a.m., Aaron J. Seigo wrote: > > ksmserver/server.cpp, line 939 > > > > > > why not check for both program and filename? that should then catch 1, > > 2 and 4, no? > > > > excludeA

Re: Review Request: Make sure ksmserver ignores excluded apps when saving session

2012-12-09 Thread Jekyll Wu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107276/ --- (Updated Dec. 9, 2012, 7:50 a.m.) Review request for kdelibs, Plasma and L