Re: Review Request: Fix KIO listDir entries batching

2012-11-29 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107520/ --- (Updated Nov. 29, 2012, 11:10 p.m.) Review request for kdelibs and David F

Re: Review Request: Load Solid devices in KFilePlacesModel asynchronously

2012-11-29 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107513/#review22795 --- Ehm, this just seems odd to me. Because kdelibs is frozen you a

Re: Review Request: Fix KIO listDir entries batching

2012-11-29 Thread Mark Gaiser
> On Nov. 29, 2012, 7:48 p.m., Pino Toscano wrote: > > kioslave/file/file_unix.cpp, line 363 > > > > > > This would be QFile::decodeName, not QString::fromLocal8Bit... but you > > don't need it either, since you ha

Re: Review Request: Load Solid devices in KFilePlacesModel asynchronously

2012-11-29 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107513/ --- (Updated Nov. 29, 2012, 2:55 p.m.) Review request for kdelibs, Lukáš Tinkl

Review Request: Load Solid devices in KFilePlacesModel asynchronously

2012-11-29 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107513/ --- Review request for kdelibs and David Faure. Description --- With KDE

Re: Review Request: Fix KIO listDir entries batching

2012-11-29 Thread Pino Toscano
> On Nov. 29, 2012, 7:48 p.m., Pino Toscano wrote: > > kioslave/file/file_unix.cpp, line 363 > > > > > > This would be QFile::decodeName, not QString::fromLocal8Bit... but you > > don't need it either, since you ha

Re: Review Request: Fix KIO listDir entries batching

2012-11-29 Thread Mark Gaiser
> On Nov. 29, 2012, 7:48 p.m., Pino Toscano wrote: > > kioslave/file/file_unix.cpp, line 363 > > > > > > This would be QFile::decodeName, not QString::fromLocal8Bit... but you > > don't need it either, since you ha

Re: Review Request: Fix KIO listDir entries batching

2012-11-29 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107520/#review22785 --- kioslave/file/file_unix.cpp

Re: KIO::ListJob::entries emits twice for folders with 100+ entries. Why?

2012-11-29 Thread Mark
On Thu, Nov 29, 2012 at 4:45 PM, Mark wrote: > On Thu, Nov 29, 2012 at 4:34 PM, David Faure wrote: >> On Thursday 29 November 2012 16:04:21 Mark wrote: >>> On Thu, Nov 29, 2012 at 2:23 PM, David Faure wrote: >>> > On Friday 23 November 2012 22:23:24 Mark wrote: >>> >> Here it is: http://paste.kd

Review Request: Fix KIO listDir entries batching

2012-11-29 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107520/ --- Review request for kdelibs and David Faure. Description --- listDir i

Reminder: FOSDEM CrossDesktop DevRoom 2013 - Call for Talks

2012-11-29 Thread Pau Garcia i Quiles
Hello, The Call for Talks for the CrossDesktop DevRoom at FOSDEM 2013 is officially open and will close in two weeks (Dec 14th). Please submit your talk proposals ASAP! In case you are out of ideas, Jure Repinc elaborated a list of interesting topics: * KDE Framework/Workspaces/Software 5 and Qt

Re: KIO::ListJob::entries emits twice for folders with 100+ entries. Why?

2012-11-29 Thread Mark
On Thu, Nov 29, 2012 at 4:34 PM, David Faure wrote: > On Thursday 29 November 2012 16:04:21 Mark wrote: >> On Thu, Nov 29, 2012 at 2:23 PM, David Faure wrote: >> > On Friday 23 November 2012 22:23:24 Mark wrote: >> >> Here it is: http://paste.kde.org/613670/ >> > >> > This calls gettimeofday for

Re: KIO::ListJob::entries emits twice for folders with 100+ entries. Why?

2012-11-29 Thread David Faure
On Thursday 29 November 2012 16:04:21 Mark wrote: > On Thu, Nov 29, 2012 at 2:23 PM, David Faure wrote: > > On Friday 23 November 2012 22:23:24 Mark wrote: > >> Here it is: http://paste.kde.org/613670/ > > > > This calls gettimeofday for every entry, even when this value isn't > > needed. > > Can

Re: KIO::ListJob::entries emits twice for folders with 100+ entries. Why?

2012-11-29 Thread Mark
On Thu, Nov 29, 2012 at 2:23 PM, David Faure wrote: > On Friday 23 November 2012 22:23:24 Mark wrote: >> Here it is: http://paste.kde.org/613670/ > > This calls gettimeofday for every entry, even when this value isn't needed. > Can you move this to the locations where it's actually needed, for per

Re: KIO::ListJob::entries emits twice for folders with 100+ entries. Why?

2012-11-29 Thread David Faure
On Friday 23 November 2012 22:23:24 Mark wrote: > Here it is: http://paste.kde.org/613670/ This calls gettimeofday for every entry, even when this value isn't needed. Can you move this to the locations where it's actually needed, for performance reasons? Even better would be to port this to QDa

Re: Review Request: Jar archives also uses the zip protocol.

2012-11-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101455/#review22747 --- This review has been submitted with commit 4f296cfbced2c4ad54b