Re: KIO::ListJob::entries emits twice for folders with 100+ entries. Why?

2012-11-23 Thread Mark
On Fri, Nov 23, 2012 at 5:59 PM, Mark wrote: > On Fri, Nov 23, 2012 at 5:33 PM, David Faure wrote: >> On Friday 23 November 2012 16:26:59 Mark wrote: >>> 1. SlaveBase::listEntry is really using wrong names and types to get >>> something done. For instance, d->totalSize is a KIO::filesize_t type >

Re: Review Request: Remove usage of KIO::SlaveConfig from Dolphin

2012-11-23 Thread Dawit Alemayehu
> On Nov. 22, 2012, 7:45 p.m., David Faure wrote: > > This probably needs a #ifdef on the kdelibs version number, then, since > > apparently kde-baseapps master only requires kdelibs-4.8... > > > > It says find_package(KDE4 4.8.0 REQUIRED). Not sure why not 4.9 at least, > > but that wouldn't

Re: KIO::ListJob::entries emits twice for folders with 100+ entries. Why?

2012-11-23 Thread Mark
On Fri, Nov 23, 2012 at 5:33 PM, David Faure wrote: > On Friday 23 November 2012 16:26:59 Mark wrote: >> 1. SlaveBase::listEntry is really using wrong names and types to get >> something done. For instance, d->totalSize is a KIO::filesize_t type >> and is being used to measure a list count. It's i

Re: KIO::ListJob::entries emits twice for folders with 100+ entries. Why?

2012-11-23 Thread David Faure
On Friday 23 November 2012 16:26:59 Mark wrote: > 1. SlaveBase::listEntry is really using wrong names and types to get > something done. For instance, d->totalSize is a KIO::filesize_t type > and is being used to measure a list count. It's in reality no > "filesize" at all! That just adds to the co

Re: KIO::ListJob::entries emits twice for folders with 100+ entries. Why?

2012-11-23 Thread Mark
On Fri, Nov 23, 2012 at 10:42 AM, David Faure wrote: > On Friday 23 November 2012 00:49:11 Mark wrote: >> I'm hitting a bit of an issue here in debugging SlaveBase::listEntry.. >> KIO is not running in the same thread as i'm running which makes >> debugging tricky. > > Err, KIO doesn't really supp

Re: Review Request: Use static KNS3::DownloadDialog in PlasmoidPackage

2012-11-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107413/#review22421 --- This review has been submitted with commit 4769d2f180add18190f

Re: Review Request: Use static KNS3::DownloadDialog in PlasmoidPackage

2012-11-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107413/#review22420 --- This review has been submitted with commit 0c0fa84c01d245e9acd

Re: Review Request: Use static KNS3::DownloadDialog in PlasmoidPackage

2012-11-23 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107413/#review22419 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 23, 2012, 11:12

Re: KIO::ListJob::entries emits twice for folders with 100+ entries. Why?

2012-11-23 Thread David Faure
On Friday 23 November 2012 00:49:11 Mark wrote: > I'm hitting a bit of an issue here in debugging SlaveBase::listEntry.. > KIO is not running in the same thread as i'm running which makes > debugging tricky. Err, KIO doesn't really support threads. You have to run KIO in the main thread. Well if

Re: Review Request: Remove usage of KIO::SlaveConfig from Dolphin

2012-11-23 Thread Albert Astals Cid
> On Nov. 22, 2012, 7:45 p.m., David Faure wrote: > > This probably needs a #ifdef on the kdelibs version number, then, since > > apparently kde-baseapps master only requires kdelibs-4.8... > > > > It says find_package(KDE4 4.8.0 REQUIRED). Not sure why not 4.9 at least, > > but that wouldn't