Re: Review Request: Use static KNS3::DownloadDialog in PlasmoidPackage

2012-11-21 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107413/ --- (Updated Nov. 22, 2012, 12:25 a.m.) Review request for kdelibs. Descript

Review Request: Use static KNS3::DownloadDialog in PlasmoidPackage

2012-11-21 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107413/ --- Review request for kdelibs. Description --- Switch from QWeakPointer

Re: Moving Trojitá to extragear

2012-11-21 Thread Albert Astals Cid
El Dimecres, 21 de novembre de 2012, a les 21:52:43, Thomas Lübking va escriure: > On Mittwoch, 21. November 2012 20:53:14 CEST, Albert Astals Cid wrote: > > I.e. if you don't use "i18n()" or "tr() + kdecore (and actually > > this one has a missing feature because someone in Qt decided to > > make

Re: Moving Trojitá to extragear

2012-11-21 Thread Yuri Chornoivan
написане Wed, 21 Nov 2012 20:43:13 +0200, Jan Kundrát : 1) User's docs. Is it a hard requirement to have a documentation basically describing how the menus look like? No. But it's a good practice [0]. Nobody needs to know how the menu looks like (if you do not mind about accessibility) but

Re: Review Request: port sonnet away from i18nc

2012-11-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107412/#review22346 --- staging/sonnet/src/core/loader.cpp

Re: Moving Trojitá to extragear

2012-11-21 Thread Thomas Lübking
On Mittwoch, 21. November 2012 20:53:14 CEST, Albert Astals Cid wrote: > I.e. if you don't use "i18n()" or "tr() + kdecore (and actually > this one has a missing feature because someone in Qt decided to > make a method not virtual)" you can't get our .po/.mo system > work-flow to work. > > Not

Re: Moving Trojitá to extragear

2012-11-21 Thread Albert Astals Cid
El Dimecres, 21 de novembre de 2012, a les 19:43:13, Jan Kundrát va escriure: > Hi, > thanks for your encouragement. Trojitá, a fast IMAP e-mail client (homepage > [1], more in-depth look [2], the KDE project page [3]) has spent the last > week or so under playground and was just moved to kdereview

Re: Review Request: port sonnet away from i18nc

2012-11-21 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107412/ --- (Updated Nov. 21, 2012, 7:47 p.m.) Review request for kdelibs and David Fa

Review Request: port sonnet away from i18nc

2012-11-21 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107412/ --- Review request for kdelibs and David Faure. Description --- port sonn

Re: ABI break -- kdepimlims 4.9.3

2012-11-21 Thread Allen Winter
On Wednesday 21 November 2012 12:32:45 PM José Manuel Santamaría Lema wrote: > Hello, > > while packaging kdepimlibs 4.9.3 I found what I think it's an ABI break in > libkabc; looks like the ABI break was introduced in this commit: > https://projects.kde.org/projects/kde/kdepimlibs/repository/rev

Moving Trojitá to extragear

2012-11-21 Thread Jan Kundrát
Hi, thanks for your encouragement. Trojitá, a fast IMAP e-mail client (homepage [1], more in-depth look [2], the KDE project page [3]) has spent the last week or so under playground and was just moved to kdereview (thanks to sysadmins for their excellent turnaround time). I'd appreciate people

ABI break -- kdepimlims 4.9.3

2012-11-21 Thread José Manuel Santamaría Lema
Hello, while packaging kdepimlibs 4.9.3 I found what I think it's an ABI break in libkabc; looks like the ABI break was introduced in this commit: https://projects.kde.org/projects/kde/kdepimlibs/repository/revisions/da16f7d5 The attached patch applies to 4.9.3 and solves the problem. If the pat

Re: Review Request: favicon local cache

2012-11-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107358/#review22327 --- This review has been submitted with commit 6da17ae80bd8cb5453e

Re: Review Request: Jar archives also uses the zip protocol.

2012-11-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101455/#review22318 --- Hmm, this shouldn't be necessary, in fact. The mimetype defini

Re: Review Request: Don't append "0-" when dragging and dropping from trash

2012-11-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105078/#review22311 --- Ship it! Starting to look good :-) Just one minor code issue,