Re: Review Request: Fix margin on KMessageWidget to match that used by a styled QFrame.

2012-11-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107332/#review7 --- This review has been submitted with commit d5c3c9822a38574162e

Re: Prepping KDirModel and KFileItem for QML

2012-11-19 Thread Mark
On Mon, Nov 19, 2012 at 8:01 PM, David Faure wrote: > On Monday 19 November 2012 19:39:19 Mark wrote: >> 4. in org.kde.kio, add a KDirModel subclass (DirModel) and add a >> indexForItem that returns a FileItem object. (this is a >> QDeclerativeItem) > > Right, which enforces my point about making

Re: Prepping KDirModel and KFileItem for QML

2012-11-19 Thread David Faure
On Monday 19 November 2012 19:39:19 Mark wrote: > 4. in org.kde.kio, add a KDirModel subclass (DirModel) and add a > indexForItem that returns a FileItem object. (this is a > QDeclerativeItem) Right, which enforces my point about making this separate: it comes with a dependency on a different Qt

Re: Review Request: favicon local cache

2012-11-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107358/#review22217 --- Thanks for this improvement. I got bitten by the konsole/KUriFi

Re: Prepping KDirModel and KFileItem for QML

2012-11-19 Thread Mark
On Mon, Nov 19, 2012 at 7:00 PM, David Faure wrote: > On Monday 19 November 2012 18:11:06 Mark wrote: >> On Mon, Nov 19, 2012 at 12:05 PM, David Faure wrote: >> > On Saturday 17 November 2012 18:02:59 Mark wrote: >> >> On Sat, Nov 17, 2012 at 5:04 PM, Aaron J. Seigo wrote: >> >> > On Saturday, N

Re: Prepping KDirModel and KFileItem for QML

2012-11-19 Thread David Faure
On Monday 19 November 2012 18:11:06 Mark wrote: > On Mon, Nov 19, 2012 at 12:05 PM, David Faure wrote: > > On Saturday 17 November 2012 18:02:59 Mark wrote: > >> On Sat, Nov 17, 2012 at 5:04 PM, Aaron J. Seigo wrote: > >> > On Saturday, November 17, 2012 16:22:07 Mark wrote: > >> >> Why don't we

Re: Prepping KDirModel and KFileItem for QML

2012-11-19 Thread Mark
On Mon, Nov 19, 2012 at 12:05 PM, David Faure wrote: > On Saturday 17 November 2012 18:02:59 Mark wrote: >> On Sat, Nov 17, 2012 at 5:04 PM, Aaron J. Seigo wrote: >> > On Saturday, November 17, 2012 16:22:07 Mark wrote: >> >> Why don't we just make KFileItem available in QML. >> >> It doesn't hav

Re: Review Request: QtWebKit is needed but not required bei CMakeList.txt

2012-11-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107386/#review22216 --- Ship it! Thanks. Description could be improved a bit, but let'

Re: Review Request: QtWebKit is needed but not required bei CMakeList.txt

2012-11-19 Thread Guy Maurel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107386/ --- (Updated Nov. 19, 2012, 4:12 p.m.) Review request for kdelibs, David Faure

Re: Review Request: QtWebKit is needed but not required bei CMakeList.txt

2012-11-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107386/#review22214 --- Strange location for the check, this sounds like something that

Review Request: QtWebKit is needed but not required bei CMakeList.txt

2012-11-19 Thread Guy Maurel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107386/ --- Review request for kdelibs, David Faure and Alexander Neundorf. Descriptio

Re: Review Request: Fix sizing of KMessageWidget when shown at startup

2012-11-19 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107336/#review22211 --- Ship it! This fixes the sizing problems for KMessageWidget tha

Re: Avoid QDBusConnection Qt warning message for each KUniqueApplication

2012-11-19 Thread David Faure
On Saturday 17 November 2012 10:05:46 Thiago Macieira wrote: > The private connection should be just placing calls, never receiving > them. So it does not need to register a service. > > The parent process needs to wait for the child process to signal that it's > ready to receive the call. If I

Re: Prepping KDirModel and KFileItem for QML

2012-11-19 Thread David Faure
On Saturday 17 November 2012 18:02:59 Mark wrote: > On Sat, Nov 17, 2012 at 5:04 PM, Aaron J. Seigo wrote: > > On Saturday, November 17, 2012 16:22:07 Mark wrote: > >> Why don't we just make KFileItem available in QML. > >> It doesn't have to be a QML component, but if KFileItem where to have > >>