Review Request: Fix in documentation (comment in header): QPrinter::PaperSize instead of QPrinter::PageSize

2012-11-17 Thread Thomas Fischer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107356/ --- Review request for kdelibs. Description --- According to the latest Q

Re: Avoid QDBusConnection Qt warning message for each KUniqueApplication

2012-11-17 Thread Thiago Macieira
On sábado, 17 de novembro de 2012 18.56.11, David Faure wrote: > On Saturday 17 November 2012 07:22:34 Thiago Macieira wrote: > > On sábado, 17 de novembro de 2012 10.55.01, David Faure wrote: > > > My current broken patch is > > > http://www.davidfaure.fr/2012/kuniqueapp_broken_fix.diff > > > > >

Re: Avoid QDBusConnection Qt warning message for each KUniqueApplication

2012-11-17 Thread David Faure
On Saturday 17 November 2012 07:22:34 Thiago Macieira wrote: > On sábado, 17 de novembro de 2012 10.55.01, David Faure wrote: > > My current broken patch is > > http://www.davidfaure.fr/2012/kuniqueapp_broken_fix.diff > > > > The change from QDBusConnectionInterface* to QDBusConnection as the retur

Re: Prepping KDirModel and KFileItem for QML

2012-11-17 Thread Mark
On Sat, Nov 17, 2012 at 5:04 PM, Aaron J. Seigo wrote: > On Saturday, November 17, 2012 16:22:07 Mark wrote: >> Why don't we just make KFileItem available in QML. >> It doesn't have to be a QML component, but if KFileItem where to have >> Q_PROPERTY lines then most of the data would already be pos

Re: Avoid QDBusConnection Qt warning message for each KUniqueApplication

2012-11-17 Thread Allen Winter
On Saturday, November 17, 2012 10:55:01 AM David Faure wrote: > > I know that I said "not a problem in KF5 anymore", but kdelibs4 is still > going > to be used for a very long time, and warnings on startup don't make it appear > very polished... Could you take a look at it -- based on the curre

Re: Prepping KDirModel and KFileItem for QML

2012-11-17 Thread Kevin Krammer
On Saturday, 2012-11-17, Mark wrote: > On Sat, Nov 17, 2012 at 4:40 PM, Kevin Krammer wrote: > > Hi Mark, > > > > On Saturday, 2012-11-17, Mark wrote: > >> So i was thinking: Why don't we just make KFileItem available in QML. > >> It doesn't have to be a QML component, but if KFileItem where to h

Re: Prepping KDirModel and KFileItem for QML

2012-11-17 Thread Aaron J. Seigo
On Saturday, November 17, 2012 16:22:07 Mark wrote: > Why don't we just make KFileItem available in QML. > It doesn't have to be a QML component, but if KFileItem where to have > Q_PROPERTY lines then most of the data would already be possible to > make available because this means making KFileIte

Re: Prepping KDirModel and KFileItem for QML

2012-11-17 Thread Mark
On Sat, Nov 17, 2012 at 4:40 PM, Kevin Krammer wrote: > Hi Mark, > > On Saturday, 2012-11-17, Mark wrote: > >> So i was thinking: Why don't we just make KFileItem available in QML. >> It doesn't have to be a QML component, but if KFileItem where to have >> Q_PROPERTY lines then most of the data wo

Re: Prepping KDirModel and KFileItem for QML

2012-11-17 Thread Kevin Krammer
Hi Mark, On Saturday, 2012-11-17, Mark wrote: > So i was thinking: Why don't we just make KFileItem available in QML. > It doesn't have to be a QML component, but if KFileItem where to have > Q_PROPERTY lines then most of the data would already be possible to > make available. I did this in my co

Re: Avoid QDBusConnection Qt warning message for each KUniqueApplication

2012-11-17 Thread Thiago Macieira
On sábado, 17 de novembro de 2012 10.55.01, David Faure wrote: > My current broken patch is > http://www.davidfaure.fr/2012/kuniqueapp_broken_fix.diff > > The change from QDBusConnectionInterface* to QDBusConnection as the return > value of tryToInitDBusConnection() -- which introduces a bit of noi

Prepping KDirModel and KFileItem for QML

2012-11-17 Thread Mark
Hi, In my project i need to use the KDirModel and KFileItem functionalities. KDirModel is exposed through the custom class that Marco Martin made [1] and it works. However, that custom class does (apparently) need to expose some QML ready data hence the get function [2] (from line 99). So i was t

Review Request: favicon local cache

2012-11-17 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107358/ --- Review request for kdelibs. Description --- Does not fix the bugs (I'

Re: Avoid QDBusConnection Qt warning message for each KUniqueApplication

2012-11-17 Thread David Faure
Long ago, Thiago wrote: > Here's *should* go on: > > 1) KUniqueApplication connects to D-Bus using a private connection > > 2) it checks if the application is already running. If it is and we would > fork, we simply ask the running instance to show a new main window. Then we > exit. > > 3) if