Re: Review Request: Fix memory leak in KJSEmbed when connecting signals and slots through the QObject binding

2012-11-15 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107324/#review22068 --- Ship it! Looks good (even a bit better than my initial try). A

Re: Review Request: Fix margin on KMessageWidget to match that used by a styled QFrame.

2012-11-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107332/ --- (Updated Nov. 16, 2012, 2:11 a.m.) Review request for kdelibs and Aurélien

Re: Review Request: Fix margin on KMessageWidget to match that used by a styled QFrame.

2012-11-15 Thread David Edmundson
> On Nov. 15, 2012, 9:11 a.m., Aurélien Gâteau wrote: > > Good catch, things looks more aligned now. > > > > I am a bit worried about the 2px value being specific to Oxygen widget > > style though. How does it behave with other styles? Maybe you can extract > > this value using QStyle::pixelMe

Re: KIO::ListJob::entries emits twice for folders with 100+ entries. Why?

2012-11-15 Thread Kevin Krammer
On Thursday, 2012-11-15, Mark wrote: > Also, funny that you mention dolphin. Since dolphin can't possibly > make use of this. Dolphin is sorting the entries thus needs all of > them to be in before it can even sort. And even "if" dolphin receives > two entries signals (which is the itemsAdded sign

Re: KIO::ListJob::entries emits twice for folders with 100+ entries. Why?

2012-11-15 Thread Mark
On Thu, Nov 15, 2012 at 6:26 PM, David Faure wrote: > On Thursday 15 November 2012 13:12:27 Mark wrote: >> My bad, the second signal is only emitting the remainder of whatever >> comes after the first signal. >> However, i still have the question as to why it happens at all? > > So that dolphin do

Re: KIO::ListJob::entries emits twice for folders with 100+ entries. Why?

2012-11-15 Thread David Faure
On Thursday 15 November 2012 13:12:27 Mark wrote: > My bad, the second signal is only emitting the remainder of whatever > comes after the first signal. > However, i still have the question as to why it happens at all? So that dolphin doesn't keep the user waiting in front of a blank view for a l

Re: Review Request: Prevent activation of tabs opened in the background

2012-11-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107048/#review22039 --- This review has been submitted with commit f1180645daa72b182f5

Review Request: Fix sizing of KMessageWidget when shown at startup

2012-11-15 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107336/ --- Review request for kdelibs and Dominik Haumann. Description --- When

Re: KIO::ListJob::entries emits twice for folders with 100+ entries. Why?

2012-11-15 Thread Mark
On Thu, Nov 15, 2012 at 11:02 AM, David Faure wrote: > On Wednesday 14 November 2012 22:18:08 Albert Astals Cid wrote: >> El Dimecres, 14 de novembre de 2012, a les 17:32:35, Mark va escriure: >> > Hi, >> > >> > I'm playing with KIO::listDir() and the signals to get the directory >> > content and

Re: Review Request: Fix memory leak in KJSEmbed when connecting signals and slots through the QObject binding

2012-11-15 Thread Daniel Calviño Sánchez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107324/ --- (Updated Nov. 15, 2012, 10:42 a.m.) Review request for kdelibs. Changes

Re: KIO::ListJob::entries emits twice for folders with 100+ entries. Why?

2012-11-15 Thread David Faure
On Wednesday 14 November 2012 22:18:08 Albert Astals Cid wrote: > El Dimecres, 14 de novembre de 2012, a les 17:32:35, Mark va escriure: > > Hi, > > > > I'm playing with KIO::listDir() and the signals to get the directory > > content and i've hit a strange "issue". Apparently when a folder has > >

Re: Review Request: Fix margin on KMessageWidget to match that used by a styled QFrame.

2012-11-15 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107332/#review22024 --- Good catch, things looks more aligned now. I am a bit worried

Re: Review Request: Fix margin on KMessageWidget to match that used by a styled QFrame.

2012-11-15 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107332/#review22023 --- Interestingly, some comments on http://kate-editor.org/2012/11