Review Request: Fix margin on KMessageWidget to match that used by a styled QFrame.

2012-11-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107332/ --- Review request for kdelibs and Aurélien Gâteau. Description --- Fix m

Re: Review Request: Fix memory leak in KJSEmbed when connecting signals and slots through the QObject binding

2012-11-14 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107324/#review22016 --- First off, good catch on the memory leak, I agree the current c

Re: KDEREVIEW: StackFolder plasma applet

2012-11-14 Thread Albert Astals Cid
El Dimecres, 14 de novembre de 2012, a les 22:23:37, Ural Mullabaev va escriure: > Hi Albert! > > > Code comments: > > * You still have two uncommented qDebug, please turn them into kDebug > > or > > comment them > > I changed these to kDebug because they are look like more warning messages. Ma

Re: KIO::ListJob::entries emits twice for folders with 100+ entries. Why?

2012-11-14 Thread Mark
On Wed, Nov 14, 2012 at 10:18 PM, Albert Astals Cid wrote: > El Dimecres, 14 de novembre de 2012, a les 17:32:35, Mark va escriure: >> Hi, >> >> I'm playing with KIO::listDir() and the signals to get the directory >> content and i've hit a strange "issue". Apparently when a folder has >> more than

Re: KDEREVIEW: StackFolder plasma applet

2012-11-14 Thread Ural Mullabaev
Hi Albert! > Code comments: > * You still have two uncommented qDebug, please turn them into kDebug > or > comment them I changed these to kDebug because they are look like more warning messages. > * In proxymodel.cpp you do > const QDateTime time1 = QDateTime::fromString(dirModel- > >data(left)

Re: KIO::ListJob::entries emits twice for folders with 100+ entries. Why?

2012-11-14 Thread Albert Astals Cid
El Dimecres, 14 de novembre de 2012, a les 17:32:35, Mark va escriure: > Hi, > > I'm playing with KIO::listDir() and the signals to get the directory > content and i've hit a strange "issue". Apparently when a folder has > more than 100 entries the entries signal [1] will be emitted twice. > 1 wit

Re: Trojitá, an IMAP e-mail client, and KDE

2012-11-14 Thread Christoph Feck
On Tuesday 13 November 2012 16:38:35 Jan Kundrát wrote: > So, would the KDE community be interested in making Trojitá a part > of KDE's extragear? > [1] http://trojita.flaska.net/ To request a git repository in playground, please use http://sysadmin.kde.org/svnaccount/repo-request.php You could

Re: Trojitá, an IMAP e-mail client, and KDE

2012-11-14 Thread Ivan Čukić
Hi, > I realize that this might be a slightly unusual case, but I've read through I don't think it would be the first - iirc, some KDE apps already have a Qt- only build mode (Marble if I'm not mistaken) > So, would the KDE community be interested in making Trojitá a part of KDE's > extragear?

Review Request: Fix memory leak in KJSEmbed when connecting signals and slots through the QObject binding

2012-11-14 Thread Daniel Calviño Sánchez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107324/ --- Review request for kdelibs. Description --- A char* is used to store