Re: Review Request: parenthesis and not null checking

2012-11-10 Thread Rolf Eike Beer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107213/#review21785 --- A simple way to verify if this is correct is check if you and t

Re: Review Request: Don't append "0-" when dragging and dropping from trash

2012-11-10 Thread David Faure
> On June 19, 2012, 5:55 a.m., David Faure wrote: > > Good idea, but it seems to break the case where nested dirs exist in the > > directory being restored. Everything gets flattened out. Probably a bug in > > CopyJob though, in the handling of fileNameUsedForCopying=DisplayName > > Michael Re

Re: Review Request: Don't append "0-" when dragging and dropping from trash

2012-11-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105078/#review21782 --- kioslave/trash/kio_trash.cpp

Re: What is the git workflow for kdelibs ?

2012-11-10 Thread Alexander Neundorf
On Saturday 10 November 2012, David Faure wrote: > On Wednesday 07 November 2012 17:45:19 Alexander Neundorf wrote: > > > On Thursday, November 1, 2012 12:05:51 David Faure wrote: > > > > (seems I'm still confused about techbase vs community) > > > > The git workflow docs should go to techbase

Re: What is the git workflow for kdelibs ?

2012-11-10 Thread David Faure
On Wednesday 07 November 2012 17:45:19 Alexander Neundorf wrote: > > On Thursday, November 1, 2012 12:05:51 David Faure wrote: > > > (seems I'm still confused about techbase vs community) > > > The git workflow docs should go to techbase, probably in the git section > IMO. At the risk of bike

Re: kdelibs git mess

2012-11-10 Thread David Faure
On Thursday 08 November 2012 19:31:30 Stephen Kelly wrote: > Christoph Feck wrote: > > Hi, > > > > my git foo is limited, but if I interpret http://ompldr.org/vZzZxaw > > correctly, then somehow master got merged into KDE/4.9 branch, > > meaning, for example, that Alex's commits to depend on cmake

Re: Review Request: remove an assert

2012-11-10 Thread Andras Mantia
On Tuesday, November 06, 2012 09:08:36 AM Jaime Torres Amate wrote: > > On Nov. 6, 2012, 6:46 a.m., David Edmundson wrote: > > > The responsibility of deleting d->rootDir seems to lie within KArchive. > > > Therefore by setting the rootDir twice either implicitly or explicitly > > > (which this ass