Re: Review Request: This change will allow the user to see keyboard layout visually

2012-11-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107202/#review21521 --- This review has been submitted with commit 30f4b266dd1df9ab2a9

Re: KDE-GTK-Config to KDEReview

2012-11-06 Thread Pino Toscano
Hi, Alle lunedì 5 novembre 2012, Aleix Pol ha scritto: > Some months ago I pushed this project quite intensively so that right > now we have a stable KCM for editing the GTK settings. This is being > used already in some distributions, so I think it should be moved to > extragear/base. > > So her

Re: Nepomuk Metadata Extractor moved to KDE Review

2012-11-06 Thread Jörg Ehrichs
Hi, >> First: >> If the servcie is started the first time (which happens automatically when >> it is installed) It will disable itself and also alter the >> restart-on-reboot nepomuk config file. > > Not sure I get it, what's the use of this? You assume "user installs it -> is > fine with requesti

Re: Cleaning house: KDE Review

2012-11-06 Thread Ben Cooksley
On Wed, Nov 7, 2012 at 3:06 AM, Cedric Bellegarde wrote: > Hello, Hi Cedric, > > kded-appmenu in KDE review should be removed, it's 4.9 version and i do not > plan to work on this anymore. Is the 4.10 version related in any form to the 4.9 version? If so, we can probably delete the 4.9 version

Re: Review Request: Respect PYTHONDONTWRITEBYTECODE env variable

2012-11-06 Thread Luca Beltrame
> On Nov. 6, 2012, 10:49 p.m., Luca Beltrame wrote: > > Good catch, I missed that. Push to 4.9: as I'm not sure it would merge > > cleanly as I changed a bit of things in 4.10, CC me in the commit and I'll > > see about trying to adapt it. Bear in mind that if you use this to avoid writing byt

Re: Review Request: Respect PYTHONDONTWRITEBYTECODE env variable

2012-11-06 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107228/#review21511 --- Ship it! Good catch, I missed that. Push to 4.9: as I'm not su

Re: Cleaning house: KDE Review

2012-11-06 Thread Cedric Bellegarde
Hello, kded-appmenu in KDE review should be removed, it's 4.9 version and i do not plan to work on this anymore. 4.10 version is in trunk: http://quickgit.kde.org/index.php?p=kde- workspace.git&a=tree&f=appmenu regards, -- Cédric

Review Request: Respect PYTHONDONTWRITEBYTECODE env variable

2012-11-06 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107228/ --- Review request for kdelibs. Description --- cmake/modules/PythonMacro

Re: Nepomuk Metadata Extractor moved to KDE Review

2012-11-06 Thread Sebastian Kügler
Hi Jörg, On Tuesday, November 06, 2012 11:19:26 Jörg Ehrichs wrote: > 2012/10/31 Sebastian Kügler > > > But I assume this is something the packagers have to split. > > That would be almost making sure that it will hit users. In general, never > assume something's going to be fixed by packagers,

Re: Nepomuk Metadata Extractor moved to KDE Review

2012-11-06 Thread Jörg Ehrichs
Hi, > > Just a small question regarding the name - what do you think about > renaming it to Nepomuk Metadata Retriever / Fetcher / Miner ... > I don't really care about the naming, so I'm fine to rename it. The application is called "MetaData Extarctor" because Web-Extractor is already taken. Th

Re: Nepomuk Metadata Extractor moved to KDE Review

2012-11-06 Thread Jörg Ehrichs
Hi Albert, thanks for your input. I have a few questions about them though. 2012/11/5 Albert Astals Cid > > How are you handling the i18n in the lib part? It seems like you'd need a > KCatalogLoader in there. i18n is something I never liked about KDE, it is a big magic box to me and i'm always

Re: Nepomuk Metadata Extractor moved to KDE Review

2012-11-06 Thread Jörg Ehrichs
Hi Sebastian, 2012/10/31 Sebastian Kügler > > > But I assume this is something the packagers have to split. > > That would be almost making sure that it will hit users. In general, never > assume something's going to be fixed by packagers, they, too, need > something > that can just be slapped i

Re: Review Request: remove an assert

2012-11-06 Thread Jaime Torres Amate
> On Nov. 6, 2012, 6:46 a.m., David Edmundson wrote: > > The responsibility of deleting d->rootDir seems to lie within KArchive. > > Therefore by setting the rootDir twice either implicitly or explicitly > > (which this assert is designed to avoid) you risk leaking the first > > KArchiveDirect