Re: Review Request: remove an assert

2012-11-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107211/#review21475 --- The responsibility of deleting d->rootDir seems to lie within K

KDEREVIEW: share like connect and plasmate

2012-11-05 Thread David Edmundson
Initial code review of Share-Like-Connect: from provider.h ~Provider(); This class is designed to be subclassed, yet the destructor is public and non virtual. The derived classes will leak everything. -- virtual QVariant executeAction(SLC::Provider::Action action, const QVariantHash &conte

Re: Review Request: This change will allow the user to see keyboard layout visually

2012-11-05 Thread Andriy Rysin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107202/ --- (Updated Nov. 6, 2012, 4:53 a.m.) Review request for KDE Runtime and Shaun

Re: Nepomuk Metadata Extractor moved to KDE Review

2012-11-05 Thread Martin Klapetek
On Mon, Nov 5, 2012 at 10:36 PM, Ivan Čukić wrote: > Hi all, > > Just a small question regarding the name - what do you think about > renaming it to Nepomuk Metadata Retriever / Fetcher / Miner ... > > Extractor seems more like something that gets (extracts) the data from > Nepomuk than something

Re: Nepomuk Metadata Extractor moved to KDE Review

2012-11-05 Thread Ivan Čukić
Hi all, Just a small question regarding the name - what do you think about renaming it to Nepomuk Metadata Retriever / Fetcher / Miner ... Extractor seems more like something that gets (extracts) the data from Nepomuk than something that puts it in. Ch! -- While you were hanging yourself on

Re: Nepomuk Metadata Extractor moved to KDE Review

2012-11-05 Thread Albert Astals Cid
El Dimarts, 30 d'octubre de 2012, a les 23:11:57, Jörg Ehrichs va escriure: > Hi all, > > today I've moved my metadata extractor into KDE Review [1]. > As kde-libs is frozen till kf5 I like to get this into extragear/base > (unless anyone has a better idea where to put this). > > For those who ar

Re: KDEREVIEW: share like connect and plasmate

2012-11-05 Thread Albert Astals Cid
El Dijous, 1 de novembre de 2012, a les 20:06:36, Aaron J. Seigo va escriure: > Hello all ... Hi > This is to inform everyone that the plasmate and share-like-connect > repositories have been moved into KDE Review so that, if all goes according > to plan, we can move them to their more permanent

KDE-GTK-Config to KDEReview

2012-11-05 Thread Aleix Pol
Hi, Some months ago I pushed this project quite intensively so that right now we have a stable KCM for editing the GTK settings. This is being used already in some distributions, so I think it should be moved to extragear/base. So here I open the process for kde:kde-gtk-config to move in extragear

Re: Moving libkfacebook to extragear

2012-11-05 Thread Pino Toscano
Hi, Alle sabato 27 ottobre 2012, Martin Klapetek ha scritto: > I'd like to move libkfacebook, the foundation for akonadi-facebook > resource, into extragear. It's been in use for a while, lots of > distro ship it bundled with akonadi-facebook resource, which is now > becaming part of kdepim-runtim

Review Request: parenthesis and not null checking

2012-11-05 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107213/ --- Review request for kdelibs. Description --- place some parenthesis ar

Re: KDEREVIEW: share like connect and plasmate

2012-11-05 Thread Pino Toscano
Alle lunedì 5 novembre 2012, Giorgos Tsiapaliokas ha scritto: > On 4 November 2012 16:55, Pino Toscano wrote: > > - the following binaries are installed in $prefix/bin: > > - plasmaengineexplorer > > - plasmakconfigxteditor > > - plasmaremoteinstaller > > - plasmate > > - plasmawallpaper

Re: KDEREVIEW: share like connect and plasmate

2012-11-05 Thread Pino Toscano
Hi, Alle lunedì 5 novembre 2012, Giorgos Tsiapaliokas ha scritto: > On 3 November 2012 19:35, Pino Toscano wrote: > > - a numer of .ui files sets bold/bigger texts, but using a qt rich > > text which forces a font size (and in few cases also the font > > face) > > and which is the correct way in

Review Request: remove an assert

2012-11-05 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107211/ --- Review request for kdelibs. Description --- I've suffered this assert

Re: KDEREVIEW: share like connect and plasmate

2012-11-05 Thread Giorgos Tsiapaliokas
On 4 November 2012 16:55, Pino Toscano wrote: > - the following binaries are installed in $prefix/bin: > - plasmaengineexplorer > - plasmakconfigxteditor > - plasmaremoteinstaller > - plasmate > - plasmawallpaperviewer > - plasmoidviewer > - remote-widgets-browser (*) > - windowswi

Re: KDEREVIEW: share like connect and plasmate

2012-11-05 Thread Giorgos Tsiapaliokas
Hello, On 3 November 2012 19:35, Pino Toscano wrote: > - a numer of .ui files sets bold/bigger texts, but using a qt rich text > which forces a font size (and in few cases also the font face) and which is the correct way in order to fix this? > - RemoteInstaller uses "/var/tmp/plasmaremoteinst

Re: merging development branch into master

2012-11-05 Thread Sebastian Kügler
On Sunday, November 04, 2012 09:34:03 Andriy Rysin wrote: > * or we should rebase feature branch on master and then generate the > review diff? That should work. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9