Re: Introducing a plugin loading approach inside of the KWallet convenience API

2012-10-29 Thread Valentin Rusu
On 10/29/2012 07:07 PM, Albert Astals Cid wrote: Can we please please plase be sure this time it works? Don't want to repeat the fiasco we had with ksecretservice that was introduced in 4.8 and then removed in 4.9 since it wasn't really working. Well, this time I'll do things more carefully, on

Re: Review Request: Jar archives also uses the zip protocol.

2012-10-29 Thread Emmanuel Pescosta
> On May 28, 2011, 9:26 a.m., David Faure wrote: > > Does this break running .jar files with a .desktop file that says > > "Exec=java -jar %f"? > > > > Maybe the "more advanced" use case of viewing a .jar like a .zip should be > > a servicemenu (i.e. RMB / Actions / ...) Running .jar files wi

Re: Introducing a plugin loading approach inside of the KWallet convenience API

2012-10-29 Thread Albert Astals Cid
Have not read anything since i'm ultra busy, so please disregard my message if it is off topic Can we please please plase be sure this time it works? Don't want to repeat the fiasco we had with ksecretservice that was introduced in 4.8 and then removed in 4.9 since it wasn't really working. Ch

Re: Moving libkfacebook to extragear

2012-10-29 Thread Kevin Krammer
On Sunday, 2012-10-28, Kevin Krammer wrote: > On Sunday, 2012-10-28, Martin Klapetek wrote: > > On Sat, Oct 27, 2012 at 6:05 PM, Kevin Krammer wrote: > > > - the *Info classes seem to be normal data classes, IMHO they don't > > > need to be > > > QObjects but rather "value types" > > > > This is

Re: Moving libkfacebook to extragear

2012-10-29 Thread Martin Klapetek
On Mon, Oct 29, 2012 at 11:52 AM, Martin Klapetek wrote: > > Also heads up - the latest changes somehow broke the akonadi resource (the > one in patch for kdepim-runtime on reviewboard), I'm on it, will keep you > posted. > All fixed. If you're testing this, please update both your libkfacebook

Re: Moving libkfacebook to extragear

2012-10-29 Thread Martin Klapetek
On Mon, Oct 29, 2012 at 11:44 AM, Kevin Krammer wrote: > > > Good points, all fixed. > > Almost :) > FacebookJob::m_queryItems is still there. can probably also remove the > typedef > for QueryItem. > Damn, overlooked. Fixed now. Also heads up - the latest changes somehow broke the akonadi reso

Re: Moving libkfacebook to extragear

2012-10-29 Thread Kevin Krammer
On Monday, 2012-10-29, Martin Klapetek wrote: > On Mon, Oct 29, 2012 at 8:28 AM, Kevin Krammer wrote: > > I think you can remove m_accessToken, m_path and m_queryItems from > > FacebookJob. > > Access token and path are already set on m_url and addQueryItem can be > > implemented to just call m_ur

Re: Moving libkfacebook to extragear

2012-10-29 Thread Martin Klapetek
On Mon, Oct 29, 2012 at 8:28 AM, Kevin Krammer wrote: > > I think you can remove m_accessToken, m_path and m_queryItems from > FacebookJob. > Access token and path are already set on m_url and addQueryItem can be > implemented to just call m_url.addQueryItem(). > > Also, virtual void start() = 0

Re: QActions in QML

2012-10-29 Thread Daker Fernandes Pinheiro
Sebas, This just worked: http://paste.kde.org/584660/ Where QAction is http://paste.kde.org/584672/ Cheers, Daker Fernandes Pinheiro http://codecereal.blogspot.com 2012/10/28 Sebastian Kügler > On Thursday, October 25, 2012 20:00:25 Aaron J. Seigo wrote: > > not automatically, no. but QActio

Re: Moving libkfacebook to extragear

2012-10-29 Thread Kevin Krammer
On Monday, 2012-10-29, Martin Klapetek wrote: > On Sun, Oct 28, 2012 at 8:03 PM, Kevin Krammer wrote: > > > This is for the parsing purposes - the library uses QJson > > > parser/mapper, which automagically maps the received json data to > > > qobjects, otherwise there would have to be manual pars