Re: KStringHandler: stateless/reentrant/thread-safe?

2012-10-26 Thread Thiago Macieira
On sexta-feira, 26 de outubro de 2012 21.06.35, Frank Reininghaus wrote: > Yes, I thought the same, but then I wasn't entirely sure if all these > functions really are thread-safe. Some of them have const static variables, > which might be initialised the first time the function is called AFAIK. I

Re: Comparing KFileItems

2012-10-26 Thread Michael Pyne
On Friday, October 26, 2012 10:16:50 Frank Reininghaus wrote: > > I was thinking the first one, but indeed Qt often does the second one, > > I'm not sure what the difference really is. Either one is fine with me. > > in the end, I did not inline the function - before I pushed the > commit, I wonde

Re: CMake 2.8.8 will be required for kdelibs 4.10 starting October 30th

2012-10-26 Thread Alexander Neundorf
On Thursday 18 October 2012, Alexander Neundorf wrote: > Hi, > > in kdelibs we require since more than 2 years cmake .2.6.4, since then many > improvements and fixes have gone into cmake, and we cannot make use of > them. > > These are e.g. > * builtin automoc > * support for creating proper Conf

Re: KStringHandler: stateless/reentrant/thread-safe?

2012-10-26 Thread Thomas Lübking
On Freitag, 26. Oktober 2012 21:06:35 CEST, Frank Reininghaus wrote: > Yes, I thought the same, but then I wasn't entirely sure if all these > functions really are thread-safe. Some of them have const static variables, > which might be initialised the first time the function is called AFAIK. I > d

Re: KStringHandler: stateless/reentrant/thread-safe?

2012-10-26 Thread Frank Reininghaus
Hi Thiago, Am 26.10.2012 20:42 schrieb "Thiago Macieira": > > On sexta-feira, 26 de outubro de 2012 20.15.46, Frank Reininghaus wrote: > > KStringHandler [3] say that "The methods here are completely > > stateless", which sounds a bit vague. Does anyone mind if I add "This > > function is reentran

Re: KStringHandler: stateless/reentrant/thread-safe?

2012-10-26 Thread Thiago Macieira
On sexta-feira, 26 de outubro de 2012 20.15.46, Frank Reininghaus wrote: > KStringHandler [3] say that "The methods here are completely > stateless", which sounds a bit vague. Does anyone mind if I add "This > function is reentrant" to the docs of Isn't that a bit redundant? If it's stateless, it

KStringHandler: stateless/reentrant/thread-safe?

2012-10-26 Thread Frank Reininghaus
Hi everyone, Emmanuel is currently working on implementing a parallel sort algorithm for Dolphin to speed up loading very large folders [1]. Sorting takes quite long due to the complexity of 'natural' sorting, which uses the comparison function KStringHandler::naturalCompare(). There are ideas how

Review Request: Prevent activation of tabs opened in the background

2012-10-26 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107048/ --- Review request for KDE Base Apps and David Faure. Description --- The

Re: Comparing KFileItems

2012-10-26 Thread Frank Reininghaus
Hi David, 2012/10/24 David Faure: > On Wednesday 24 October 2012 10:47:46 Frank Reininghaus wrote: >> Hi David, >> >> I see that I should probably have created a review request to make >> review easier for you - sorry about that! But I think we're getting >> closer to the final solution, so I'll j