Re: Review Request: Keep KService::createInstance error message in KServiceTypeTrader::createInstanceFromQuery

2012-10-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107032/#review20933 --- This review has been submitted with commit c78c13973ab47a79dc0

Re: Review Request: Check if the startDir has an schema before discarting it

2012-10-25 Thread Christoph Feck
> On Oct. 4, 2012, 4:28 p.m., Christoph Feck wrote: > > Causes a regression. When using "Save Image As..." in Konqueror, the file > > dialog starts at "Custom Path" (and lists root folder), without remembering > > the previously used path. > > Jonathan Marten wrote: > Doing the test as fol

Re: Review Request: Possibility to change an element ID of svg image in IconWidget

2012-10-25 Thread Dmitry Ashkadov
> On Oct. 25, 2012, 11:36 a.m., Aaron J. Seigo wrote: > > the real fix here is to not use IconWidget :) that's a QGraphicsWidget > > thing and will need to be replaced eventually anyways. > > > > this should be using the Button QML element, which does support using SVG > > files. IconWidget s

Re: Review Request: Keep KService::createInstance error message in KServiceTypeTrader::createInstanceFromQuery

2012-10-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107032/#review20920 --- Ship it! OK. In case of multiple offers with error, this will

Re: Review Request: Possibility to change an element ID of svg image in IconWidget

2012-10-25 Thread Aaron J. Seigo
> On Oct. 25, 2012, 11:36 a.m., Aaron J. Seigo wrote: > > the real fix here is to not use IconWidget :) that's a QGraphicsWidget > > thing and will need to be replaced eventually anyways. > > > > this should be using the Button QML element, which does support using SVG > > files. > > Dmitry A

Re: Review Request: Possibility to change an element ID of svg image in IconWidget

2012-10-25 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107017/#review20863 --- the real fix here is to not use IconWidget :) that's a QGraphic

Re: Review Request: Cache icon and accessibility in KFilePlacesItem

2012-10-25 Thread Dan Vrátil
> On Oct. 24, 2012, 11:26 p.m., Christoph Feck wrote: > > Let me understand, what you are proposing. If Solid is slow returning the > > values, then the caching should be in Solid, not in every application that > > uses it. But until that is implemented in Solid, we could use this > > workarou

Re: Review Request: Cache icon and accessibility in KFilePlacesItem

2012-10-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107030/#review20851 --- This review has been submitted with commit f29be6d309a533e0870

Re: kdereview: bodega

2012-10-25 Thread Aaron J. Seigo
On Wednesday, October 24, 2012 21:10:58 Josef Spillner wrote: > It should be easily possible to define asset content models and delivery > options to cover this diversity in a multi-market frontend. While for most > digital assets the delivery option may be "download" or "subscribe", for > services