Re: Review Request: Add pkgconfig hints to FindSamba.cmake

2012-10-21 Thread Rex Dieter
> On Oct. 21, 2012, 9:27 a.m., Raphael Kubo da Costa wrote: > > cmake/modules/FindSamba.cmake, line 23 > > > > > > Please note that support for the QUIET keyword was added in CMake 2.8.2 > > -- it is probably OK for

Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106902/#review20640 --- This review has been submitted with commit 0b8942128aafe59d7ff

Re: Dependency Freeze for 4.10 in two weeks

2012-10-21 Thread Albert Astals Cid
El Diumenge, 21 d'octubre de 2012, a les 11:53:49, David Faure va escriure: > On Thursday 18 October 2012 22:32:12 Albert Astals Cid wrote: > > Dependency freeze for 4.10 releases is in two weeks (November 1st), please > > be sure you update all the needed dependencies before that date. > > > > No

Re: Comparing KFileItems

2012-10-21 Thread David Faure
On Thursday 18 October 2012 13:54:09 Frank Reininghaus wrote: > Obviously, KFileItems are only considered equal if their d pointers > are the same. Yes, i.e. created from the same place. But I agree, let's compare URLs too, since they are "unique identifiers" for resources. > There is a Dolphin

Re: Dependency Freeze for 4.10 in two weeks

2012-10-21 Thread David Faure
On Thursday 18 October 2012 22:32:12 Albert Astals Cid wrote: > Dependency freeze for 4.10 releases is in two weeks (November 1st), please > be sure you update all the needed dependencies before that date. > > Notorious dependencies we might want to discuss: > * kdelibs depends on Qt 4.7 Is anyo

Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106902/#review20612 --- Almost there ;) Feel free to commit after fixing these last sma

Re: Review Request: Add pkgconfig hints to FindSamba.cmake

2012-10-21 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106861/#review20611 --- cmake/modules/FindSamba.cmake