[PATCH] kdecore: Fix a bug in KDateTime utc offset string parsing.

2012-10-07 Thread Jon Severinsson
The sign of the UTC offset was ignored, and an offset of -0500 (New York) would be treated at +0500 (Pakistan). This commit also adds a unit test for UTC offset parsing and comparasion. --- Hi When mucking around in the frameworks branch of kdelibs I found a bug in the KDateTime string parsing, w

Re: Review Request: KJS/Grammar: Introduce new non-terminal IdentifierName, to handle keywords as PropertyName, in Memberexps and CallExpr

2012-10-07 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104243/ --- (Updated Oct. 7, 2012, 10:17 p.m.) Review request for kdelibs. Changes -

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

2012-10-07 Thread Alexander Neundorf
On Thursday 04 October 2012, Stephen Kelly wrote: > Alexander Neundorf wrote: > > On Monday 01 October 2012, David Faure wrote: > >> On Monday 01 October 2012 09:53:22 Stephen Kelly wrote: > >> > Instead, I say we should do a 'pain free' update to 2.8.7 now, and an > >> > update to 2.8.11 later. >

Re: Review LibKdeAccessibilityClient

2012-10-07 Thread Alexander Neundorf
On Thursday 04 October 2012, Frederik Gladhorn wrote: > Hi, > > so after we took the time to hack a bit more on the library in Randa, > I would be happy about more comments. Why does it use KDEPIMLIBS_INSTALL_DIR ? macro(MAKE_INSTALL_PATH_ABSOLUTE out in) if (IS_ABSOLUTE "${in}")# IS_ABS

Re: Review Request: Device notifier: show mounted device and path

2012-10-07 Thread Aaron J. Seigo
> On Oct. 7, 2012, 3:32 p.m., Jacopo De Simoi wrote: > > I do not want the notifier to show this information in the device view; > > indeed, for devices with a label, the mount point is /media/, so the > > information about the mount point would look like quite redundant. > > Perhaps you could

Re: Review Request: Device notifier: show mounted device and path

2012-10-07 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106755/#review20039 --- I do not want the notifier to show this information in the devi

Review Request: Device notifier: show mounted device and path

2012-10-07 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106755/ --- Review request for KDE Base Apps and Plasma. Description --- If a rem