Re: Review Request: Fix whitespace related bugs when listing directories in kio_ftp

2012-10-01 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106636/ --- (Updated Oct. 2, 2012, 4:08 a.m.) Review request for kdelibs and David Fau

Re: Review Request: Fix whitespace related bugs when listing directories in kio_ftp

2012-10-01 Thread Dawit Alemayehu
> On Oct. 1, 2012, 8:30 a.m., David Faure wrote: > > kioslave/ftp/ftp.cpp, line 2639 > > > > > > Does this really work? This method is being called in the middle of the > > parsing of "list" command output, so the

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-01 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/ --- (Updated Oct. 1, 2012, 8:56 p.m.) Review request for KDE Base Apps and Dav

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-01 Thread Dawit Alemayehu
> On Sept. 29, 2012, 9:36 a.m., Pino Toscano wrote: > > konqueror/src/konqsessionmanager.cpp, lines 343-345 > > > > > > i18n: what do these "filter-..." contexts mean? I copied those straight out of KMessageBox's c

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-01 Thread Dawit Alemayehu
> On Sept. 29, 2012, 9:20 a.m., David Faure wrote: > > konqueror/src/konqsessionmanager.cpp, line 450 > > > > > > Doesn't this lose ItemIsSelectable? I guess item->flags() | > > Qt::ItemIsUserCheckable would be bet

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

2012-10-01 Thread Alexander Neundorf
On Monday 01 October 2012, David Faure wrote: > On Monday 01 October 2012 09:53:22 Stephen Kelly wrote: > > Instead, I say we should do a 'pain free' update to 2.8.7 now, and an > > update to 2.8.11 later. > > Yes. I disagree. If we upgrade now, I want to have at least 2.8.8 This has a lof of w

Re: Translating Akonadi

2012-10-01 Thread Albert Astals Cid
El Dilluns, 1 d'octubre de 2012, a les 11:36:36, Andras Mantia va escriure: > Hi, Hi > Akonadi is a server application without KDE dependencies and originally was > designed to not show any user-visible strings, except in debug logs. > Unfortunately the way it evolved resulted in some error mess

Re: Review Request: Avoid creating an empty .tbcache for bookmarks

2012-10-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106563/#review19704 --- Ship it! Ship It! - David Faure On Sept. 30, 2012, 8:47 p.m

Re: Review Request: kjs/khtml: Reuse existing html5 Audio Element instead of duplicating it

2012-10-01 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106671/ --- (Updated Oct. 1, 2012, 3:32 p.m.) Review request for kdelibs. Changes --

Review Request: kjs/khtml: Reuse existing html5 Audio Element instead of duplicating it

2012-10-01 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106671/ --- Review request for kdelibs. Description --- kjs/khtml: Reuse existing

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

2012-10-01 Thread David Faure
On Monday 01 October 2012 09:53:22 Stephen Kelly wrote: > Instead, I say we should do a 'pain free' update to 2.8.7 now, and an > update to 2.8.11 later. Yes. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Translating Akonadi

2012-10-01 Thread Andras Mantia
Hi, Akonadi is a server application without KDE dependencies and originally was designed to not show any user-visible strings, except in debug logs. Unfortunately the way it evolved resulted in some error messages going into user visible message boxes. These strings are currently not translate

Re: Review Request: Fix whitespace related bugs when listing directories in kio_ftp

2012-10-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106636/#review19675 --- kioslave/ftp/ftp.cpp

Re: Help your marketing team!

2012-10-01 Thread Vishesh Handa
On Sat, Sep 29, 2012 at 12:10 AM, David Faure wrote: > On Tuesday 25 September 2012 19:16:43 Jos Poortvliet wrote: > > Hi, > > > > We need your help to do better at engaging the world-wide Qt developer > > community. Please answer this question: > > > > "what classes and components in KDELibs/Fra