Review Request: Fix whitespace related bugs when listing directories in kio_ftp

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106636/ --- Review request for kdelibs and David Faure. Description --- The attac

Re: Review Request: Fix for CTRL+Tab not switcing tabs in Konqueror when the active tab is a Dolphin filemanagement part

> On Sept. 28, 2012, 5:42 p.m., David Faure wrote: > > dolphin/src/kitemviews/kitemlistview.cpp, line 871 > > > > > > This strikes me as wrong. Why should this widget's event(QEvent*) > > change the default state o

Re: Review Request: Fix Konqueror's MMB click to close tab option

> On Sept. 29, 2012, 6:48 a.m., David Faure wrote: > > Doesn't this break "moving a tab with MMB" then? The KTabBar > > mousePress/mouseRelease code won't be called anymore. > > > > If this is the case, then what we really have is two incompatible > > features... so we could just remove the "m

Re: Review request reminder: kded-appmenu

On Wednesday 26 September 2012 14:58:55 Cedric Bellegarde wrote: > Hello, > > i'm waiting for some code review on kded-appmenu module: > https://projects.kde.org/projects/kdereview/kded-appmenu > > Martin Gräßlin tells me to send a reminder here before commiting. I need to > put this in kde-works

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

On Saturday, September 29, 2012 12:12:43 André Wöbbeking wrote: > On Saturday 29 September 2012 11:59:04 Rolf Eike Beer wrote: > > Am Samstag 29 September 2012, 11:48:16 schrieb André Wöbbeking: > > > Hi Alex, > > > > > > On Saturday 29 September 2012 10:36:55 Alexander Neundorf wrote: > > > > I kn

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

On Saturday 29 September 2012, Martin Gräßlin wrote: > On Saturday 29 September 2012 13:19:30 you wrote: > > But how does that differ from requiring other very recent packages, > > including Qt ? > > we don't do that. We still require only Qt 4.7 and there is one difference > in build system vs. s

Re: Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

On Saturday 29 September 2012 13:19:30 you wrote: > But how does that differ from requiring other very recent packages, > including Qt ? we don't do that. We still require only Qt 4.7 and there is one difference in build system vs. some depending library. Depending library is nicely handled by sy

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

On Saturday 29 September 2012 13:47:16 Thomas Lübking wrote: > Am 29.09.2012, 13:19 Uhr, schrieb Alexander Neundorf : > > Do you mean they ship cmake 2.8.9 rc1 ? > > Seems so. > http://packages.debian.org/search?keywords=cmake&searchon=names&suite=testin > g§ion=all or http://release.debian.org/

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

On Saturday 29 September 2012, Martin Gräßlin wrote: > On Saturday 29 September 2012 11:48:03 Alexander Neundorf wrote: > > On Saturday 29 September 2012, André Wöbbeking wrote: > > > Hi Alex, > > > > > > On Saturday 29 September 2012 10:36:55 Alexander Neundorf wrote: > > > > I know this will cau

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

> please don't. Debian testing and the next Kubuntu release is currently at > 2.8.9 (Debian in fact at 2.8.9~rc1-1) and given that both are frozen there +1 Cheerio, Ivan signature.asc Description: This is a digitally signed message part.

Re: Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

On Saturday 29 September 2012 11:48:03 Alexander Neundorf wrote: > On Saturday 29 September 2012, André Wöbbeking wrote: > > Hi Alex, > > > > On Saturday 29 September 2012 10:36:55 Alexander Neundorf wrote: > > > I know this will cause some effort, because I guess only few > > > distributions alrea

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

Am Samstag 29 September 2012, 12:12:43 schrieb André Wöbbeking: > On Saturday 29 September 2012 11:59:04 Rolf Eike Beer wrote: > > Am Samstag 29 September 2012, 11:48:16 schrieb André Wöbbeking: > > > Hi Alex, > > > > > > On Saturday 29 September 2012 10:36:55 Alexander Neundorf wrote: > > > > I kn

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

On Saturday 29 September 2012 11:59:04 Rolf Eike Beer wrote: > Am Samstag 29 September 2012, 11:48:16 schrieb André Wöbbeking: > > Hi Alex, > > > > On Saturday 29 September 2012 10:36:55 Alexander Neundorf wrote: > > > I know this will cause some effort, because I guess only few > > > distribution

Re: Review Request: Make it possible to use QtCreator QML profiler and debugger with KDE Applications

On Friday, September 28, 2012 15:30:05 Aurélien Gâteau wrote: > > On Sept. 26, 2012, 9:16 a.m., Aurélien Gâteau wrote: > > > I pushed the plasmoidviewer changed in and filed a Qt review as well: > > > https://codereview.qt-project.org/#change,35683> > > Aaron J. Seigo wrote: > > this change was

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

Am Samstag 29 September 2012, 11:48:16 schrieb André Wöbbeking: > Hi Alex, > > On Saturday 29 September 2012 10:36:55 Alexander Neundorf wrote: > > I know this will cause some effort, because I guess only few distributions > > already come with CMake 2.8.9, but doing this once again after 2 1/2 yea

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

Hi Alex, On Saturday 29 September 2012 10:36:55 Alexander Neundorf wrote: > > I know this will cause some effort, because I guess only few distributions > already come with CMake 2.8.9, but doing this once again after 2 1/2 years > seems acceptable for me. Do you really need 2.8.9 or would 2.8.8

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

On Saturday 29 September 2012, André Wöbbeking wrote: > Hi Alex, > > On Saturday 29 September 2012 10:36:55 Alexander Neundorf wrote: > > I know this will cause some effort, because I guess only few > > distributions already come with CMake 2.8.9, but doing this once again > > after 2 1/2 years se

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/#review19565 --- konqueror/src/konqsessionmanager.cpp

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/#review19563 --- konqueror/src/konqsessionmanager.cpp

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

Am Samstag 29 September 2012, 10:36:55 schrieb Alexander Neundorf: > Hi, > > since May 2010 kdelibs requires CMake 2.6.4 for building. > > This version is quite old in the meantime, and we are missing on new CMake > features and also run into problems with some cmake modules where we have an > ow

Requiring cmake 2.8.9 for kdelibs 4.10 ?

Hi, since May 2010 kdelibs requires CMake 2.6.4 for building. This version is quite old in the meantime, and we are missing on new CMake features and also run into problems with some cmake modules where we have an own copy, which is not forward compatible to the new versions coming with CMake.

Re: Review Request: Avoid creating an empty .tbcache for bookmarks

> On Sept. 29, 2012, 8:25 a.m., David Faure wrote: > > Ah, thanks, now I understand. Please commit. The speedup idea is good too, feel free to switch to that solution. - David --- This is an automatically generated e-mail. To reply, vis

Re: Review Request: Avoid creating an empty .tbcache for bookmarks

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106563/#review19561 --- Ship it! Ah, thanks, now I understand. Please commit. - David