Re: Review Request: Fix Konqueror's MMB click to close tab option

2012-09-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106615/#review19560 --- Doesn't this break "moving a tab with MMB" then? The KTabBar m

Re: Review Request: Fix for CTRL+Tab not switcing tabs in Konqueror when the active tab is a Dolphin filemanagement part

2012-09-28 Thread David Faure
> On Sept. 28, 2012, 5:42 p.m., David Faure wrote: > > dolphin/src/kitemviews/kitemlistview.cpp, line 871 > > > > > > This strikes me as wrong. Why should this widget's event(QEvent*) > > change the default state o

Re: Review Request: Fix for CTRL+Tab not switcing tabs in Konqueror when the active tab is a Dolphin filemanagement part

2012-09-28 Thread Frank Reininghaus
> On Sept. 28, 2012, 5:42 p.m., David Faure wrote: > > dolphin/src/kitemviews/kitemlistview.cpp, line 871 > > > > > > This strikes me as wrong. Why should this widget's event(QEvent*) > > change the default state o

Re: Review Request: Avoid creating an empty .tbcache for bookmarks

2012-09-28 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106563/ --- (Updated Sept. 28, 2012, 8:30 p.m.) Review request for kdelibs and David F

Re: Review Request: Avoid creating an empty .tbcache for bookmarks

2012-09-28 Thread Stefan Brüns
> On Sept. 28, 2012, 5:32 p.m., David Faure wrote: > > Why did the original code fail? It already checks for rootIsToolbarGroup(), > > which should be true in the case you describe, right? So the saving was > > supposed to be skipped then... If a new bookmark file is created, no folder has the

Re: Possible ferris-kio hackfest at opensuse conference in October?

2012-09-28 Thread Ben Martin
On Fri, 2012-09-14 at 01:06 +0200, Jos Poortvliet wrote: > On Saturday, September 01, 2012 14:46:30 Ben Martin wrote: > > Hi, > > I'm not sure if this is the correct forum for an initial discussion... > > It has been mentioned that I might like to try to organize a one day > > hackfest in Prague

Re: Review Request: Fix for CTRL+Tab not switcing tabs in Konqueror when the active tab is a Dolphin filemanagement part

2012-09-28 Thread David Faure
> On Sept. 28, 2012, 5:42 p.m., David Faure wrote: > > dolphin/src/kitemviews/kitemlistview.cpp, line 871 > > > > > > This strikes me as wrong. Why should this widget's event(QEvent*) > > change the default state o

Re: Review Request: Fix for CTRL+Tab not switcing tabs in Konqueror when the active tab is a Dolphin filemanagement part

2012-09-28 Thread Dawit Alemayehu
> On Sept. 28, 2012, 5:42 p.m., David Faure wrote: > > dolphin/src/kitemviews/kitemlistview.cpp, line 871 > > > > > > This strikes me as wrong. Why should this widget's event(QEvent*) > > change the default state o

Re: Help your marketing team!

2012-09-28 Thread David Faure
On Tuesday 25 September 2012 19:16:43 Jos Poortvliet wrote: > Hi, > > We need your help to do better at engaging the world-wide Qt developer > community. Please answer this question: > > "what classes and components in KDELibs/Frameworks 5 do you think are most > interesting for external Qt devel

Re: Review Request: Fix for CTRL+Tab not switcing tabs in Konqueror when the active tab is a Dolphin filemanagement part

2012-09-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106569/#review19527 --- This review has been submitted with commit b3789357335cbbb100b

Re: Review Request: Fix for CTRL+Tab not switcing tabs in Konqueror when the active tab is a Dolphin filemanagement part

2012-09-28 Thread David Faure
> On Sept. 28, 2012, 5:42 p.m., David Faure wrote: > > dolphin/src/kitemviews/kitemlistview.cpp, line 871 > > > > > > This strikes me as wrong. Why should this widget's event(QEvent*) > > change the default state o

Re: Review Request: Fix for CTRL+Tab not switcing tabs in Konqueror when the active tab is a Dolphin filemanagement part

2012-09-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106569/#review19524 --- dolphin/src/kitemviews/kitemlistview.cpp

Re: Review Request: Avoid creating an empty .tbcache for bookmarks

2012-09-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106563/#review19523 --- Why did the original code fail? It already checks for rootIsToo

Re: Use of bin versus libexec

2012-09-28 Thread David Faure
On Wednesday 26 September 2012 10:42:07 Jonathan Marten wrote: > After a lot of discussion, is seems that there are some executables > (as per Thiago's list) that can be moved out. For others > (e.g. Akonadi) it is problematic because there is no standardization > on the location for a "system-wid

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-09-28 Thread Dawit Alemayehu
> On Sept. 19, 2012, 9:28 p.m., Christoph Feck wrote: > > Very nice. I think the text at the header could mention something along the > > line that you can choose which pages to restore. Would a tooltip suffice ? See the new restore dialog v2 screenshot. - Dawit

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-09-28 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/ --- (Updated Sept. 28, 2012, 4:45 p.m.) Review request for KDE Base Apps and D

Re: Review Request: Make it possible to use QtCreator QML profiler and debugger with KDE Applications

2012-09-28 Thread David Faure
> On Sept. 26, 2012, 9:16 a.m., Aurélien Gâteau wrote: > > I pushed the plasmoidviewer changed in and filed a Qt review as well: > > https://codereview.qt-project.org/#change,35683 > > Aaron J. Seigo wrote: > this change was pushed into the KDE/4.9 branch of kdelibs, but not > master. not

Re: Review Request: Make it possible to use QtCreator QML profiler and debugger with KDE Applications

2012-09-28 Thread Aurélien Gâteau
> On Sept. 26, 2012, 9:16 a.m., Aurélien Gâteau wrote: > > I pushed the plasmoidviewer changed in and filed a Qt review as well: > > https://codereview.qt-project.org/#change,35683 > > Aaron J. Seigo wrote: > this change was pushed into the KDE/4.9 branch of kdelibs, but not > master. not

Re: Add support for Persona on KDE sites?

2012-09-28 Thread Albert Astals Cid
El Divendres, 28 de setembre de 2012, a les 03:44:31, Mark va escriure: > Hi, > > -- i'm not sure where to send this mail to.. code-devel seems out of > place but i can't find anything more fitting for this question.. there > is no "websites" list -- As you said, this is off topic here https://m

Re: Add support for Persona on KDE sites?

2012-09-28 Thread Mark
On Fri, Sep 28, 2012 at 8:58 AM, Todd wrote: > On Fri, Sep 28, 2012 at 5:46 AM, Nicolás Alvarez > wrote: >> El 27/09/2012, a las 22:44, Mark escribió: >> As a second objection, it was announced *yesterday*, and I bet few people in >> this list even know anything about it at this early point. We

Re: Review Request: Make it possible to use QtCreator QML profiler and debugger with KDE Applications

2012-09-28 Thread Aaron J. Seigo
> On Sept. 26, 2012, 9:16 a.m., Aurélien Gâteau wrote: > > I pushed the plasmoidviewer changed in and filed a Qt review as well: > > https://codereview.qt-project.org/#change,35683 this change was pushed into the KDE/4.9 branch of kdelibs, but not master. not sure it should be in the 4.9 branc

Re: Review Request: Make it possible to use QtCreator QML profiler and debugger with KDE Applications

2012-09-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106527/#review19508 --- This review has been submitted with commit 8b2d3ea0c7a3d5a3f28

Re: Add support for Persona on KDE sites?

2012-09-28 Thread Todd
On Fri, Sep 28, 2012 at 5:46 AM, Nicolás Alvarez wrote: > El 27/09/2012, a las 22:44, Mark escribió: > As a second objection, it was announced *yesterday*, and I bet few people in > this list even know anything about it at this early point. We won't be early > adopters, at least not at such an ex