Re: Review Request: Fix for CTRL+Tab not switcing tabs in Konqueror when the active tab is a Dolphin filemanagement part

2012-09-25 Thread Thomas Lübking
> On Sept. 25, 2012, 9:03 p.m., Frank Reininghaus wrote: > > Thanks for analysing this issue and for the patch! > > > > We should of course let those events propagate. However, I'm a bit > > confused. The docs of QObject::eventFilter() don't mention anything about > > setting the 'accepted' st

Re: Review Request: Fix for CTRL+Tab not switcing tabs in Konqueror when the active tab is a Dolphin filemanagement part

2012-09-25 Thread Thomas Lübking
> On Sept. 25, 2012, 9:03 p.m., Frank Reininghaus wrote: > > Thanks for analysing this issue and for the patch! > > > > We should of course let those events propagate. However, I'm a bit > > confused. The docs of QObject::eventFilter() don't mention anything about > > setting the 'accepted' st

Re: Review Request: Fix for CTRL+Tab not switcing tabs in Konqueror when the active tab is a Dolphin filemanagement part

2012-09-25 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106569/#review19423 --- Thanks for analysing this issue and for the patch! We should o

Review Request: Fix for CTRL+Tab not switcing tabs in Konqueror when the active tab is a Dolphin filemanagement part

2012-09-25 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106569/ --- Review request for Dolphin and KDE Base Apps. Description --- This pa

Review Request: Avoid creating an empty .tbcache for bookmarks

2012-09-25 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106563/ --- Review request for kdelibs. Description --- Currently, an empty tbcac