Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-19 Thread Simeon Bird
> On Sept. 11, 2012, 7:39 p.m., Zack Rusin wrote: > > That's pretty bonkers. This class was never meant to be used like that. > > Holding an object in two threads is not going to work unless you make the > > entire communication synchronous effectively reducing all the > > multi-threading aspe

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-19 Thread Simeon Bird
> On Sept. 11, 2012, 7:39 p.m., Zack Rusin wrote: > > That's pretty bonkers. This class was never meant to be used like that. > > Holding an object in two threads is not going to work unless you make the > > entire communication synchronous effectively reducing all the > > multi-threading aspe

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-19 Thread Zack Rusin
> On Sept. 11, 2012, 7:39 p.m., Zack Rusin wrote: > > That's pretty bonkers. This class was never meant to be used like that. > > Holding an object in two threads is not going to work unless you make the > > entire communication synchronous effectively reducing all the > > multi-threading aspe

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-09-19 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/#review19192 --- Very nice. I think the text at the header could mention somethi

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-09-19 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/ --- (Updated Sept. 19, 2012, 9:15 p.m.) Review request for KDE Base Apps and D

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-09-19 Thread Dawit A
On Wed, Sep 19, 2012 at 2:31 AM, Rolf Eike Beer wrote: > > * If all available sessions are unselected, > > presssing "Restore Session" button will behave like "Do not Restore". > > What about just disabling "Restore Session" then? > Well, I guess that can be done as well with a bit more code.

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-19 Thread Thomas Lübking
> On Sept. 11, 2012, 7:39 p.m., Zack Rusin wrote: > > That's pretty bonkers. This class was never meant to be used like that. > > Holding an object in two threads is not going to work unless you make the > > entire communication synchronous effectively reducing all the > > multi-threading aspe

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-19 Thread Simeon Bird
> On Sept. 11, 2012, 7:39 p.m., Zack Rusin wrote: > > That's pretty bonkers. This class was never meant to be used like that. > > Holding an object in two threads is not going to work unless you make the > > entire communication synchronous effectively reducing all the > > multi-threading aspe

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-19 Thread Zack Rusin
> On Sept. 11, 2012, 7:39 p.m., Zack Rusin wrote: > > That's pretty bonkers. This class was never meant to be used like that. > > Holding an object in two threads is not going to work unless you make the > > entire communication synchronous effectively reducing all the > > multi-threading aspe

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-09-19 Thread Marco Martin
> On Sept. 16, 2012, 2 a.m., Michael Pyne wrote: > > It took me awhile to get to do it properly but I've compiled the patched > > kde-workspace and I have to say it's really impressive! No matter what I do > > I can't confuse the screen locker into showing even a flash of the desktop > > under

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-09-19 Thread Marco Martin
> On Sept. 8, 2012, 12:11 p.m., Oswald Buddenhagen wrote: > > ksmserver/screenlocker/DESIGN, line 13 > > > > > > "xembe[]ds" > > > > this sounds funny. the saver window is on top of the greeter? yes, they'r

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-09-19 Thread Marco Martin
> On Sept. 16, 2012, 2 a.m., Michael Pyne wrote: > > It took me awhile to get to do it properly but I've compiled the patched > > kde-workspace and I have to say it's really impressive! No matter what I do > > I can't confuse the screen locker into showing even a flash of the desktop > > under

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-09-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106124/ --- (Updated Sept. 19, 2012, 4:57 p.m.) Review request for KDE Runtime and Mar

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-19 Thread Simeon Bird
> On Sept. 11, 2012, 7:39 p.m., Zack Rusin wrote: > > That's pretty bonkers. This class was never meant to be used like that. > > Holding an object in two threads is not going to work unless you make the > > entire communication synchronous effectively reducing all the > > multi-threading aspe