Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-11 Thread Zack Rusin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106242/#review18866 --- That's pretty bonkers. This class was never meant to be used li

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-11 Thread Zack Rusin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106242/#review18865 --- That's pretty bonkers. This class was never meant to be used li

Re: Review Request: Allow setting a custom font list in KFontComboBox

2012-09-11 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106425/ --- (Updated Sept. 11, 2012, 7:33 p.m.) Review request for kdelibs and Chusslo

Review Request: Allow setting a custom font list in KFontComboBox

2012-09-11 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106425/ --- Review request for kdelibs and Chusslove Illich. Description --- KFon

Re: Appmenu support for KDE 4.10

2012-09-11 Thread Cédric Bellegarde
Le mardi 11 septembre 2012 17:42:17 Martin Gräßlin a écrit : > just to check, do you mean multi-screen (xrandr) or really multi-head (one > X server per screen)? I mean multi screen, sorry for mistake. -- Cédric

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-11 Thread Simeon Bird
> On Sept. 6, 2012, 12:29 p.m., David Faure wrote: > > A number of comments on the implementation, but also a more general > > comment: does it even make sense to use a Speller in multiple threads, and > > to change the language from one thread while another one is using the > > speller for s

Re: kde-baseapps dependency on kdelibs changed in 4.9 branch?

2012-09-11 Thread David Jarvie
On Tue, September 11, 2012 4:33 pm, Andreas Pakulat wrote: > Hi, > > On Tue, Sep 11, 2012 at 4:42 PM, Dawit A wrote: >> >> >> On Tue, Sep 11, 2012 at 10:08 AM, Albert Astals Cid >> wrote: >>> >>> El Dimarts, 11 de setembre de 2012, a les 09:51:22, Dawit A va >>> escriure: >>> > On Tue, Sep 11, 20

Re: Appmenu support for KDE 4.10

2012-09-11 Thread Martin Gräßlin
On Tuesday 11 September 2012 15:24:44 Cedric Bellegarde wrote: > Hello, > > since last mail, many changes. > > > > Kded-appmenu: > https://projects.kde.org/projects/kdereview/kded-appmenu > > - DBus interface allowing KWin to ask for applications menu to popup > - New Top menubar: >

Re: kde-baseapps dependency on kdelibs changed in 4.9 branch?

2012-09-11 Thread Andreas Pakulat
Hi, On Tue, Sep 11, 2012 at 4:42 PM, Dawit A wrote: > > > On Tue, Sep 11, 2012 at 10:08 AM, Albert Astals Cid wrote: >> >> El Dimarts, 11 de setembre de 2012, a les 09:51:22, Dawit A va escriure: >> > On Tue, Sep 11, 2012 at 6:27 AM, Albert Astals Cid >> > wrote: >> > > It seems that the >> > >

Re: kde-baseapps dependency on kdelibs changed in 4.9 branch?

2012-09-11 Thread Albert Astals Cid
El Dimarts, 11 de setembre de 2012, a les 10:42:09, Dawit A va escriure: > On Tue, Sep 11, 2012 at 10:08 AM, Albert Astals Cid wrote: > > El Dimarts, 11 de setembre de 2012, a les 09:51:22, Dawit A va escriure: > > > On Tue, Sep 11, 2012 at 6:27 AM, Albert Astals Cid > > > > wrote: > > > > It se

Re: kde-baseapps dependency on kdelibs changed in 4.9 branch?

2012-09-11 Thread Dawit A
On Tue, Sep 11, 2012 at 10:08 AM, Albert Astals Cid wrote: > El Dimarts, 11 de setembre de 2012, a les 09:51:22, Dawit A va escriure: > > On Tue, Sep 11, 2012 at 6:27 AM, Albert Astals Cid > wrote: > > > It seems that the > > > > > > set(KDE_MIN_VERSION "4.7.97") > > > > Was that done intentiona

Appmenu support for KDE 4.10

2012-09-11 Thread Cedric Bellegarde
Hello, since last mail, many changes. Kded-appmenu: https://projects.kde.org/projects/kdereview/kded-appmenu - DBus interface allowing KWin to ask for applications menu to popup - New Top menubar: * Auto hide with glow effect for easy access * Multihead: me

Re: kde-baseapps dependency on kdelibs changed in 4.9 branch?

2012-09-11 Thread Albert Astals Cid
El Dimarts, 11 de setembre de 2012, a les 09:51:22, Dawit A va escriure: > On Tue, Sep 11, 2012 at 6:27 AM, Albert Astals Cid wrote: > > It seems that the > > > > set(KDE_MIN_VERSION "4.7.97") > > Was that done intentionally or was it forgotten to be updated for the KDE > 4.9 release ? If the fo

Re: kde-baseapps dependency on kdelibs changed in 4.9 branch?

2012-09-11 Thread Dawit A
On Tue, Sep 11, 2012 at 6:27 AM, Albert Astals Cid wrote: > It seems that the > > set(KDE_MIN_VERSION "4.7.97") > Was that done intentionally or was it forgotten to be updated for the KDE 4.9 release ? If the former, then have we now started guaranteeing forward compatibility too ? > > that kd

Re: Broken build of KDE Base Apps and unauthorized increase in dependency

2012-09-11 Thread Dawit A
On Tue, Sep 11, 2012 at 6:22 AM, Ben Cooksley wrote: > Hi Dawit, > > It has come to my attention that since commit > 603a93268efb9d09f8c6255907f46928c651fdbd to kde-baseapps master, the > build for it has been broken. > This is due to it depending on new features, present only in the KDE/4.9 > br

Re: kde-baseapps dependency on kdelibs changed in 4.9 branch?

2012-09-11 Thread Albert Astals Cid
El Dimarts, 11 de setembre de 2012, a les 12:49:47, Frank Reininghaus va escriure: > Hi, > > 2012/9/11 Albert Astals Cid: > > It seems that the > > > > set(KDE_MIN_VERSION "4.7.97") > > > > that kde-baseapps mentions as required kdelibs version is not true > > anymore[1] and you now need unrele

Re: kde-baseapps dependency on kdelibs changed in 4.9 branch?

2012-09-11 Thread Frank Reininghaus
Hi, 2012/9/11 Albert Astals Cid: > It seems that the > > set(KDE_MIN_VERSION "4.7.97") > > that kde-baseapps mentions as required kdelibs version is not true anymore[1] > and you now need unreleased kdelibs KDE/4.9 to build kde-baseapps KDE/4.9 > > Are we OK with such a dependency change? > > Chee

kde-baseapps dependency on kdelibs changed in 4.9 branch?

2012-09-11 Thread Albert Astals Cid
It seems that the set(KDE_MIN_VERSION "4.7.97") that kde-baseapps mentions as required kdelibs version is not true anymore[1] and you now need unreleased kdelibs KDE/4.9 to build kde-baseapps KDE/4.9 Are we OK with such a dependency change? Cheers, Albert [1] http://quickgit.kde.org/index.p

Broken build of KDE Base Apps and unauthorized increase in dependency

2012-09-11 Thread Ben Cooksley
Hi Dawit, It has come to my attention that since commit 603a93268efb9d09f8c6255907f46928c651fdbd to kde-baseapps master, the build for it has been broken. This is due to it depending on new features, present only in the KDE/4.9 branch. This is problematic because: - kde-baseapps depends upon a mi

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-11 Thread Simeon Bird
> On Sept. 6, 2012, 12:29 p.m., David Faure wrote: > > A number of comments on the implementation, but also a more general > > comment: does it even make sense to use a Speller in multiple threads, and > > to change the language from one thread while another one is using the > > speller for s