Re: Review Request: Hide empty additional information lines in icons view mode

> On Sept. 1, 2012, 4:25 p.m., Frank Reininghaus wrote: > > dolphin/src/kitemviews/kstandarditemlistwidget.cpp, line 990 > > > > > > I would write ... - (additionalRolesCount - emptyRolesCount) here. That > > makes

Re: Review Request: add kimgio WebP image format plugin

> On Sept. 1, 2012, 1:20 p.m., Christoph Feck wrote: > > kimgio/webp.cpp, line 49 > > > > > > Needs to check image.isValid() before writing data via scanLine() > > pointers. The allocation may fail because of too la

Re: Review Request: Do not save window size from special (no toolbar) poup windows

> On Aug. 3, 2012, 10:43 p.m., David Faure wrote: > > How does this relate to the call to > > mainWindow->resetAutoSaveSettings(); // Don't autosave > > in KonqMainWindow::slotCreateNewWindow? It's kind of the same idea. Well, > > in fact no, it's better ;) > > > > You're only setting "sav

Re: Review Request: add kimgio WebP image format plugin

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106300/ --- (Updated Sept. 1, 2012, 9:23 p.m.) Review request for kdelibs. Changes -

Re: Review Request: add kimgio WebP image format plugin

> On Sept. 1, 2012, 1:20 p.m., Christoph Feck wrote: > > kimgio/webp.cpp, line 5 > > > > > > We need to be more verbose here, it has to state the versions, and a > > pointer where to get the license text. Please chec

Re: Review Request: Implementation of KParts listing filter extension for Dolphin

> On Sept. 1, 2012, 12:03 p.m., Frank Reininghaus wrote: > > First of all, thanks for the patch! > > > > I was not aware of any "constant breakage of the Konqueror directory > > filtering plugin once Konqueror was switched to use Dolphin's part for > > filemanagement", and I think neither was

Re: Review Request: Hide empty additional information lines in icons view mode

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106304/ --- (Updated Sept. 1, 2012, 12:17 p.m.) Review request for Dolphin and KDE Bas

Re: Review Request: Hide empty additional information lines in icons view mode

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106304/ --- (Updated Sept. 1, 2012, 12:17 p.m.) Review request for Dolphin and KDE Bas

Possible ferris-kio hackfest at opensuse conference in October?

Hi, I'm not sure if this is the correct forum for an initial discussion... It has been mentioned that I might like to try to organize a one day hackfest in Prague in October [1] with the aim of trying to either make libferris work together with kio or just swap cool features between VFS developer

Re: Review Request: Implementation of KParts listing filter extension for Dolphin

> On Sept. 1, 2012, 12:03 p.m., Frank Reininghaus wrote: > > First of all, thanks for the patch! > > > > I was not aware of any "constant breakage of the Konqueror directory > > filtering plugin once Konqueror was switched to use Dolphin's part for > > filemanagement", and I think neither was

Re: Review Request: Hide empty additional information lines in icons view mode

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106304/#review18407 --- Thanks for the patch, looks good! I have two small comments on

Re: Review Request: Implementation of KParts listing filter extension for Dolphin

> On Sept. 1, 2012, 12:03 p.m., Frank Reininghaus wrote: > > First of all, thanks for the patch! > > > > I was not aware of any "constant breakage of the Konqueror directory > > filtering plugin once Konqueror was switched to use Dolphin's part for > > filemanagement", and I think neither was

Re: Review Request: Config cleanup on removeActivity

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106097/ --- (Updated Sept. 1, 2012, 3:44 p.m.) Review request for KDE Runtime and Plas

Re: Review Request: add kimgio WebP image format plugin

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106300/#review18386 --- Nice work, much requested. See issues below. kimgio/webp.cpp

Re: Review Request: Implementation of KParts listing filter extension for Dolphin

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106289/#review18384 --- First of all, thanks for the patch! I was not aware of any "co

Re: new WebP image plugin (kimgio) and cmake question

Hi Martin, On Saturday, 2012-09-01, Martin Koller wrote: > Hi all, > > I've implemented a new kimgio plugin for the WebP image format. > read/write with variable quality is supported. > > I hope you can help me with the following questions: > - how do I have to change the CMakeLists.txt file, so

new WebP image plugin (kimgio) and cmake question

Hi all, I've implemented a new kimgio plugin for the WebP image format. read/write with variable quality is supported. I hope you can help me with the following questions: - how do I have to change the CMakeLists.txt file, so that this new plugin is optional depending on if the libwebp headers

Review Request: add kimgio WebP image format plugin

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106300/ --- Review request for kdelibs. Description --- This patch adds support f