Re: Review Request: Config cleanup on removeActivity

2012-08-26 Thread Ivan Čukić
> On Aug. 27, 2012, 12:42 a.m., Lamarque Vieira Souza wrote: > > Ship It! Which branch is this, since it is not master as specified? - Ivan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r

Review Request: Add spinlocks lock type, based on GCC intrisincs

2012-08-26 Thread Vadim Zhukov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106224/ --- Review request for kdelibs and Michael Pyne. Description --- Add simp

Re: Review Request: Mutex cleanup in KSharedDataCache

2012-08-26 Thread Vadim Zhukov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106221/ --- (Updated Aug. 26, 2012, 7:02 p.m.) Review request for kdelibs and Michael

Review Request: Mutex cleanup in KSharedDataCache

2012-08-26 Thread Vadim Zhukov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106221/ --- Review request for kdelibs and Michael Pyne. Description --- - Remove

Review Request: Move checks for locking primitives in KSharedDataCache to CMake

2012-08-26 Thread Vadim Zhukov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106174/ --- Review request for kdelibs and Michael Pyne. Description --- This pat

Re: Review Request: Focus goes to location bar when opening link in new tab in foreground

2012-08-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105984/#review18070 --- This review has been submitted with commit a2ae8003352442efdb5

Re: Review Request: Config cleanup on removeActivity

2012-08-26 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106097/#review18065 --- Ship it! Ship It! - Lamarque Vieira Souza On Aug. 20, 2012,

Re: Review Request: Focus goes to location bar when opening link in new tab in foreground

2012-08-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105984/#review18063 --- This review has been submitted with commit 55c0f6baf97a07d1ee0

Re: Review Request: Mutex cleanup in KSharedDataCache

2012-08-26 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106221/#review18056 --- A few comments, but most of the changes are OK (though they wil

Re: Review Request: Move checks for locking primitives in KSharedDataCache to CMake

2012-08-26 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106174/#review18055 --- I've looked over everything and didn't see anything I didn't li

Re: Review Request: Only show the screen config changed message once.

2012-08-26 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106212/#review18029 --- That warning is there to remind the maintainer to re-factor tha

Re: Review Request: elide completion entries in the middle in konq-address completion list

2012-08-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106183/#review18027 --- This review has been submitted with commit 265b1a51187a006dd59

Re: Review Request: konqueror: strip new line character from URL on paste automatically

2012-08-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106184/#review18026 --- This review has been submitted with commit 4a6e5ee19b03f1a802d

Re: Review Request: elide completion entries in the middle in konq-address completion list

2012-08-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106183/#review18025 --- This review has been submitted with commit dffa8b2aeeb2e43984e

Re: Review Request: konqueror: strip new line character from URL on paste automatically

2012-08-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106184/#review18024 --- This review has been submitted with commit 38fda3bf750d71266a1

Re: Review Request: konqueror: strip new line character from URL on paste automatically

2012-08-26 Thread Martin Koller
> On Aug. 25, 2012, 10:15 p.m., David Faure wrote: > > Looks good. I'm not sure where the need for ParagraphSeparator and > > LineSeparator comes from though, do websites actually use that? I found these two in QChar and thought it might happen that the clipboard contains not \n but one of the

Review Request: Only show the screen config changed message once.

2012-08-26 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106212/ --- Review request for KDE Base Apps and Alex Fiestas. Description --- Th