Re: Review Request: print-manager on kdereview

2012-08-25 Thread Daniel Nicoletti
2012/8/25 Christoph Feck : > On Saturday 25 August 2012 04:29:19 Daniel Nicoletti wrote: >> 2012/8/23 Christoph Feck : >> > On Wednesday 22 August 2012 21:39:11 Daniel Nicoletti wrote: >> Well CUPS has it's own API for authorization, which is why I >> avoided the polkit solution s-c-p-gnome now use

Re: Review Request: Focus goes to location bar when opening link in new tab in foreground

2012-08-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105984/#review18006 --- Ship it! Looks good, assuming you tested that it doesn't reint

Re: Review Request: konqueror: strip new line character from URL on paste automatically

2012-08-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106184/#review18003 --- Ship it! Looks good. I'm not sure where the need for Paragraph

Re: Review Request: elide completion entries in the middle in konq-address completion list

2012-08-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106183/#review18002 --- Ship it! Ship It! - David Faure On Aug. 25, 2012, 7:03 p.m.

Re: Review Request: konqueror: strip new line character from URL on paste automatically

2012-08-25 Thread Martin Koller
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106184/ --- (Updated Aug. 25, 2012, 7:56 p.m.) Review request for KDE Base Apps and Da

Re: Review Request: konqueror: strip new line character from URL on paste automatically

2012-08-25 Thread Rolf Eike Beer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106184/#review17997 --- konqueror/src/konqcombo.cpp

Re: Review Request: Focus goes to location bar when opening link in new tab in foreground

2012-08-25 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105984/ --- (Updated Aug. 25, 2012, 7:41 p.m.) Review request for KDE Base Apps and Da

Review Request: konqueror: strip new line character from URL on paste automatically

2012-08-25 Thread Martin Koller
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106184/ --- Review request for KDE Base Apps and David Faure. Description --- Thi

Review Request: elide completion entries in the middle in konq-address completion list

2012-08-25 Thread Martin Koller
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106183/ --- Review request for KDE Base Apps and David Faure. Description --- Cur

Re: Review Request: print-manager on kdereview

2012-08-25 Thread Christoph Feck
On Saturday 25 August 2012 04:29:19 Daniel Nicoletti wrote: > 2012/8/23 Christoph Feck : > > On Wednesday 22 August 2012 21:39:11 Daniel Nicoletti wrote: > >> two years ago I started print-manager, at that time > >> I was using Debian which is affected by this bug: > >> https://bugs.kde.org/show_bu

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets

2012-08-25 Thread Frank Reininghaus
> On Aug. 23, 2012, 1:38 p.m., Frank Reininghaus wrote: > > Sorry for my late response, I was away for a couple of days. > > > > How can I test your patch? I think that only applying the Dolphin patch is > > not sufficient, so I'd like to know what else I need to download+build. I'd > > like t

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-08-25 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106124/#review17977 --- it would be good if you could present a "process model", so i c

Re: Review Request: Focus goes to location bar when opening link in new tab in foreground

2012-08-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105984/#review17978 --- This is going into the right direction. If you move your new co