Re: Review Request: Dolphin reports open locations to the activity manager

2012-08-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105973/#review17426 --- This review has been submitted with commit 50d9937eadf9306d03b

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets

2012-08-14 Thread Amandeep Singh
> On Aug. 14, 2012, 2:43 p.m., Frank Reininghaus wrote: > > Thanks for the explanations! > > > > Amandeep, could you address all issues raised here and either comment on > > them or fix them in an updated patch? Just to make sure that the patch gets > > easier to read when we continue the revi

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets

2012-08-14 Thread Amandeep Singh
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105972/ --- (Updated Aug. 14, 2012, 3:01 p.m.) Review request for Dolphin, KDE Base Ap

Re: Review Request: Fix hang in kcm_useraccount

2012-08-14 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105895/ --- (Updated Aug. 14, 2012, 12:33 p.m.) Review request for KDE Base Apps. Ch

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets

2012-08-14 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105972/#review17396 --- Thanks for the quick update, looks much better now! I couldn't

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets

2012-08-14 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105972/#review17394 --- Thanks for the explanations! Amandeep, could you address all i

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets

2012-08-14 Thread Frederik Gladhorn
> On Aug. 13, 2012, 2:50 p.m., Frank Reininghaus wrote: > > dolphin/src/kitemviews/kitemlistviewaccessible.h, line 16 > > > > > > On the other hand, I see lots of QModelIndex and friends here, which is > > something

Re: Review Request: Dolphin reports open locations to the activity manager

2012-08-14 Thread Ivan Čukić
> On Aug. 14, 2012, 10:39 a.m., Frank Reininghaus wrote: > > OK, thanks for the explanation! If there is a way to opt-out, this can go > > into master from my point of view. > > > > I've noticed a possible problem though: the CMake message about kactivities > > in your patch says "STRONGLY_REC

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets

2012-08-14 Thread Frank Reininghaus
> On Aug. 13, 2012, 2:50 p.m., Frank Reininghaus wrote: > > dolphin/src/kitemviews/kitemlistviewaccessible.cpp, line 67 > > > > > > I think this will fail when grouping is enabled. > > Frederik Gladhorn wrote: >

Re: Review Request: Dolphin reports open locations to the activity manager

2012-08-14 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105973/#review17365 --- OK, thanks for the explanation! If there is a way to opt-out, t