Re: QtScript considered dangerous

2012-08-13 Thread Laszlo Papp
> > Yeah, I think something along the lines of "the following weeks". Like in > 2-4 > weeks or so as far as I heard. > Indeed, here is the proof: http://lists.qt-project.org/pipermail/development/2012-August/005571.html Laszlo

Re: QtScript considered dangerous

2012-08-13 Thread Aleix Pol
On Mon, Aug 13, 2012 at 3:44 PM, Milian Wolff wrote: > Hey all, > > I just wanted to notify you that a fix to this notorious QtScript bug was > released in time for 4.8.3. For now, I can retract my statement that QtScript > should be considered dangerous :) So Kate can stick to QtScript and I don'

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets

2012-08-13 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105972/#review17304 --- dolphin/src/kitemviews/kitemlistcontainer.cpp

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets

2012-08-13 Thread Frederik Gladhorn
> On Aug. 13, 2012, 2:50 p.m., Frank Reininghaus wrote: > > dolphin/src/kitemviews/kitemlistviewaccessible.h, line 16 > > > > > > On the other hand, I see lots of QModelIndex and friends here, which is > > something

Re: Review Request: kjs: Implement JSON.stringify

2012-08-13 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105057/ --- (Updated Aug. 13, 2012, 5:36 p.m.) Review request for kdelibs. Changes -

Re: Review Request: kjs: Implement JSON.stringify

2012-08-13 Thread Bernd Buschinski
> On Aug. 12, 2012, 3:42 p.m., Maks Orlovich wrote: > > kjs/jsonstringify.cpp, line 102 > > > > > > Resetting m_state, m_rootIsUndefined here might be a good defensive > > move (just in case stringify starts gettin

Re: QtScript considered dangerous

2012-08-13 Thread Milian Wolff
On Monday 13 August 2012 17:34:12 Aleix Pol wrote: > On Mon, Aug 13, 2012 at 3:44 PM, Milian Wolff wrote: > > Hey all, > > > > I just wanted to notify you that a fix to this notorious QtScript bug was > > released in time for 4.8.3. For now, I can retract my statement that > > QtScript should be

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets

2012-08-13 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105972/#review17313 --- There might be a couple more things than those that I've pointe

Re: QtScript considered dangerous

2012-08-13 Thread Dominik Haumann
On Monday, August 13, 2012 15:44:43 Milian Wolff wrote: > Hey all, > > I just wanted to notify you that a fix to this notorious QtScript bug was > released in time for 4.8.3. For now, I can retract my statement that > QtScript should be considered dangerous :) So Kate can stick to QtScript > and I

Re: KIO::UDSEntry and URL encoding

2012-08-13 Thread Thiago Macieira
On segunda-feira, 13 de agosto de 2012 14.28.02, Martin Koller wrote: > Hi, > (using 4.9.0) > > when using konqueror and typing "man:" it starts to list possible entries > which the kio_man slave generates. However, konqueror displays percent > encoded URLs, e.g. "man:%281%29/" instead of "man:(1)

Re: QtScript considered dangerous

2012-08-13 Thread Milian Wolff
Hey all, I just wanted to notify you that a fix to this notorious QtScript bug was released in time for 4.8.3. For now, I can retract my statement that QtScript should be considered dangerous :) So Kate can stick to QtScript and I don't have to port it to KJS at the upcoming hack sprint! See a

Re: Review Request: Dolphin reports open locations to the activity manager

2012-08-13 Thread Ivan Čukić
> On Aug. 12, 2012, 9:05 p.m., Frank Reininghaus wrote: > > Thanks for the patch! > > > > I'd say that it looks good code-wise (can't say much about the CMake stuff > > though, my CMake knowledge is rather limited). > > > > However, I don't think that we should keep track of the locations that

KIO::UDSEntry and URL encoding

2012-08-13 Thread Martin Koller
Hi, (using 4.9.0) when using konqueror and typing "man:" it starts to list possible entries which the kio_man slave generates. However, konqueror displays percent encoded URLs, e.g. "man:%281%29/" instead of "man:(1)/" kio_man creates the KIO::UDSEntry as follows: QString name = "ma

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets

2012-08-13 Thread José Millán Soto
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105972/#review17299 --- Hi, thanks for the patch! dolphin/src/kitemviews/kitemlistcon

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets

2012-08-13 Thread Amandeep Singh
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105972/ --- (Updated Aug. 13, 2012, 5:50 a.m.) Review request for Dolphin, KDE Base Ap

Re: Review Request: Dolphin reports open locations to the activity manager

2012-08-13 Thread Ivan Čukić
> On Aug. 12, 2012, 9:05 p.m., Frank Reininghaus wrote: > > Thanks for the patch! > > > > I'd say that it looks good code-wise (can't say much about the CMake stuff > > though, my CMake knowledge is rather limited). > > > > However, I don't think that we should keep track of the locations that