Re: Review Request: Fix hang in kcm_useraccount

2012-08-10 Thread Rolf Eike Beer
Am Samstag, 11. August 2012, 01:11:52 schrieb Michael Palimaka: > On 2012-08-11 01:02, Rolf Eike Beer wrote: > > Am Samstag 11 August 2012, 00:11:37 schrieb Michael Palimaka: > >> So you are saying: > >> > >> - readAll clears the buffer > >> - readLine unconditionally calls readAll > >> - readLine

Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets

2012-08-10 Thread Amandeep Singh
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105972/ --- Review request for KDE Base Apps and KDE Accessibility. Description --

Re: Review Request: Fix hang in kcm_useraccount

2012-08-10 Thread Michael Palimaka
On 2012-08-11 01:02, Rolf Eike Beer wrote: Am Samstag 11 August 2012, 00:11:37 schrieb Michael Palimaka: So you are saying: - readAll clears the buffer - readLine unconditionally calls readAll - readLine may be called multiple times to read multiple lines Is that correct? That's how the code

Re: Review Request: Fix hang in kcm_useraccount

2012-08-10 Thread Michael Palimaka
On 2012-08-10 02:46, Rolf Eike Beer wrote: Ehm, no. readLine() unconditionally calls readAll(). But that will also clear the input buffer of the process object. So there is nothing left to read on the next readLine() or readAll() call. Eike So you are saying: - readAll clears the buffer - rea

Re: Review Request: Fix hang in kcm_useraccount

2012-08-10 Thread Rolf Eike Beer
Am Samstag 11 August 2012, 00:11:37 schrieb Michael Palimaka: > On 2012-08-10 02:46, Rolf Eike Beer wrote: > > Ehm, no. readLine() unconditionally calls readAll(). But that will also > > clear the input buffer of the process object. So there is nothing left to > > read on the next readLine() or rea

Re: C++11 requirement?

2012-08-10 Thread Chusslove Illich
>> [: Chusslove Illich :] >> I too would be interested in variadic templates, would this be acceptable >> in a tier 2 KF component (i18n)? MSVC (even the upcoming one) doesn't >> support that. > > [: Christoph Cullmann :] > Then there is no longer Windows support. Ook, then, I retract the wish. I

Re: C++11 requirement?

2012-08-10 Thread Ivan Čukić
>> a tier 2 KF component (i18n)? To reiterate: The decision was that current libraries can not increase the dependency. For KF5, the requirement (as far as I understood it) will be in the end that of Qt 5. > Then there is no longer Windows support. > MSVC (even the upcoming one) doesn't support t

Re: C++11 requirement?

2012-08-10 Thread Christoph Cullmann
> >> [: Stephen Kelly :] > >> I learned recently that central parts of KDE Platform 4 are > >> depending on > >> C++11 features: > >> > >> http://ivan.fomentgroup.org/blog/2012/08/02/module-giveaway-sessions-and-activities-updated/ > > > > [: Ivan Cukic :] > > There was a discussion regarding this.

Re: C++11 requirement?

2012-08-10 Thread Chusslove Illich
>> [: Stephen Kelly :] >> I learned recently that central parts of KDE Platform 4 are depending on >> C++11 features: >> >> http://ivan.fomentgroup.org/blog/2012/08/02/module-giveaway-sessions-and-activities-updated/ > > [: Ivan Cukic :] > There was a discussion regarding this. This is not abour Pl