Re: Review Request: Make KModifierKeyInfoProvider inherit QObject, rather than QWidget

2012-08-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105920/#review17175 --- This review has been submitted with commit e9b1714f408f708237c

Re: Review Request: Fix hang in kcm_useraccount

2012-08-09 Thread Rolf Eike Beer
Am Donnerstag, 9. August 2012, 20:24:26 schrieb Michael Palimaka: > On 2012-08-09 19:57, Rolf Eike Beer wrote: > > Ehm, no. If you don't unreadLine() but readLine() you will now discard > > the data previously read in by readAll() and only have the new input > > from readLine() which will be empty

Re: Re: Review Request: Fix Calculator keyboard key not working

2012-08-09 Thread Jos Poortvliet
On Tuesday, August 07, 2012 19:31:31 Thomas Lübking wrote: > > On Aug. 7, 2012, 6:15 p.m., Lamarque Vieira Souza wrote: > > > kdeui/util/kkeyserver_x11.cpp, line 358 > > > > > e358>> > > > > I think this will break calc

Re: Review Request: Make "New File -> Text File" create empty file

2012-08-09 Thread Christoph Feck
> On Aug. 7, 2012, 11 a.m., Christoph Feck wrote: > > I tried again on today's master with the two characters removed from the > > template file, and again it creates "Test.doc" when trying to create a file > > "Test". > > > > Note that I did not enter "Test.txt", but only "Test". > > > > So

Re: Review Request: Fix hang in kcm_useraccount

2012-08-09 Thread Michael Palimaka
On 2012-08-09 19:57, Rolf Eike Beer wrote: Ehm, no. If you don't unreadLine() but readLine() you will now discard the data previously read in by readAll() and only have the new input from readLine() which will be empty for sure. The case I'm describing here is: the process already exited and has

letter from digia

2012-08-09 Thread Lydia Pintscher
Hi folks, as you might have heard digia is acquiring Qt. The board received a letter that we were asked to distribute to the community. It's attached. A dot story will hopefully follow soon. Cheers Lydia -- Lydia Pintscher - http://about.me/lydia.pintscher KDE Community Working Group / KDE e.V

Re: Review Request: Make KModifierKeyInfoProvider inherit QObject, rather than QWidget

2012-08-09 Thread David Faure
> On Aug. 8, 2012, 1:08 p.m., Aurélien Gâteau wrote: > > The reason it was not applied is probably because I forgot to submit it :) > > Thanks for taking care of doing it. > > > > If I am not mistaken the reason KModifierKeyInfoProvider inherits from > > QWidget is historical: it used to be ne

Re: Review Request: Make KModifierKeyInfoProvider inherit QObject, rather than QWidget

2012-08-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105920/#review17144 --- Ship it! - David Faure On Aug. 7, 2012, 9:21 p.m., Frank Rei

Re: Review Request: Fix Calculator keyboard key not working

2012-08-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105909/#review17142 --- Looks like a workaround. More details posted in the bug report

Re: Review Request: Fix hang in kcm_useraccount

2012-08-09 Thread Rolf Eike Beer
Am 2012-08-09 09:41, schrieb Michael Palimaka: On 2012-08-09 17:06, Rolf Eike Beer wrote: Just one thing: you do unreadLine(line), which adds "true" as second argument, so a needless newline is appended that wasn't there before (and which causes a deep copy of all that stuff for nothing). So

Re: Review Request: Fix hang in kcm_useraccount

2012-08-09 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105895/ --- (Updated Aug. 9, 2012, 7:50 a.m.) Review request for KDE Base Apps. Chan

Re: Review Request: Fix hang in kcm_useraccount

2012-08-09 Thread Michael Palimaka
On 2012-08-09 17:06, Rolf Eike Beer wrote: You have a nice way trying to say I'm a moron. Thank you. ;) I am not trying to say that! I do not pretend to be any expert, and and the more eyes the better. Your patch isn't technically ideal as it does the same operation on data multiple times. B

Re: Review Request: Fix hang in kcm_useraccount

2012-08-09 Thread Michael Palimaka
On 2012-08-09 02:59, Rolf Eike Beer wrote: Now we have the following situation in case the program has exited (if not the behavior is unchanged): -we read in one line, if it is empty we break. What happens if the first line of output is empty and correct output comes later? That's why I origina

Re: Review Request: Fix hang in kcm_useraccount

2012-08-09 Thread Rolf Eike Beer
Michael Palimaka wrote: > On 2012-08-09 02:59, Rolf Eike Beer wrote: > > Now we have the following situation in case the program has exited (if not > > the behavior is unchanged): > > > > -we read in one line, if it is empty we break. What happens if the first > > line of output is empty and corre