Re: Review Request: Fix hang in kcm_useraccount

2012-08-08 Thread Rolf Eike Beer
Am Mittwoch 08 August 2012, 07:59:07 schrieb Michael Palimaka: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105895/ > --- > > (U

Re: Review Request: Make KModifierKeyInfoProvider inherit QObject, rather than QWidget

2012-08-08 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105920/#review17101 --- The reason it was not applied is probably because I forgot to s

Re: Review Request: Fix hang in kcm_useraccount

2012-08-08 Thread Michael Palimaka
> On Aug. 7, 2012, 7:26 a.m., Oswald Buddenhagen wrote: > > did you look at the changes i did in kdelibs/kdesu a while ago? this should > > probably go in line with them (i didn't check whether it already does). > > Michael Palimaka wrote: > What should I be looking for? > > Oswald Buddenh

Re: Review Request: Fix hang in kcm_useraccount

2012-08-08 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105895/ --- (Updated Aug. 8, 2012, 7:59 a.m.) Review request for KDE Base Apps. Chan

Re: Review Request: Fix hang in kcm_useraccount

2012-08-08 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105895/ --- (Updated Aug. 7, 2012, 6:52 p.m.) Review request for KDE Base Apps. Chan

Re: Review Request: Fix Calculator keyboard key not working

2012-08-08 Thread Kai Uwe Broulik
> On Aug. 7, 2012, 6:15 p.m., Lamarque Vieira Souza wrote: > > kdeui/util/kkeyserver_x11.cpp, line 358 > > > > > > I think this will break calculator key for other users. This change > > also does not make sense, K