Re: Review Request: Fix hang in kcm_useraccount

> On Aug. 7, 2012, 7:26 a.m., Oswald Buddenhagen wrote: > > did you look at the changes i did in kdelibs/kdesu a while ago? this should > > probably go in line with them (i didn't check whether it already does). > > Michael Palimaka wrote: > What should I be looking for? everything. it's n

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review17085 --- This review has been submitted with commit c578e8804ee6505ea28

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review17084 --- This review has been submitted with commit 0af24b2dcd32fd74f1a

Review Request: Make KModifierKeyInfoProvider inherit QObject, rather than QWidget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105920/ --- Review request for kdelibs, Michael Leupold and Aurélien Gâteau. Descripti

Re: [PATCH] KSecretsService Collection and Item property names

Hello Jakub, Kevin, Thanks for the patch. I'm now working on it. I'll also adjuste the client API then I'll commit all the changes asap for me. Cheers, Valentin On 08/07/2012 03:50 PM, Kevin Krammer wrote: Hi Jakub, thank you caring about our client implementation. The macro usage looks a b

Re: Review Request: Fix hang in kcm_useraccount

Michael Palimaka wrote: Switching to mail as reviewboard is once again playing tricks at me or my Konqueror. > Changes > --- > > Restore original diff, and add comments explaining it. That comment would explain what you are doing, but the idea was to explain _why_ you are doing it. But s

Re: Review Request: Fix Calculator keyboard key not working

> On Aug. 7, 2012, 6:15 p.m., Lamarque Vieira Souza wrote: > > kdeui/util/kkeyserver_x11.cpp, line 358 > > > > > > I think this will break calculator key for other users. This change > > also does not make sense, K

Re: Review Request: Fix Calculator keyboard key not working

> On Aug. 7, 2012, 6:15 p.m., Lamarque Vieira Souza wrote: > > kdeui/util/kkeyserver_x11.cpp, line 358 > > > > > > I think this will break calculator key for other users. This change > > also does not make sense, K

Re: Review Request: Fix Calculator keyboard key not working

> On Aug. 7, 2012, 6:15 p.m., Lamarque Vieira Souza wrote: > > kdeui/util/kkeyserver_x11.cpp, line 358 > > > > > > I think this will break calculator key for other users. This change > > also does not make sense, K

Re: Review Request: Fix hang in kcm_useraccount

> On Aug. 6, 2012, 4:55 p.m., Rolf Eike Beer wrote: > > kdepasswd/kcm/chfnprocess.cpp, line 68 > > > > > > Why unread the line if you read it again just 3 lines below? Why not > > just put the readline() below in an

Re: Review Request: Fix Calculator keyboard key not working

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105909/#review17061 --- kdeui/util/kkeyserver_x11.cpp

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review17060 --- This review has been submitted with commit b8e506743429fa28694

Review Request: Fix Calculator keyboard key not working

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105909/ --- Review request for kdelibs. Description --- This little patch fixes t

Re: Review Request: Support for GRUB2 submenus

> On Aug. 7, 2012, 4:42 p.m., Oswald Buddenhagen wrote: > > Ship It! > > Konstantinos Smanis wrote: > What should I commit to which branches? 4.8.5 is out, so any commits in > the 4.8.x branch won't ever be officially released. I guess the kdm part can > affect all the rest (4.9.x, master)

Re: Review Request: Support for GRUB2 submenus

> On Aug. 7, 2012, 4:42 p.m., Oswald Buddenhagen wrote: > > Ship It! What should I commit to which branches? 4.8.5 is out, so any commits in the 4.8.x branch won't ever be officially released. I guess the kdm part can affect all the rest (4.9.x, master) branches. - Konstantinos ---

Call for Projects: University Collaboration in Toulouse

Hello all, I have very good news, if everything goes well, I will have the opportunity to setup student projects at the University in collaboration with KDE again! We had a one year hiatus, and I have to admit I miss those projects dearly, so it'd be nice to resume the effort... I'd quite some wor

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review17055 --- Ship it! Ship It! - Oswald Buddenhagen On Aug. 7, 2012, 3:5

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated Aug. 7, 2012, 3:56 p.m.) Review request for KDE Runtime and Oswal

Re: Review Request: Support for GRUB2 submenus

> On Aug. 7, 2012, 1:25 p.m., Oswald Buddenhagen wrote: > > kdm/backend/util.c, line 205 > > > > > > len isn't actually used in that loop > > Konstantinos Smanis wrote: > It is used, it counts the occurences o

Re: [PATCH] KSecretsService Collection and Item property names

Hi Jakub, thank you caring about our client implementation. The macro usage looks a bit weird to me, but it is Valentin's call :) Cheers, Kevin On Sunday, 2012-08-05, Jakub Filak wrote: > The current implementation of KSecretsService accepts property names of > Collection and Item without interf

Re: Review Request: Support for GRUB2 submenus

> On Aug. 7, 2012, 1:25 p.m., Oswald Buddenhagen wrote: > > kdm/backend/util.c, line 205 > > > > > > len isn't actually used in that loop It is used, it counts the occurences of before in str. This is countSubstr(

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated Aug. 7, 2012, 1:37 p.m.) Review request for KDE Runtime and Oswal

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review17032 --- kdm/backend/util.c

Re: Review Request: Make "New File -> Text File" create empty file

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105888/#review17027 --- I tried again on today's master with the two characters removed

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated Aug. 7, 2012, 9:20 a.m.) Review request for KDE Runtime and Oswal

Re: Review Request: Fix hang in kcm_useraccount

> On Aug. 6, 2012, 4:55 p.m., Rolf Eike Beer wrote: > > kdepasswd/kcm/chfnprocess.cpp, line 68 > > > > > > Why unread the line if you read it again just 3 lines below? Why not > > just put the readline() below in an

Re: Review Request: Fix hang in kcm_useraccount

> On Aug. 7, 2012, 7:26 a.m., Oswald Buddenhagen wrote: > > did you look at the changes i did in kdelibs/kdesu a while ago? this should > > probably go in line with them (i didn't check whether it already does). What should I be looking for? - Michael ---

Re: Review Request: Fix hang in kcm_useraccount

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105895/#review17018 --- did you look at the changes i did in kdelibs/kdesu a while ago?